From 6862f71d499598a27c1e6dc7dccec79fbbbec50d Mon Sep 17 00:00:00 2001 From: Tongyao Si Date: Thu, 30 May 2024 02:40:35 +0000 Subject: [PATCH 1/3] apply code review --- .../aks/preview/2024-04-02-preview/managedClusters.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2024-04-02-preview/managedClusters.json b/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2024-04-02-preview/managedClusters.json index 91bc81ae9bd2..373c5fcd2935 100644 --- a/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2024-04-02-preview/managedClusters.json +++ b/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2024-04-02-preview/managedClusters.json @@ -4919,7 +4919,7 @@ }, "PodLinkLocalAccess": { "type": "string", - "description": "Defines access to special link local addresses (IMDS and wire server) for pods with hostNetwork=false. If not specified, the default is 'IMDS'.", + "description": "Defines access to special link local addresses (IMDS(instance metadata service) and wire server) for pods with hostNetwork=false. If not specified, the default is 'IMDS'.", "enum": [ "IMDS", "None" @@ -4930,11 +4930,11 @@ "values": [ { "value": "IMDS", - "description": "Pods with hostNetwork=false can access IMDS without restriction." + "description": "Pods with hostNetwork=false can access IMDS(instance metadata service) without restriction." }, { "value": "None", - "description": "Pods with hostNetwork=false cannot access IMDS and wire server." + "description": "Pods with hostNetwork=false cannot access IMDS(instance metadata service) and wire server." } ] } @@ -5178,7 +5178,7 @@ }, "podLinkLocalAccess": { "$ref": "#/definitions/PodLinkLocalAccess", - "description": "Defines access to special link local addresses (IMDS and wire server) for pods with hostNetwork=false. if not specified, the default is 'IMDS'." + "description": "Defines access to special link local addresses (IMDS(instance metadata service) and wire server) for pods with hostNetwork=false. if not specified, the default is 'IMDS'." }, "kubeProxyConfig": { "type": "object", From 171dfacb423831301575547fcc91f7641841424a Mon Sep 17 00:00:00 2001 From: Tongyao Si Date: Thu, 30 May 2024 03:18:51 +0000 Subject: [PATCH 2/3] remove wireserver description because it's not link local address --- .../aks/preview/2024-04-02-preview/managedClusters.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2024-04-02-preview/managedClusters.json b/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2024-04-02-preview/managedClusters.json index 373c5fcd2935..14c813ef707d 100644 --- a/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2024-04-02-preview/managedClusters.json +++ b/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2024-04-02-preview/managedClusters.json @@ -4919,7 +4919,7 @@ }, "PodLinkLocalAccess": { "type": "string", - "description": "Defines access to special link local addresses (IMDS(instance metadata service) and wire server) for pods with hostNetwork=false. If not specified, the default is 'IMDS'.", + "description": "Defines access to special link local addresses(Azure Instance Metadata Service, aka IMDS) for pods with hostNetwork=false. If not specified, the default is 'IMDS'.", "enum": [ "IMDS", "None" @@ -4930,11 +4930,11 @@ "values": [ { "value": "IMDS", - "description": "Pods with hostNetwork=false can access IMDS(instance metadata service) without restriction." + "description": "Pods with hostNetwork=false can access Azure Instance Metadata Service(IMDS) without restriction." }, { "value": "None", - "description": "Pods with hostNetwork=false cannot access IMDS(instance metadata service) and wire server." + "description": "Pods with hostNetwork=false cannot access Azure Instance Metadata Service(IMDS)." } ] } @@ -5178,7 +5178,7 @@ }, "podLinkLocalAccess": { "$ref": "#/definitions/PodLinkLocalAccess", - "description": "Defines access to special link local addresses (IMDS(instance metadata service) and wire server) for pods with hostNetwork=false. if not specified, the default is 'IMDS'." + "description": "Defines access to special link local addresses(Azure Instance Metadata Service, aka IMDS) for pods with hostNetwork=false. if not specified, the default is 'IMDS'." }, "kubeProxyConfig": { "type": "object", From 80fa3f0d795c36824dcfcf654f514a0504ae7d98 Mon Sep 17 00:00:00 2001 From: Tongyao Si Date: Thu, 30 May 2024 05:38:04 +0000 Subject: [PATCH 3/3] apply code review --- .../aks/preview/2024-04-02-preview/managedClusters.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2024-04-02-preview/managedClusters.json b/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2024-04-02-preview/managedClusters.json index 14c813ef707d..211911f3cb6a 100644 --- a/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2024-04-02-preview/managedClusters.json +++ b/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2024-04-02-preview/managedClusters.json @@ -4919,7 +4919,7 @@ }, "PodLinkLocalAccess": { "type": "string", - "description": "Defines access to special link local addresses(Azure Instance Metadata Service, aka IMDS) for pods with hostNetwork=false. If not specified, the default is 'IMDS'.", + "description": "Defines access to special link local addresses (Azure Instance Metadata Service, aka IMDS) for pods with hostNetwork=false. If not specified, the default is 'IMDS'.", "enum": [ "IMDS", "None" @@ -4930,11 +4930,11 @@ "values": [ { "value": "IMDS", - "description": "Pods with hostNetwork=false can access Azure Instance Metadata Service(IMDS) without restriction." + "description": "Pods with hostNetwork=false can access Azure Instance Metadata Service (IMDS) without restriction." }, { "value": "None", - "description": "Pods with hostNetwork=false cannot access Azure Instance Metadata Service(IMDS)." + "description": "Pods with hostNetwork=false cannot access Azure Instance Metadata Service (IMDS)." } ] } @@ -5178,7 +5178,7 @@ }, "podLinkLocalAccess": { "$ref": "#/definitions/PodLinkLocalAccess", - "description": "Defines access to special link local addresses(Azure Instance Metadata Service, aka IMDS) for pods with hostNetwork=false. if not specified, the default is 'IMDS'." + "description": "Defines access to special link local addresses (Azure Instance Metadata Service, aka IMDS) for pods with hostNetwork=false. if not specified, the default is 'IMDS'." }, "kubeProxyConfig": { "type": "object",