Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix swagger examples #3091

Closed
wants to merge 102 commits into from
Closed

Conversation

vinayada1
Copy link
Contributor

@vinayada1 vinayada1 commented May 16, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

irrogozh and others added 30 commits April 25, 2018 14:36
* Network Watcher: Suppressing a validation message

* Network watcher: Fixed property name in ConnectivityCheckRequest: HTTPConfiguration -> httpConfiguration

* Revert "Network watcher: Fixed property name in ConnectivityCheckRequest: HTTPConfiguration -> httpConfiguration"

This reverts commit 857a54b.

* Fixed message in warning supression
…lusion (Azure#2911)

* SoftwareUpdateConfiguration Changes to support Inclusion

* Removed NotSelected
* Fix ASE instance metrics url

* Another location of the error
* [Storage] Add rest version 2018-02-01

* [Storage] Add storage blob API

* [Storage] Update Example for ContainerAPI

* Add multi-api configuration

* [Storage] Update Example for ContainerAPI

* [Storage] Set LegalHold Tags as required

* [Storage] use the common type defined in common-types/resource-management/v1/types.json

* [Storage] revert to use REsourceGroup defined in storage swagger since the common one has input it from client, which is breaking
* added $skip and $top to list commands

* removed skip and top for namespaces
…2942)

* Visual Search API: request schema update for filter parameter

* Add preview parent directory
* Update nodejs config for cognitive services

* Use preview version for visualSearch
* BatchAI. SDK 2018-05-01

Changes:
- Added first class support for Horovod framework
- Added first class support for custom mpi commands
- Introduced workspaces
- Introduces experiments as a grouping mechanism for related jobs
- Moved jobs from the top level into workpace/experiment
- Moved clusters and file servers from the top level into workspaces
- Removing filter and select parameters as they are not suppported yet
- Removing FileServer type as only NFS is supporter
- Removed type of output directories - server doesn't support it
- Removed 'createNew' attribute of output directory because there is no
use-case scenario for having it equal to false.

* Addressed CR feedback

* BatchAI. Get rid of booleans and added readonly attributes to where applicable
* Swagger specs for all existing versions of Microsoft.PolicyInsights

* Add support for --validate; make where clauses explicit in existing (approval request pending) suppressions; add new suppression for equivalent paths error (approval request pending)

* Fix $top in examples; fix casing in examples

* Fix two more instances of $top type in examples

* Fix metadata examples by adding content type header and changing the body to a single string

* Remove EQUIVALENT_PATH suppressions; add extendedProperties as additionalProperties; add @odata.count to operations; remove "type" from "rows" in first 2017-08-09-preview and add descriptions

* Fix remaining examples with bad casings

* Fix additionalParameters definition; fix duplicate paths

* Remove redundant operations path/definitions from one of the swagger files for each version (one per namespace is sufficient as long as both files are fed into autorest as a bundle)

* Change group name for operations path, and rename response type definition

* Change group name for operations path, and rename response type definition (old API versions)

* Reorganize files; change modelAsString for x-ms-enum to true

Reorganize files (remove resource type based subfolders; rename conflicting example files to have resource type name; change swagger spec files and MD file based on new file locations and names); change modelAsString for x-ms-enum to true based on API review board recommendation

* Dummy change to kick the CI again

* Fix operations path example contents

* Specs for 2018-04-04
* Py conf for VisualSearch

* Fix input-file path
Retrieves the list of table fragments from the Data Lake Analytics catalog
The read me was pointing to "2018-03-01-preview" which doesn't exist. Updating the tag to their current folder.
…es for 2 enums. (Azure#2953)

* Initial placeholder for 2018-05-01-preview version using the contents of 2018-01-01 version.

* Changes for the 2018-05-01-preview version.

* Added StorageBlobDeadLetterDestination.

* Added an additional enum value CloudEventV01Schema.

* Added InputSchema to topic properties.

* Tagging endpointType a required property in deadletterdestination.

* Added x-ms-azure-resource for TrackedResource, and added some default values.
… Level Balances (Azure#2857)

* This PR includes above-subscription level (Enrollment, Department, or Account) Marketplace, Usage Details, and Enrollment Level Balances.

* Updated consumption.json to fix build failure issues

* Added "Get" to Operation Name 'BalancesByBillingAccount' and also replaced priceHidden boolean type with enum for more clarity

* Added Enrollment-Level balances by BillingPeriod

* Updated BalancesByBillingAccount example files and added x-ms-parameter-location to some parameters missing that part.

* Replaced Microsoft.CostManagment with Microsoft.Billing

* Fixed example errors
* Added x-mx-odata properties for some resources currently required for cmdlet work

* New filters and nit fixes

* Fix the Webhook Model
vrdmr and others added 15 commits May 14, 2018 11:36
* Refacroting DSCNodeConfigurationCreate Parameters

* Fix the return model for Get NodeConfig call
VirtualNetworkGateways_SetVpnclientIpsecParameters AND VirtualNetworkGateways_GetVpnclientIpsecParameters are not in production
adding Vulnerability Assessemnt APIs to readme
…tation rule. (Azure#3074)

* Update openapi-authoring-automated-guidelines.md

* Update openapi-authoring-automated-guidelines.md

* Update openapi-authoring-automated-guidelines.md

* Update openapi-authoring-automated-guidelines.md

* Update openapi-authoring-automated-guidelines.md

* Update openapi-authoring-automated-guidelines.md
* Round I - Modify readmes to initiate swagger to sdk

* Round II - Add readme.ruby.md file signalr

* Round III - Added missed APIs

* Round IV - Update gem versions
No examples need to be updated because none made use of the incorrect
SKU
* Update swagger for api-version 2018-03-01
 - add many missing examples
 - improve/complete descriptions and summaries

* Fix a handful of validation failures
Add/correct some response codes

* Fix back-compat for some error codes (leaving it inconsistent)
Change policyAssignment result for nonexistent delete by ID to match all other delete methods
Attempt to fix Travis FNF error

* Fix bracket bug in last commit

* Another attempt to fix Travis CI FNF error: simplifying the example file as much as possible.

* Another attempt to fix Travis FNF error (filename casing...)

* Putting back original example, modified during troubleshooting.

* Apply PR feedback (fix errors in a couple examples)

* Correct/improve wording in description properties.
* BatchAI. Added ExperimentBaseProperties

It fixes auto-generated clients.

* BatchAI. Updated examples

Unique subdirectory will be only generated for jobs because only jobs
generate output and so may have conflict with previous job versions.

* BatchAI. Remove CreateExperimentParameters
IOOptimized was an old pre-release name for BusinessCritical.
…ationEvent/Response and SubscriptionDeletedEvent (Azure#3061)

* Added definitions for SubscriptionValidationEventData and SubscriptionDeletedEventData.

* Made the newly introduced properties readonly.

* Added subscription validation response.
* blob events trigger

* address review feedback

* resolve blob path property issue
@AutorestCI
Copy link

AutorestCI commented May 16, 2018

Automation for azure-libraries-for-java

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • cognitiveservices/data-plane/LUIS/Authoring
  • cognitiveservices/data-plane/CustomVision/Training
  • cognitiveservices/data-plane/ImageSearch
  • cognitiveservices/data-plane/CustomSearch
  • automation/resource-manager
  • adhybridhealthservice/resource-manager
  • batch/resource-manager
  • cognitiveservices/data-plane/CustomImageSearch
  • cognitiveservices/data-plane/ContentModerator
  • cognitiveservices/data-plane/EntitySearch
  • azsadmin/resource-manager/user-subscriptions
  • cognitiveservices/data-plane/ComputerVision
  • batchai/resource-manager
  • cognitiveservices/data-plane/Face
  • cdn/resource-manager
  • authorization/resource-manager
  • cognitiveservices/data-plane/LUIS/Runtime
  • azsadmin/resource-manager/update
  • azsadmin/resource-manager/network/Microsoft.Network.Admin
  • analysisservices/resource-manager
  • botservice/resource-manager
  • apimanagement/resource-manager
  • billing/resource-manager
  • cognitiveservices/data-plane/CustomVision/Prediction

@AutorestCI
Copy link

AutorestCI commented May 16, 2018

Automation for azure-sdk-for-node

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • batchai/resource-manager
  • cognitiveservices/data-plane/CustomVision/Prediction
  • cognitiveservices/data-plane/CustomSearch
  • botservice/resource-manager
  • cognitiveservices/data-plane/CustomVision/Training
  • apimanagement/resource-manager
  • cognitiveservices/data-plane/EntitySearch
  • analysisservices/resource-manager
  • azsadmin/resource-manager/update
  • cognitiveservices/data-plane/CustomImageSearch
  • batch/resource-manager
  • cognitiveservices/data-plane/Face
  • adhybridhealthservice/resource-manager
  • cognitiveservices/data-plane/ComputerVision
  • azsadmin/resource-manager/user-subscriptions
  • billing/resource-manager
  • cognitiveservices/data-plane/ContentModerator
  • cognitiveservices/data-plane/LUIS/Runtime
  • authorization/resource-manager
  • cognitiveservices/data-plane/ImageSearch
  • azsadmin/resource-manager/network/Microsoft.Network.Admin
  • cognitiveservices/data-plane/LUIS/Authoring
  • automation/resource-manager
  • cdn/resource-manager

@dsgouda
Copy link
Contributor

dsgouda commented May 16, 2018

@MikhailTryakhov since we are close to merging the May API version, do we still want to merge this PR against the May branch?

@AutorestCI
Copy link

AutorestCI commented May 17, 2018

Automation for azure-sdk-for-python

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • cognitiveservices/data-plane/LUIS/Runtime
  • cognitiveservices/data-plane/EntitySearch
  • cognitiveservices/data-plane/ComputerVision
  • batch/resource-manager
  • cognitiveservices/data-plane/ContentModerator
  • authorization/resource-manager
  • cognitiveservices/data-plane/CustomSearch
  • batchai/resource-manager
  • azsadmin/resource-manager/user-subscriptions
  • cognitiveservices/data-plane/LUIS/Authoring
  • analysisservices/resource-manager
  • cdn/resource-manager
  • cognitiveservices/data-plane/Face
  • azsadmin/resource-manager/network/Microsoft.Network.Admin
  • cognitiveservices/data-plane/CustomVision/Prediction
  • cognitiveservices/data-plane/ImageSearch
  • apimanagement/resource-manager
  • automation/resource-manager
  • azsadmin/resource-manager/update
  • cognitiveservices/data-plane/CustomVision/Training
  • billing/resource-manager
  • adhybridhealthservice/resource-manager
  • cognitiveservices/data-plane/CustomImageSearch
  • botservice/resource-manager

@AutorestCI
Copy link

AutorestCI commented May 17, 2018

Automation for azure-sdk-for-go

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • cdn/resource-manager
  • adhybridhealthservice/resource-manager
  • billing/resource-manager
  • cognitiveservices/data-plane/LUIS/Runtime
  • azsadmin/resource-manager/user-subscriptions
  • cognitiveservices/data-plane/CustomImageSearch
  • cognitiveservices/data-plane/CustomVision/Training
  • cognitiveservices/data-plane/CustomSearch
  • cognitiveservices/data-plane/ImageSearch
  • azsadmin/resource-manager/update
  • cognitiveservices/data-plane/CustomVision/Prediction
  • batch/resource-manager
  • cognitiveservices/data-plane/LUIS/Authoring
  • cognitiveservices/data-plane/EntitySearch
  • analysisservices/resource-manager
  • botservice/resource-manager
  • cognitiveservices/data-plane/ContentModerator
  • azsadmin/resource-manager/network/Microsoft.Network.Admin
  • cognitiveservices/data-plane/ComputerVision
  • batchai/resource-manager
  • automation/resource-manager
  • authorization/resource-manager
  • apimanagement/resource-manager
  • cognitiveservices/data-plane/Face

@MikhailTryakhov
Copy link
Contributor

Created #3092 instad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.