Fixexamples #3092

vinayada1 · 2018-05-16T23:44:04Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

* Created May folder. Updated version for exampls, commands * Updated package to May version * Returned NW examples * Fixed API version; Fixed NetworkWatcher examples * Fixed VPN Gateway/Connection examples * Add changes from PR#2975 https://github.com/Azure/azure-rest-api-specs/pull/2975/files

…nfig object for enhancing the Network Watcher cmdlets (Azure#3023) * Adding optional traffic analytics parameters with existing network watched flowlog configuration * Updating the version * Updating latest versoin in readme.md

* Adding optional traffic analytics parameters with existing network watched flowlog configuration * Updating the version * Updating latest versoin in readme.md * Adding optional traffic analytics parameters with flowlog parameters * Reverting old chnages

Expose new SKUs for VMSS VPN and ER gateways

* Initial network error fixes and suppressions * reworked exception to specified code blocks only * Added express route fixes

…into fixexamples

AutorestCI · 2018-05-16T23:45:32Z

Automation for azure-libraries-for-java

Encountered a Subprocess error: (azure-libraries-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmp_u57iwo2/rest/specification/network/resource-manager/readme.md', '--azure-libraries-for-java-folder=/tmp/tmp_u57iwo2/sdk', '--fluent', '--java', '--multiapi', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4278/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4278)
   Loading AutoRest extension '@microsoft.azure/autorest.java' (~2.1.32->2.1.70)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
ERROR: Syntax Error Encountered: Unexpected token , in JSON
    - file:///tmp/tmp_u57iwo2/rest/specification/network/resource-manager/Microsoft.Network/stable/2018-05-01/expressRouteCircuit.json:1207:3
ERROR: Syntax error: end of the stream or a document separator is expected
    - file:///tmp/tmp_u57iwo2/rest/specification/network/resource-manager/Microsoft.Network/stable/2018-05-01/expressRouteCircuit.json:1207:3
ERROR: Syntax error: end of the stream or a document separator is expected
    - file:///tmp/tmp_u57iwo2/rest/specification/network/resource-manager/Microsoft.Network/stable/2018-05-01/expressRouteCircuit.json:1928:3
ERROR: Syntax error: end of the stream or a document separator is expected
    - file:///tmp/tmp_u57iwo2/rest/specification/network/resource-manager/Microsoft.Network/stable/2018-05-01/expressRouteCircuit.json:1945:0
ERROR: Syntax error: expected a single document in the stream, but found more
    - file:///tmp/tmp_u57iwo2/rest/specification/network/resource-manager/Microsoft.Network/stable/2018-05-01/expressRouteCircuit.json:1207:3
FATAL: swagger-document/loader - FAILED
FATAL: Error: Syntax errors encountered.
Process() cancelled due to exception : Syntax errors encountered.
  Error: Syntax errors encountered.

AutorestCI · 2018-05-16T23:45:38Z

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

AutorestCI · 2018-05-17T00:31:56Z

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#2376

AutorestCI · 2018-05-17T00:57:22Z

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: ['/usr/local/bin/autorest', '/tmp/tmp3xhistop/rest/specification/network/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmp3xhistop/src/github.com/Azure/azure-sdk-for-go', '--multiapi', '--use=@microsoft.azure/autorest.go@~2.1.105', '--use-onever', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4280; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4280/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4280)
   Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.105->2.1.105)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2018-05"} .
ERROR: Syntax Error Encountered: Unexpected token , in JSON
    - file:///tmp/tmp3xhistop/rest/specification/network/resource-manager/Microsoft.Network/stable/2018-05-01/expressRouteCircuit.json:1207:3
ERROR: Syntax error: end of the stream or a document separator is expected
    - file:///tmp/tmp3xhistop/rest/specification/network/resource-manager/Microsoft.Network/stable/2018-05-01/expressRouteCircuit.json:1207:3
ERROR: Syntax error: end of the stream or a document separator is expected
    - file:///tmp/tmp3xhistop/rest/specification/network/resource-manager/Microsoft.Network/stable/2018-05-01/expressRouteCircuit.json:1928:3
ERROR: Syntax error: end of the stream or a document separator is expected
    - file:///tmp/tmp3xhistop/rest/specification/network/resource-manager/Microsoft.Network/stable/2018-05-01/expressRouteCircuit.json:1945:0
ERROR: Syntax error: expected a single document in the stream, but found more
    - file:///tmp/tmp3xhistop/rest/specification/network/resource-manager/Microsoft.Network/stable/2018-05-01/expressRouteCircuit.json:1207:3
FATAL: swagger-document/loader - FAILED
FATAL: Error: Syntax errors encountered.
Process() cancelled due to exception : Syntax errors encountered.
Failure during batch task - {"tag":"package-2018-05"} -- Error: Syntax errors encountered..
  Error: Syntax errors encountered.

jianghaolu · 2018-05-18T20:51:48Z

...rk/resource-manager/Microsoft.Network/stable/2018-05-01/ExpressRouteCircuitARPTableList.json

@@ -0,0 +1 @@
+{  "parameters": {    "expressRouteCircuitName": "circuitName",    "resourceGroupName": "rg1",    "api-version": "2017-11-01",    "subscriptionId": "subid",    "peeringName": "peeringName",    "devicePath": "devicePath"  },  "responses": {    "200": {        "value": [         {            "age": 0,            "interface": "Microsoft",            "ipAddress": "IPAddress",            "macAddress": "macAddress"         }        ]    },    "202": {        "value": [         {            "age": 0,            "interface": "Microsoft",            "ipAddress": "IPAddress",            "macAddress": "macAddress"         }        ]    }  }       }


Please configure your git to check in Unix style line endings.

@gimotwanMSFT was it done?

AutorestCI · 2018-05-26T00:22:59Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

MikhailTryakhov

Please follow comments in the PR

MikhailTryakhov · 2018-06-04T22:51:58Z

@gimotwanMSFT please push your PR to Network-2018-06-01 branch, merge your changes with master.

MikhailTryakhov · 2018-06-04T22:53:06Z

@gimotwanMSFT please make your changes in 2018-06-01 folder instead of May one

AutorestCI · 2018-07-03T05:44:36Z

Automation for azure-sdk-for-java

Encountered a Subprocess error: (azure-sdk-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmpy04otfnh/rest/specification/network/resource-manager/readme.md', '--azure-libraries-for-java-folder=/tmp/tmpy04otfnh/sdk', '--java', '--multiapi', '--use=@microsoft.azure/autorest.java@2.1.71', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4280; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4280/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4280)
   Loading AutoRest extension '@microsoft.azure/autorest.java' (2.1.71->2.1.71)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2018-05"} .
ERROR: Syntax Error Encountered: Unexpected token , in JSON
    - file:///tmp/tmpy04otfnh/rest/specification/network/resource-manager/Microsoft.Network/stable/2018-05-01/expressRouteCircuit.json:1207:3
ERROR: Syntax error: end of the stream or a document separator is expected
    - file:///tmp/tmpy04otfnh/rest/specification/network/resource-manager/Microsoft.Network/stable/2018-05-01/expressRouteCircuit.json:1207:3
ERROR: Syntax error: end of the stream or a document separator is expected
    - file:///tmp/tmpy04otfnh/rest/specification/network/resource-manager/Microsoft.Network/stable/2018-05-01/expressRouteCircuit.json:1928:3
ERROR: Syntax error: end of the stream or a document separator is expected
    - file:///tmp/tmpy04otfnh/rest/specification/network/resource-manager/Microsoft.Network/stable/2018-05-01/expressRouteCircuit.json:1945:0
ERROR: Syntax error: expected a single document in the stream, but found more
    - file:///tmp/tmpy04otfnh/rest/specification/network/resource-manager/Microsoft.Network/stable/2018-05-01/expressRouteCircuit.json:1207:3
FATAL: swagger-document/loader - FAILED
FATAL: Error: Syntax errors encountered.
Process() cancelled due to exception : Syntax errors encountered.
Failure during batch task - {"tag":"package-2018-05"} -- Error: Syntax errors encountered..
  Error: Syntax errors encountered.

Removing header details in the swagger

…tch-7 [Internal testing] testing openapi-alps PR 510778 - Test 11/15/2023 / 1

EvgenyAgafonchikov and others added 8 commits May 7, 2018 16:18

#AppGw Fundamentals Clean Up (Azure#3046)

cea91ef

Expose new SKUs for VMSS VPN and ER gateways (Azure#3069)

c8aea94

Expose new SKUs for VMSS VPN and ER gateways

Initial network error fixes and suppressions (Azure#3051)

6f5c90a

* Initial network error fixes and suppressions * reworked exception to specified code blocks only * Added express route fixes

Fix swagger examples

820d65b

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs …

6521d8a

…into fixexamples

vinayada1 requested review from DeepakRajendranMsft and MikhailTryakhov as code owners May 16, 2018 23:44

azuresdkci assigned jianghaolu May 16, 2018

azuresdkci requested a review from jianghaolu May 16, 2018 23:44

MikhailTryakhov mentioned this pull request May 17, 2018

Fix swagger examples #3091

Closed

10 tasks

AutorestCI mentioned this pull request May 17, 2018

[AutoPR network/resource-manager] Fixexamples Azure/azure-sdk-for-python#2576

Closed

AutorestCI mentioned this pull request May 17, 2018

[AutoPR network/resource-manager] Fixexamples Azure/azure-sdk-for-go#1851

Closed

jianghaolu reviewed May 18, 2018

View reviewed changes

gimotwanMSFT added 2 commits May 25, 2018 16:46

Merge remote-tracking branch 'upstream/master' into fixexamples

5ed9774

Fix merge conflicts

fd18483

AutorestCI mentioned this pull request May 26, 2018

[AutoPR network/resource-manager] Fixexamples Azure/azure-sdk-for-ruby#1318

Closed

MikhailTryakhov suggested changes May 28, 2018

View reviewed changes

MikhailTryakhov closed this Jul 3, 2018

AutorestCI mentioned this pull request Jul 3, 2018

[AutoPR network/resource-manager] Fixexamples Azure/azure-sdk-for-python#2864

Closed

mccleanp pushed a commit that referenced this pull request Mar 23, 2022

Merge pull request #3092 from Azure/dev/subbart/scvmmheader

6f01077

Removing header details in the swagger

konrad-jamrozik pushed a commit to dhung-msft/azure-rest-api-specs that referenced this pull request Dec 4, 2023

Merge pull request Azure#3092 from test-repo-billy/konrad-jamrozik-pa…

3c19f6f

…tch-7 [Internal testing] testing openapi-alps PR 510778 - Test 11/15/2023 / 1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixexamples #3092

Fixexamples #3092

vinayada1 commented May 16, 2018 •

edited by azuresdkci

Loading

AutorestCI commented May 16, 2018 •

edited

Loading

AutorestCI commented May 16, 2018 •

edited

Loading

AutorestCI commented May 17, 2018 •

edited

Loading

AutorestCI commented May 17, 2018 •

edited

Loading

jianghaolu May 18, 2018

MikhailTryakhov Jun 4, 2018

AutorestCI commented May 26, 2018 •

edited

Loading

MikhailTryakhov left a comment

MikhailTryakhov commented Jun 4, 2018

MikhailTryakhov commented Jun 4, 2018

AutorestCI commented Jul 3, 2018 •

edited

Loading

		@@ -0,0 +1 @@
		{ "parameters": { "expressRouteCircuitName": "circuitName", "resourceGroupName": "rg1", "api-version": "2017-11-01", "subscriptionId": "subid", "peeringName": "peeringName", "devicePath": "devicePath" }, "responses": { "200": { "value": [ { "age": 0, "interface": "Microsoft", "ipAddress": "IPAddress", "macAddress": "macAddress" } ] }, "202": { "value": [ { "age": 0, "interface": "Microsoft", "ipAddress": "IPAddress", "macAddress": "macAddress" } ] } } }

Fixexamples #3092

Fixexamples #3092

Conversation

vinayada1 commented May 16, 2018 • edited by azuresdkci Loading

PR information

Quality of Swagger

AutorestCI commented May 16, 2018 • edited Loading

Automation for azure-libraries-for-java

AutorestCI commented May 16, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented May 17, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented May 17, 2018 • edited Loading

Automation for azure-sdk-for-go

jianghaolu May 18, 2018

Choose a reason for hiding this comment

MikhailTryakhov Jun 4, 2018

Choose a reason for hiding this comment

AutorestCI commented May 26, 2018 • edited Loading

Automation for azure-sdk-for-ruby

MikhailTryakhov left a comment

Choose a reason for hiding this comment

MikhailTryakhov commented Jun 4, 2018

MikhailTryakhov commented Jun 4, 2018

AutorestCI commented Jul 3, 2018 • edited Loading

Automation for azure-sdk-for-java

vinayada1 commented May 16, 2018 •

edited by azuresdkci

Loading

AutorestCI commented May 16, 2018 •

edited

Loading

AutorestCI commented May 16, 2018 •

edited

Loading

AutorestCI commented May 17, 2018 •

edited

Loading

AutorestCI commented May 17, 2018 •

edited

Loading

AutorestCI commented May 26, 2018 •

edited

Loading

AutorestCI commented Jul 3, 2018 •

edited

Loading