Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Network 2018-06-01; VM ref fix #3118

Merged

Conversation

EvgenyAgafonchikov
Copy link
Contributor

@EvgenyAgafonchikov EvgenyAgafonchikov commented May 22, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented May 22, 2018

Automation for azure-libraries-for-java

Encountered a Subprocess error: (azure-libraries-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmp9920y5iu/rest/specification/network/resource-manager/readme.md', '--azure-libraries-for-java-folder=/tmp/tmp9920y5iu/sdk', '--fluent', '--java', '--multiapi', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4275/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4275)
   Loading AutoRest extension '@microsoft.azure/autorest.java' (~2.1.32->2.1.67)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Shutting Down
Shutting Down
FATAL: java/generate - FAILED
FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.java' terminated.
Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.java' terminated.

@AutorestCI
Copy link

AutorestCI commented May 22, 2018

Automation for azure-sdk-for-node

Encountered an unknown error: (azure-sdk-for-node)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/github_tools.py", line 32, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 167, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 182, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 246, in generate_sdk_from_git_object
    manage_git_folder(gh_token, clone_dir, branched_sdk_git_id) as sdk_folder:
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/github_tools.py", line 266, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/github_tools.py", line 197, in clone_to_path
    _git_clone_to_path(https_authenticated_url, folder, branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/git_tools.py", line 76, in clone_to_path
    repo = Repo.clone_from(https_authenticated_url, str(folder))
  File "/usr/local/lib/python3.6/dist-packages/git/repo/base.py", line 982, in clone_from
    return cls._clone(git, url, to_path, GitCmdObjectDB, progress, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/repo/base.py", line 933, in _clone
    finalize_process(proc, stderr=stderr)
  File "/usr/local/lib/python3.6/dist-packages/git/util.py", line 333, in finalize_process
    proc.wait(**kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 417, in wait
    raise GitCommandError(self.args, status, errstr)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git clone -v https://AutorestCI:58ab395c311d1bd75b3e1db1cc8adaf9acc42afe@github.com/Azure/azure-sdk-for-node.git /tmp/tmpg8iinf6z/sdk
  stderr: 'Cloning into '/tmp/tmpg8iinf6z/sdk'...
POST git-upload-pack (gzip 17452 to 8794 bytes)
error: RPC failed; curl 56 GnuTLS recv error (-9): A TLS packet with unexpected length was received.
fatal: The remote end hung up unexpectedly
fatal: early EOF
fatal: index-pack failed
'

@AutorestCI
Copy link

AutorestCI commented May 22, 2018

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmpvyxgga6w/rest/specification/network/resource-manager/readme.md', '--multiapi', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmpvyxgga6w/sdk', '--use=@microsoft.azure/autorest.python@~3.0', '--version=preview']
Finished with return code -9
and output:

AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4279/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4279)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (~3.0->3.0.51)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Processing batch task - {"tag":"package-2018-04"} .

@AutorestCI
Copy link

AutorestCI commented May 22, 2018

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@MikhailTryakhov
Copy link
Contributor

+@dsgouda could you please review

Copy link
Contributor

@MikhailTryakhov MikhailTryakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MikhailTryakhov MikhailTryakhov merged commit fdeea0e into Azure:Network-2018-06-01 May 24, 2018
EvgenyAgafonchikov added a commit to EvgenyAgafonchikov/azure-rest-api-specs that referenced this pull request Jun 19, 2018
* Init 2018-06-01 (copy from 2018-05-01)

* Make VM reference in NIC readonly

* Updated version in readme
lmazuel pushed a commit that referenced this pull request Jun 21, 2018
…1) (#3261)

* Added Network 2018-06-01; VM ref fix (#3118)

* Init 2018-06-01 (copy from 2018-05-01)

* Make VM reference in NIC readonly

* Updated version in readme

* New VPN Client Protocol (#3133)

* Added new VPN protocol

* indents

* Add examples for Express Route Circuit APIs (#3182)

* Add examples for Express Route Circuit APIs

* Fix errors in expressRouteCircuit.json validations

* Fix errors in validate examples for ExR Circuit

* appgwv2 changes (#3192)

* AppGW FIPS mode (#3202)

* Release of Azure Networking Network-2018-06-01 branch (api-version 2018-04-01)

* Adding VirtualWan Swagger (#3204)

* Adding VirtualWan Swagger

* Adding the CRUD Apis for VpnConnections

* Updating VpnGateway examples

* Fixing build errors

* Addressing comments

* Addressing comments and editing VpnConnection definition and corresponding examples

* Addressing comments

* Removing enableRateLimiting property

* Addressing comments

* Changing the version to 2018-04-01 version

* Suppress ConnectionSharedKey model issue

* Reverted extra-changes in readme
@EvgenyAgafonchikov EvgenyAgafonchikov deleted the 2018-06-01 branch May 15, 2019 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants