Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New VPN Client Protocol #3133

Merged
merged 2 commits into from
May 25, 2018
Merged

New VPN Client Protocol #3133

merged 2 commits into from
May 25, 2018

Conversation

henry416
Copy link
Member

@henry416 henry416 commented May 24, 2018 •
edited
Loading

Added one new VPN client protocol enum

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkci azuresdkci requested a review from sergey-shandar May 24, 2018 18:53
@AutorestCI AutorestCI mentioned this pull request May 24, 2018
Open
@AutorestCI
Copy link

AutorestCI commented May 24, 2018 •
edited
Loading

Automation for azure-libraries-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
AutorestCI/azure-libraries-for-java#22

@AutorestCI
Copy link

AutorestCI commented May 24, 2018 •
edited
Loading

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmpqf6_pfrj/rest/specification/network/resource-manager/readme.md', '--multiapi', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmpqf6_pfrj/sdk', '--use=@microsoft.azure/autorest.python@~3.0', '--version=preview']
Finished with return code -9
and output:

AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4279/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4279)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (~3.0->3.0.51)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Processing batch task - {"tag":"package-2018-04"} .
Processing batch task - {"tag":"package-2018-02"} .
Processing batch task - {"tag":"package-2018-01"} .
Processing batch task - {"tag":"package-2017-11"} .

@AutorestCI
Copy link

AutorestCI commented May 24, 2018 •
edited
Loading

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@AutorestCI AutorestCI mentioned this pull request May 24, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented May 24, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented May 24, 2018 •
edited
Loading

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: ['/usr/local/bin/autorest', '/tmp/tmpqyezuo8q/rest/specification/network/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmpqyezuo8q/src/github.com/Azure/azure-sdk-for-go', '--multiapi', '--use=@microsoft.azure/autorest.go@~2.1.98', '--use-onever', '--verbose']
Finished with return code -9
and output:

AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4275/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4275)
   Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.98->2.1.98)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2018-05"} .
Processing batch task - {"tag":"package-2018-04"} .
Processing batch task - {"tag":"package-2018-02"} .
Processing batch task - {"tag":"package-2018-01"} .
Processing batch task - {"tag":"package-2017-11"} .
Processing batch task - {"tag":"package-2017-10"} .
Processing batch task - {"tag":"package-2017-09"} .
Processing batch task - {"tag":"package-2017-08"} .

MikhailTryakhov
MikhailTryakhov suggested changes May 24, 2018
View reviewed changes
Copy link
Contributor

@MikhailTryakhov MikhailTryakhov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, you need use the latest branch Network-2018-06-01
and same named fodler. Please make your PR to the 2018-06-01 instead of May one, not to master.

Link to one note

@henry416 henry416 changed the base branch from master to Network-2018-06-01 May 24, 2018 23:05
@henry416
Copy link
Member Author

@MikhailTryakhov I have moved the commit and retargeted the branch to 2018-06-01.
Will this allow production rollout at the end of June? Or is there an earlier one I can use?

@MikhailTryakhov
Copy link
Contributor

@henry416 it would be done in time

MikhailTryakhov
MikhailTryakhov reviewed May 24, 2018
View reviewed changes
Copy link
Contributor

@MikhailTryakhov MikhailTryakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@henry416 sorry are your changes with correct indents?

@henry416
Copy link
Member Author

@MikhailTryakhov Indented

@MikhailTryakhov MikhailTryakhov merged commit 1b23f20 into Azure:Network-2018-06-01 May 25, 2018
@henry416
Copy link
Member Author

@MikhailTryakhov When will SDK be generated?

@MikhailTryakhov
Copy link
Contributor

@henry416 Link to milestones

This was referenced May 31, 2018
Closed
Closed
EvgenyAgafonchikov pushed a commit to EvgenyAgafonchikov/azure-rest-api-specs that referenced this pull request Jun 19, 2018
@henry416 @EvgenyAgafonchikov
New VPN Client Protocol (Azure#3133)
d5508a8 
* Added new VPN protocol

* indents
lmazuel pushed a commit that referenced this pull request Jun 21, 2018
@MikhailTryakhov @lmazuel
Release of Azure Networking Network-2018-06-01 (api-version 2018-04-0…
64909dc 
…1) (#3261)

* Added Network 2018-06-01; VM ref fix (#3118)

* Init 2018-06-01 (copy from 2018-05-01)

* Make VM reference in NIC readonly

* Updated version in readme

* New VPN Client Protocol (#3133)

* Added new VPN protocol

* indents

* Add examples for Express Route Circuit APIs (#3182)

* Add examples for Express Route Circuit APIs

* Fix errors in expressRouteCircuit.json validations

* Fix errors in validate examples for ExR Circuit

* appgwv2 changes (#3192)

* AppGW FIPS mode (#3202)

* Release of Azure Networking Network-2018-06-01 branch (api-version 2018-04-01)

* Adding VirtualWan Swagger (#3204)

* Adding VirtualWan Swagger

* Adding the CRUD Apis for VpnConnections

* Updating VpnGateway examples

* Fixing build errors

* Addressing comments

* Addressing comments and editing VpnConnection definition and corresponding examples

* Addressing comments

* Removing enableRateLimiting property

* Addressing comments

* Changing the version to 2018-04-01 version

* Suppress ConnectionSharedKey model issue

* Reverted extra-changes in readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikhailTryakhov MikhailTryakhov MikhailTryakhov approved these changes

@DeepakRajendranMsft DeepakRajendranMsft Awaiting requested review from DeepakRajendranMsft

@sergey-shandar sergey-shandar Awaiting requested review from sergey-shandar

Assignees

@sergey-shandar sergey-shandar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@henry416 @AutorestCI @MikhailTryakhov @sergey-shandar