From d9da05ef53ccf96abda3519ce4b6c304966c80a5 Mon Sep 17 00:00:00 2001 From: Alfred Sin Date: Tue, 17 Jul 2018 16:15:37 -0700 Subject: [PATCH 01/29] add serial console reference --- .../examples/DisableConsole500Error.json | 16 ++ .../examples/EnableConsoleExample.json | 13 ++ .../examples/GetConsoleDisabledExample.json | 13 ++ .../2018-07-01-preview/serialconsole.json | 169 ++++++++++++++++++ 4 files changed, 211 insertions(+) create mode 100644 specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/DisableConsole500Error.json create mode 100644 specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/EnableConsoleExample.json create mode 100644 specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetConsoleDisabledExample.json create mode 100644 specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/DisableConsole500Error.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/DisableConsole500Error.json new file mode 100644 index 000000000000..6bb128a1b370 --- /dev/null +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/DisableConsole500Error.json @@ -0,0 +1,16 @@ +{ + "parameters": { + "api-version": "2018-07-01-preview", + "subscriptionId": "9ee2ec52-83c0-405e-a009-6636ead37acd" + }, + "responses": { + "500": { + "body": { + "ErrorMessage": { + "type": "string", + "description": "Details on Failure" + } + } + } + } +} \ No newline at end of file diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/EnableConsoleExample.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/EnableConsoleExample.json new file mode 100644 index 000000000000..32c6a8742566 --- /dev/null +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/EnableConsoleExample.json @@ -0,0 +1,13 @@ +{ + "parameters": { + "api-version": "2018-07-01-preview", + "subscriptionId": "9ee2ec52-83c0-405e-a009-6636ead37acd" + }, + "responses": { + "200": { + "body": { + "disabled": "false" + } + } + } +} \ No newline at end of file diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetConsoleDisabledExample.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetConsoleDisabledExample.json new file mode 100644 index 000000000000..cbcfa21f1968 --- /dev/null +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetConsoleDisabledExample.json @@ -0,0 +1,13 @@ +{ + "parameters": { + "api-version": "2018-07-01-preview", + "subscriptionId": "9ee2ec52-83c0-405e-a009-6636ead37acd" + }, + "responses": { + "200": { + "body": { + "disabled": "true" + } + } + } +} \ No newline at end of file diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json new file mode 100644 index 000000000000..0133b8e163f8 --- /dev/null +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json @@ -0,0 +1,169 @@ +{ + "swagger": "2.0", + "info": { + "title": "MicrosoftSerialConsoleClient", + "version": "2018-05-01", + "description": "Azure Virtual Machine Serial Console allows you to access serial console of a Virtual Machine" + }, + "host": "management.azure.com", + "schemes": [ + "https" + ], + "consumes": [ + "application/json", + "text/json" + ], + "produces": [ + "application/json", + "text/json" + ], + "security": [ + { + "azure_auth": [ + "user_impersonation" + ] + } + ], + "securityDefinitions": { + "azure_auth": { + "type": "oauth2", + "authorizationUrl": "https://login.microsoftonline.com/common/oauth2/authorize", + "flow": "implicit", + "description": "Azure Active Directory OAuth2 Flow", + "scopes": { + "user_impersonation": "impersonate your user account" + } + } + }, + "paths": { + "/subscriptions/{subscriptionId}/providers/Microsoft.SerialConsole/consoleServices/{default}": { + "get": { + "tags": [ + "ConsoleDisabled" + ], + "operationId": "ListConsole_Disabled", + "description": "Gets if Serial Console is disabled for a subscription.", + "parameters": [ + { + "$ref": "#/parameters/ApiVersionParameter" + }, + { + "$ref": "#/parameters/SubscriptionIdParameter" + } + ], + "responses": { + "200": { + "description": "OK - Returns a JSON object" + } + } + } + }, + "/subscriptions/{subscriptionId}/providers/Microsoft.SerialConsole/providers/consoleServices/{default}/enableConsole": { + "post": { + "tags": [ + "EnableConsole" + ], + "operationId": "Console_enableconsole", + "description": "Enables Serial Console for a VM", + "parameters": [ + { + "name": "parameters", + "in": "body", + "required": true, + "schema": { + "$ref": "#/definitions/ConsoleProperties" + }, + "description": "Parameters for Console enablement" + }, + { + "$ref": "#/parameters/ApiVersionParameter" + }, + { + "$ref": "#/parameters/SubscriptionIdParameter" + } + ], + "responses": { + "200": { + "description": "OK - Serial Console disabled" + }, + "500": { + "description": " Internal Server Error", + "schema": { + "$ref": "#/definitions/DeploymentValidateResult" + } + } + } + } + }, + "/subscriptions/{subscriptionId}/providers/Microsoft.SerialConsole/providers/consoleServices/{default}/disableConsole": { + "post": { + "tags": [ + "DisableConsole" + ], + "operationId": "Console_disableconsole", + "description": "Disables Serial Console for a VM", + "parameters": [ + { + "$ref": "#/parameters/ApiVersionParameter" + }, + { + "$ref": "#/parameters/SubscriptionIdParameter" + } + ], + "responses": { + "200": { + "description": "OK - Serial Console disabled" + }, + "500": { + "description": " Internal Server Error", + "schema": { + "$ref": "#/definitions/DeploymentValidateResult" + } + } + } + } + } + }, + "definitions": { + "SerialConsoleGetResult": { + "properties": { + "value": { + "type": "boolean", + "description": "Returns whether or not Serial Console is disabled." + } + } + }, + "ConsoleProperties": { + "properties": { + "vmSubId": { + "type": "string", + "description": "VM's subscription ID" + } + } + }, + "DeploymentValidateResult": { + "properties": { + "ErrorMessage": { + "type": "string", + "description": "Details on Failure" + } + } + } + }, + "parameters": { + "SubscriptionIdParameter": { + "name": "subscriptionId", + "in": "path", + "required": true, + "type": "string", + "description": "The ID of the target subscription." + }, + "ApiVersionParameter": { + "name": "api-version", + "in": "query", + "required": true, + "type": "string", + "description": "The API version to use for this operation." + } + } +} \ No newline at end of file From f6886e6256c49987aaf7e6526e28c3e9fb0ea7d2 Mon Sep 17 00:00:00 2001 From: Alfred Sin Date: Tue, 24 Jul 2018 18:21:41 -0700 Subject: [PATCH 02/29] update version --- profiles/ResourceSchemas.md | 19 ++++++++++--------- .../2018-07-01-preview/serialconsole.json | 2 +- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/profiles/ResourceSchemas.md b/profiles/ResourceSchemas.md index 62b171d9776f..4f5219d496aa 100644 --- a/profiles/ResourceSchemas.md +++ b/profiles/ResourceSchemas.md @@ -2,15 +2,15 @@ > see https://aka.ms/autorest -``` yaml +``` yaml batch: output-folder: c:/work/github/azure-resource-manager-schemas/generated override-info: title: $(name) - azureresourceschema: + azureresourceschema: note: This generates all the Azure Resource Schemas into the specified folder (merging as it goes) -``` +``` ## Specifications @@ -18,7 +18,7 @@ This should include every single REST-API specification for every Azure Resource ``` yaml batch: - input-file: + input-file: - ../specification/customer-insights/resource-manager/Microsoft.CustomerInsights/2017-01-01/customer-insights.json - ../specification/automation/resource-manager/Microsoft.Automation/2015-10-31/account.json - ../specification/automation/resource-manager/Microsoft.Automation/2015-10-31/certificate.json @@ -38,7 +38,7 @@ batch: - ../specification/automation/resource-manager/Microsoft.Automation/2015-10-31/schedule.json - ../specification/automation/resource-manager/Microsoft.Automation/2015-10-31/variable.json - ../specification/automation/resource-manager/Microsoft.Automation/2015-10-31/webhook.json - + - ../specification/advisor/resource-manager/Microsoft.Advisor/2016-07-12-preview/advisor.json - ../specification/advisor/resource-manager/Microsoft.Advisor/2017-03-31/advisor.json - ../specification/advisor/resource-manager/Microsoft.Advisor/2017-04-19/advisor.json @@ -93,7 +93,7 @@ batch: - ../specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/2016-06-27-preview/containerregistry.json - ../specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/2017-03-01/containerregistry.json - ../specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/2017-06-01-preview/containerregistry.json - + - ../specification/datalake-analytics/resource-manager/Microsoft.DataLakeAnalytics/2015-10-01-preview/account.json - ../specification/datalake-analytics/resource-manager/Microsoft.DataLakeAnalytics/2015-10-01-preview/catalog.json - ../specification/datalake-analytics/resource-manager/Microsoft.DataLakeAnalytics/2015-11-01-preview/job.json @@ -243,6 +243,7 @@ batch: - ../specification/scheduler/resource-manager/Microsoft.Scheduler/2016-03-01/scheduler.json - ../specification/search/resource-manager/Microsoft.Search/2015-02-28/search.json - ../specification/search/resource-manager/Microsoft.Search/2015-08-19/search.json + - ../specification/serialconsole/resource-manager/Microsoft.SerialConsole/2018-07-01-preview/serialconsole.json - ../specification/servermanagement/resource-manager/Microsoft.ServerManagement/2015-07-01-preview/servermanagement.json - ../specification/servermanagement/resource-manager/Microsoft.ServerManagement/2016-07-01-preview/servermanagement.json - ../specification/service-map/resource-manager/Microsoft.OperationalInsights/2015-11-01-preview/arm-service-map.json @@ -268,7 +269,7 @@ batch: - ../specification/storage/resource-manager/Microsoft.Storage/2016-12-01/storage.json - ../specification/storageimportexport/resource-manager/Microsoft.ImportExport/2016-11-01/storageimportexport.json - ../specification/storsimple8000series/resource-manager/Microsoft.StorSimple/2017-06-01/storsimple.json - + - ../specification/trafficmanager/resource-manager/Microsoft.Network/2015-11-01/trafficmanager.json - ../specification/trafficmanager/resource-manager/Microsoft.Network/2017-03-01/trafficmanager.json - ../specification/web/resource-manager/Microsoft.CertificateRegistration/2015-08-01/AppServiceCertificateOrders.json @@ -284,7 +285,7 @@ batch: - ../specification/web/resource-manager/Microsoft.Web/2016-08-01/WebApps.json - ../specification/web/resource-manager/Microsoft.Web/2016-09-01/AppServiceEnvironments.json - ../specification/web/resource-manager/Microsoft.Web/2016-09-01/AppServicePlans.json - + # some invalid swagger # - ../specification/timeseriesinsights/resource-manager/Microsoft.TimeSeriesInsights/2017-02-28-preview/timeseriesinsights.json -``` \ No newline at end of file +``` \ No newline at end of file diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json index 0133b8e163f8..9fd9d13f6157 100644 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json @@ -2,7 +2,7 @@ "swagger": "2.0", "info": { "title": "MicrosoftSerialConsoleClient", - "version": "2018-05-01", + "version": "2018-07-01-preview", "description": "Azure Virtual Machine Serial Console allows you to access serial console of a Virtual Machine" }, "host": "management.azure.com", From aa4b2caf0c3ccb7c284d2103eaa3f61a9298d5cb Mon Sep 17 00:00:00 2001 From: Alfred Sin Date: Fri, 27 Jul 2018 11:59:14 -0700 Subject: [PATCH 03/29] Add readme.md --- .../serialconsole/resource-manager/readme.md | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 specification/serialconsole/resource-manager/readme.md diff --git a/specification/serialconsole/resource-manager/readme.md b/specification/serialconsole/resource-manager/readme.md new file mode 100644 index 000000000000..a044b5f27df8 --- /dev/null +++ b/specification/serialconsole/resource-manager/readme.md @@ -0,0 +1,13 @@ +# Serial Console +> see https://aka.ms/autorest + +## Getting Started +To build the SDKs for My API, simply install AutoRest via `npm` (`npm install -g autorest`) and then run: +> `autorest readme.md` + +To see additional help and options, run: +> `autorest --help` + +For other options on installation see [Installing AutoRest](https://aka.ms/autorest/install) on the AutoRest github page. + +--- From fb334570d6039a63d4b7c1e232155b77061f2626 Mon Sep 17 00:00:00 2001 From: Alfred Sin Date: Sun, 29 Jul 2018 13:25:48 -0700 Subject: [PATCH 04/29] update readme.md --- .../serialconsole/resource-manager/readme.md | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/specification/serialconsole/resource-manager/readme.md b/specification/serialconsole/resource-manager/readme.md index a044b5f27df8..2d2b5888a218 100644 --- a/specification/serialconsole/resource-manager/readme.md +++ b/specification/serialconsole/resource-manager/readme.md @@ -1,8 +1,10 @@ # Serial Console > see https://aka.ms/autorest +This is the AutoRest configuration file for Serial Console. + ## Getting Started -To build the SDKs for My API, simply install AutoRest via `npm` (`npm install -g autorest`) and then run: +To build the SDKs for Serial Console, simply install AutoRest via `npm` (`npm install -g autorest`) and then run: > `autorest readme.md` To see additional help and options, run: @@ -11,3 +13,15 @@ To see additional help and options, run: For other options on installation see [Installing AutoRest](https://aka.ms/autorest/install) on the AutoRest github page. --- + +## Configuration + +### Basic Information +These are the global settings for the Serial Console API. + +``` yaml +openapi-type: arm +tag: package-2018-07 +input-file: +- Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json +``` \ No newline at end of file From cb35540bb248996cc5498c0745e66a844eec7768 Mon Sep 17 00:00:00 2001 From: Alfred Sin Date: Sun, 29 Jul 2018 13:49:33 -0700 Subject: [PATCH 05/29] add config to readme --- .../serialconsole/resource-manager/readme.md | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/specification/serialconsole/resource-manager/readme.md b/specification/serialconsole/resource-manager/readme.md index 2d2b5888a218..7cb3e2c3cde8 100644 --- a/specification/serialconsole/resource-manager/readme.md +++ b/specification/serialconsole/resource-manager/readme.md @@ -21,7 +21,24 @@ These are the global settings for the Serial Console API. ``` yaml openapi-type: arm +azure-arm: true tag: package-2018-07 input-file: - Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json +output-folder: ./Generated +``` + + +--- +# Code Generation + +## C# + +These settings apply only when `--csharp` is specified on the command line. + +``` yaml $(csharp) +csharp: + azure-arm: true + output-folder: ./Generated + clear-output-folder: true ``` \ No newline at end of file From 42e08bce706e6253d2d1954b9289445637ec7bbe Mon Sep 17 00:00:00 2001 From: Alfred Sin Date: Mon, 30 Jul 2018 15:08:39 -0700 Subject: [PATCH 06/29] update default parameter --- .../2018-07-01-preview/serialconsole.json | 30 +++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json index 9fd9d13f6157..8ae6f7896b30 100644 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json @@ -49,6 +49,16 @@ }, { "$ref": "#/parameters/SubscriptionIdParameter" + }, + { + "name": "default", + "in": "path", + "required": true, + "type": "string", + "description": "Default string modeled as parameter for URL to work correctly.", + "enum": [ + "default" + ], } ], "responses": { @@ -80,6 +90,16 @@ }, { "$ref": "#/parameters/SubscriptionIdParameter" + }, + { + "name": "default", + "in": "path", + "required": true, + "type": "string", + "description": "Default string modeled as parameter for URL to work correctly.", + "enum": [ + "default" + ], } ], "responses": { @@ -108,6 +128,16 @@ }, { "$ref": "#/parameters/SubscriptionIdParameter" + }, + { + "name": "default", + "in": "path", + "required": true, + "type": "string", + "description": "Default string modeled as parameter for URL to work correctly.", + "enum": [ + "default" + ], } ], "responses": { From 7e417b005c4517f74e37966ac786595fbd490989 Mon Sep 17 00:00:00 2001 From: Alfred Sin Date: Mon, 30 Jul 2018 15:13:05 -0700 Subject: [PATCH 07/29] fix json --- .../preview/2018-07-01-preview/serialconsole.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json index 8ae6f7896b30..c5a39579c46b 100644 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json @@ -58,7 +58,7 @@ "description": "Default string modeled as parameter for URL to work correctly.", "enum": [ "default" - ], + ] } ], "responses": { @@ -99,7 +99,7 @@ "description": "Default string modeled as parameter for URL to work correctly.", "enum": [ "default" - ], + ] } ], "responses": { @@ -137,7 +137,7 @@ "description": "Default string modeled as parameter for URL to work correctly.", "enum": [ "default" - ], + ] } ], "responses": { From 263940981a91c12e505f94d209bf5e3d7349157f Mon Sep 17 00:00:00 2001 From: Alfred Sin Date: Mon, 30 Jul 2018 18:30:31 -0700 Subject: [PATCH 08/29] fix camelcase error --- .../preview/2018-07-01-preview/serialconsole.json | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json index c5a39579c46b..a5f97926ed4b 100644 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json @@ -10,12 +10,10 @@ "https" ], "consumes": [ - "application/json", - "text/json" + "application/json" ], "produces": [ - "application/json", - "text/json" + "application/json" ], "security": [ { @@ -159,6 +157,7 @@ "properties": { "value": { "type": "boolean", + "title": "Serial Console GET Result", "description": "Returns whether or not Serial Console is disabled." } } @@ -167,14 +166,16 @@ "properties": { "vmSubId": { "type": "string", + "title": "VM's subscription ID", "description": "VM's subscription ID" } } }, "DeploymentValidateResult": { "properties": { - "ErrorMessage": { + "errorMessage": { "type": "string", + "title": "Details on Failure", "description": "Details on Failure" } } From 7f302d1565bd566b60f952a9d38415a4de8142e7 Mon Sep 17 00:00:00 2001 From: Alfred Sin Date: Mon, 30 Jul 2018 18:38:42 -0700 Subject: [PATCH 09/29] add x-ms-examples --- .../examples/DisableConsole500Error.json | 16 -------------- .../2018-07-01-preview/serialconsole.json | 21 ++++++++++++++++--- 2 files changed, 18 insertions(+), 19 deletions(-) delete mode 100644 specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/DisableConsole500Error.json diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/DisableConsole500Error.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/DisableConsole500Error.json deleted file mode 100644 index 6bb128a1b370..000000000000 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/DisableConsole500Error.json +++ /dev/null @@ -1,16 +0,0 @@ -{ - "parameters": { - "api-version": "2018-07-01-preview", - "subscriptionId": "9ee2ec52-83c0-405e-a009-6636ead37acd" - }, - "responses": { - "500": { - "body": { - "ErrorMessage": { - "type": "string", - "description": "Details on Failure" - } - } - } - } -} \ No newline at end of file diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json index a5f97926ed4b..434fa33f7e02 100644 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json @@ -63,7 +63,12 @@ "200": { "description": "OK - Returns a JSON object" } - } + }, + "x-ms-examples": { + "Get whether or not Serial Console is disabled": { + "$ref": "./examples/GetConsoleDisabledExample.json" + } + }, } }, "/subscriptions/{subscriptionId}/providers/Microsoft.SerialConsole/providers/consoleServices/{default}/enableConsole": { @@ -110,7 +115,12 @@ "$ref": "#/definitions/DeploymentValidateResult" } } - } + }, + "x-ms-examples": { + "Enable console successfully": { + "$ref": "./examples/EnableConsoleExample.json" + } + }, } }, "/subscriptions/{subscriptionId}/providers/Microsoft.SerialConsole/providers/consoleServices/{default}/disableConsole": { @@ -148,7 +158,12 @@ "$ref": "#/definitions/DeploymentValidateResult" } } - } + }, + "x-ms-examples": { + "Attempt to disable console and receive a 500 error": { + "$ref": "./examples/DisableConsoleExample.json" + } + }, } } }, From 8f30592082728df6cc1ecdc1c192716b8d2a5aba Mon Sep 17 00:00:00 2001 From: Alfred Sin Date: Mon, 30 Jul 2018 18:39:10 -0700 Subject: [PATCH 10/29] add renamed DisableConsoleExample.json --- .../examples/DisableConsoleExample.json | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) create mode 100644 specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/DisableConsoleExample.json diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/DisableConsoleExample.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/DisableConsoleExample.json new file mode 100644 index 000000000000..6bb128a1b370 --- /dev/null +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/DisableConsoleExample.json @@ -0,0 +1,16 @@ +{ + "parameters": { + "api-version": "2018-07-01-preview", + "subscriptionId": "9ee2ec52-83c0-405e-a009-6636ead37acd" + }, + "responses": { + "500": { + "body": { + "ErrorMessage": { + "type": "string", + "description": "Details on Failure" + } + } + } + } +} \ No newline at end of file From 88b7d7da3c4996065197f947ac19650b6d3c62dd Mon Sep 17 00:00:00 2001 From: Alfred Sin Date: Mon, 30 Jul 2018 18:44:33 -0700 Subject: [PATCH 11/29] fix json --- .../preview/2018-07-01-preview/serialconsole.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json index 434fa33f7e02..90f575e7f1ad 100644 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json @@ -68,7 +68,7 @@ "Get whether or not Serial Console is disabled": { "$ref": "./examples/GetConsoleDisabledExample.json" } - }, + } } }, "/subscriptions/{subscriptionId}/providers/Microsoft.SerialConsole/providers/consoleServices/{default}/enableConsole": { @@ -120,7 +120,7 @@ "Enable console successfully": { "$ref": "./examples/EnableConsoleExample.json" } - }, + } } }, "/subscriptions/{subscriptionId}/providers/Microsoft.SerialConsole/providers/consoleServices/{default}/disableConsole": { @@ -163,7 +163,7 @@ "Attempt to disable console and receive a 500 error": { "$ref": "./examples/DisableConsoleExample.json" } - }, + } } } }, From 3b17d69a16ef4992d329e3a63ee19c251dfaaacd Mon Sep 17 00:00:00 2001 From: Alfred Sin Date: Thu, 2 Aug 2018 16:55:54 -0700 Subject: [PATCH 12/29] add operations, address github comments --- .../examples/DisableConsoleExample.json | 5 +- .../examples/EnableConsoleExample.json | 7 +- .../examples/GetConsoleDisabledExample.json | 7 +- .../examples/GetOperationsExample.json | 11 ++ .../2018-07-01-preview/serialconsole.json | 166 ++++++++++++------ 5 files changed, 133 insertions(+), 63 deletions(-) create mode 100644 specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetOperationsExample.json diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/DisableConsoleExample.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/DisableConsoleExample.json index 6bb128a1b370..afc147ade52c 100644 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/DisableConsoleExample.json +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/DisableConsoleExample.json @@ -1,12 +1,13 @@ { "parameters": { "api-version": "2018-07-01-preview", - "subscriptionId": "9ee2ec52-83c0-405e-a009-6636ead37acd" + "subscriptionId": "00000000-00000-0000-0000-000000000000", + "default": "default" }, "responses": { "500": { "body": { - "ErrorMessage": { + "errorMessage": { "type": "string", "description": "Details on Failure" } diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/EnableConsoleExample.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/EnableConsoleExample.json index 32c6a8742566..d61e82ce8821 100644 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/EnableConsoleExample.json +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/EnableConsoleExample.json @@ -1,13 +1,12 @@ { "parameters": { "api-version": "2018-07-01-preview", - "subscriptionId": "9ee2ec52-83c0-405e-a009-6636ead37acd" + "subscriptionId": "00000000-00000-0000-0000-000000000000", + "default": "default" }, "responses": { "200": { - "body": { - "disabled": "false" - } + "disabled": "false" } } } \ No newline at end of file diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetConsoleDisabledExample.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetConsoleDisabledExample.json index cbcfa21f1968..9a69de63d54d 100644 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetConsoleDisabledExample.json +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetConsoleDisabledExample.json @@ -1,13 +1,12 @@ { "parameters": { "api-version": "2018-07-01-preview", - "subscriptionId": "9ee2ec52-83c0-405e-a009-6636ead37acd" + "subscriptionId": "00000000-00000-0000-0000-000000000000", + "default": "default" }, "responses": { "200": { - "body": { - "disabled": "true" - } + "disabled": "true" } } } \ No newline at end of file diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetOperationsExample.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetOperationsExample.json new file mode 100644 index 000000000000..256c72d84392 --- /dev/null +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetOperationsExample.json @@ -0,0 +1,11 @@ +{ + "parameters": { + "api-version": "2018-07-01-preview", + "subscriptionId": "00000000-00000-0000-0000-000000000000" + }, + "responses": { + "200": { + "value": "Get operations response" + } + } +} \ No newline at end of file diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json index 90f575e7f1ad..ef3bacbee8f1 100644 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json @@ -34,6 +34,45 @@ } }, "paths": { + "/subscriptions/{subscriptionId}/providers/Microsoft.SerialConsole/operations": { + "get": { + "tags": [ + "SerialConsole" + ], + "operationId": "List_Operations", + "description": "Gets a list of Serial Console API operations.", + "x-ms-examples": { + "List all Serial Console management operations supported by Serial Console RP": { + "$ref": "./examples/GetOperationsExample.json" + } + }, + "consumes": [ + "application/json" + ], + "produces": [ + "application/json" + ], + "parameters": [ + { + "$ref": "#/parameters/ApiVersionParameter" + }, + { + "$ref": "#/parameters/SubscriptionIdParameter" + }, + { + "$ref": "#/parameters/default" + } + ], + "responses": { + "200": { + "description": "OK - returns a JSON object", + "schema": { + "$ref": "#/definitions/SerialConsoleOperations" + } + } + } + } + }, "/subscriptions/{subscriptionId}/providers/Microsoft.SerialConsole/consoleServices/{default}": { "get": { "tags": [ @@ -49,24 +88,26 @@ "$ref": "#/parameters/SubscriptionIdParameter" }, { - "name": "default", - "in": "path", - "required": true, - "type": "string", - "description": "Default string modeled as parameter for URL to work correctly.", - "enum": [ - "default" - ] + "$ref": "#/parameters/default" } ], "responses": { "200": { - "description": "OK - Returns a JSON object" + "description": "OK - Returns a JSON object", + "schema": { + "$ref": "#/definitions/GetDisabledResult" + } + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "#/definitions/DeploymentValidateResult" + } } }, "x-ms-examples": { "Get whether or not Serial Console is disabled": { - "$ref": "./examples/GetConsoleDisabledExample.json" + "$ref": "./examples/GetConsoleDisabledExample.json" } } } @@ -79,15 +120,6 @@ "operationId": "Console_enableconsole", "description": "Enables Serial Console for a VM", "parameters": [ - { - "name": "parameters", - "in": "body", - "required": true, - "schema": { - "$ref": "#/definitions/ConsoleProperties" - }, - "description": "Parameters for Console enablement" - }, { "$ref": "#/parameters/ApiVersionParameter" }, @@ -95,22 +127,18 @@ "$ref": "#/parameters/SubscriptionIdParameter" }, { - "name": "default", - "in": "path", - "required": true, - "type": "string", - "description": "Default string modeled as parameter for URL to work correctly.", - "enum": [ - "default" - ] + "$ref": "#/parameters/default" } ], "responses": { "200": { - "description": "OK - Serial Console disabled" + "description": "OK - Serial Console disabled", + "schema": { + "$ref": "#/definitions/SetDisabledResult" + } }, - "500": { - "description": " Internal Server Error", + "default": { + "description": "Error response describing why the operation failed.", "schema": { "$ref": "#/definitions/DeploymentValidateResult" } @@ -118,7 +146,7 @@ }, "x-ms-examples": { "Enable console successfully": { - "$ref": "./examples/EnableConsoleExample.json" + "$ref": "./examples/EnableConsoleExample.json" } } } @@ -138,22 +166,18 @@ "$ref": "#/parameters/SubscriptionIdParameter" }, { - "name": "default", - "in": "path", - "required": true, - "type": "string", - "description": "Default string modeled as parameter for URL to work correctly.", - "enum": [ - "default" - ] + "$ref": "#/parameters/default" } ], "responses": { "200": { - "description": "OK - Serial Console disabled" + "description": "OK - Serial Console disabled", + "schema": { + "$ref": "#/definitions/SetDisabledResult" + } }, - "500": { - "description": " Internal Server Error", + "default": { + "description": "Error response describing why the operation failed.", "schema": { "$ref": "#/definitions/DeploymentValidateResult" } @@ -169,29 +193,53 @@ }, "definitions": { "SerialConsoleGetResult": { + "title": "Serial Console GET Result", + "description": "Returns whether or not Serial Console is disabled.", "properties": { "value": { - "type": "boolean", - "title": "Serial Console GET Result", - "description": "Returns whether or not Serial Console is disabled." + "description": "Whether or not Serial Console is disabled.", + "type": "boolean" } } }, - "ConsoleProperties": { + "GetDisabledResult": { + "title": "Get Disabled result", + "description": "Returns whether or not Serial Console is disabled for ths given subscription", "properties": { - "vmSubId": { - "type": "string", - "title": "VM's subscription ID", - "description": "VM's subscription ID" + "disabled": { + "description": "Disabled result", + "type": "boolean" + } + } + }, + "SetDisabledResult": { + "title": "Set Disabled result", + "description": "Sets disable status and returns whether or not Serial Console is now disabled for ths given subscription", + "properties": { + "disabled": { + "description": "Disabled result", + "type": "boolean" } } }, "DeploymentValidateResult": { + "title": "Details on Failure", + "description": "Details on Failure", "properties": { "errorMessage": { - "type": "string", - "title": "Details on Failure", - "description": "Details on Failure" + "description": "Error message", + "type": "string" + } + } + }, + "SerialConsoleOperations": { + "title": "Serial Console operations", + "description": "Serial Console operations", + "type": "object", + "properties": { + "value": { + "description": "Serial Console operations", + "type": "string" } } } @@ -210,6 +258,18 @@ "required": true, "type": "string", "description": "The API version to use for this operation." + }, + "default" :{ + "name": "default", + "in": "path", + "required": true, + "type": "string", + "description": "Default string modeled as parameter for URL to work correctly.", + "enum": [ + "default" + ], + "x-ms-parameter-location": "client" } + } } \ No newline at end of file From 9a03d2dbc9201acf4956476a1927fcef49b604eb Mon Sep 17 00:00:00 2001 From: Alfred Sin Date: Fri, 3 Aug 2018 17:10:10 -0700 Subject: [PATCH 13/29] update operations path spec --- .../preview/2018-07-01-preview/serialconsole.json | 3 --- 1 file changed, 3 deletions(-) diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json index ef3bacbee8f1..7341a317e461 100644 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json @@ -58,9 +58,6 @@ }, { "$ref": "#/parameters/SubscriptionIdParameter" - }, - { - "$ref": "#/parameters/default" } ], "responses": { From d9d5339a6bfebde191995eb59a7196139a10cb9a Mon Sep 17 00:00:00 2001 From: Alfred Sin Date: Mon, 6 Aug 2018 13:54:41 -0700 Subject: [PATCH 14/29] add more examples, some minor changes --- ...e.json => DisableConsoleErrorExample.json} | 5 +--- ...json => DisableConsoleSuccessExample.json} | 4 ++- .../examples/EnableConsoleErrorExample.json | 14 ++++++++++ .../examples/EnableConsoleSuccessExample.json | 14 ++++++++++ .../GetConsoleDisabledErrorExample.json | 14 ++++++++++ ... => GetConsoleDisabledSuccessExample.json} | 4 ++- .../2018-07-01-preview/serialconsole.json | 27 ++++++++++++------- 7 files changed, 67 insertions(+), 15 deletions(-) rename specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/{DisableConsoleExample.json => DisableConsoleErrorExample.json} (63%) rename specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/{EnableConsoleExample.json => DisableConsoleSuccessExample.json} (75%) create mode 100644 specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/EnableConsoleErrorExample.json create mode 100644 specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/EnableConsoleSuccessExample.json create mode 100644 specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetConsoleDisabledErrorExample.json rename specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/{GetConsoleDisabledExample.json => GetConsoleDisabledSuccessExample.json} (75%) diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/DisableConsoleExample.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/DisableConsoleErrorExample.json similarity index 63% rename from specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/DisableConsoleExample.json rename to specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/DisableConsoleErrorExample.json index afc147ade52c..ba2a2c3630c4 100644 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/DisableConsoleExample.json +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/DisableConsoleErrorExample.json @@ -7,10 +7,7 @@ "responses": { "500": { "body": { - "errorMessage": { - "type": "string", - "description": "Details on Failure" - } + "errorMessage": "This message will contain details on failure" } } } diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/EnableConsoleExample.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/DisableConsoleSuccessExample.json similarity index 75% rename from specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/EnableConsoleExample.json rename to specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/DisableConsoleSuccessExample.json index d61e82ce8821..2e4976a8b812 100644 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/EnableConsoleExample.json +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/DisableConsoleSuccessExample.json @@ -6,7 +6,9 @@ }, "responses": { "200": { - "disabled": "false" + "body": { + "disabled": "true" + } } } } \ No newline at end of file diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/EnableConsoleErrorExample.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/EnableConsoleErrorExample.json new file mode 100644 index 000000000000..ba2a2c3630c4 --- /dev/null +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/EnableConsoleErrorExample.json @@ -0,0 +1,14 @@ +{ + "parameters": { + "api-version": "2018-07-01-preview", + "subscriptionId": "00000000-00000-0000-0000-000000000000", + "default": "default" + }, + "responses": { + "500": { + "body": { + "errorMessage": "This message will contain details on failure" + } + } + } +} \ No newline at end of file diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/EnableConsoleSuccessExample.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/EnableConsoleSuccessExample.json new file mode 100644 index 000000000000..aa09166fcd42 --- /dev/null +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/EnableConsoleSuccessExample.json @@ -0,0 +1,14 @@ +{ + "parameters": { + "api-version": "2018-07-01-preview", + "subscriptionId": "00000000-00000-0000-0000-000000000000", + "default": "default" + }, + "responses": { + "200": { + "body": { + "disabled": "false" + } + } + } +} \ No newline at end of file diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetConsoleDisabledErrorExample.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetConsoleDisabledErrorExample.json new file mode 100644 index 000000000000..ba2a2c3630c4 --- /dev/null +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetConsoleDisabledErrorExample.json @@ -0,0 +1,14 @@ +{ + "parameters": { + "api-version": "2018-07-01-preview", + "subscriptionId": "00000000-00000-0000-0000-000000000000", + "default": "default" + }, + "responses": { + "500": { + "body": { + "errorMessage": "This message will contain details on failure" + } + } + } +} \ No newline at end of file diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetConsoleDisabledExample.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetConsoleDisabledSuccessExample.json similarity index 75% rename from specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetConsoleDisabledExample.json rename to specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetConsoleDisabledSuccessExample.json index 9a69de63d54d..2e4976a8b812 100644 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetConsoleDisabledExample.json +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetConsoleDisabledSuccessExample.json @@ -6,7 +6,9 @@ }, "responses": { "200": { - "disabled": "true" + "body": { + "disabled": "true" + } } } } \ No newline at end of file diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json index 7341a317e461..1355206859cd 100644 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json @@ -103,8 +103,11 @@ } }, "x-ms-examples": { - "Get whether or not Serial Console is disabled": { - "$ref": "./examples/GetConsoleDisabledExample.json" + "Successfully get whether or not Serial Console is disabled": { + "$ref": "./examples/GetConsoleDisabledSuccessExample.json" + }, + "Get whether or not Serial Console is disabled and receive error": { + "$ref": "./examples/GetConsoleDisabledErrorExample.json" } } } @@ -114,7 +117,7 @@ "tags": [ "EnableConsole" ], - "operationId": "Console_enableconsole", + "operationId": "Console_EnableConsole", "description": "Enables Serial Console for a VM", "parameters": [ { @@ -143,7 +146,10 @@ }, "x-ms-examples": { "Enable console successfully": { - "$ref": "./examples/EnableConsoleExample.json" + "$ref": "./examples/EnableConsoleSuccessExample.json" + }, + "Enable console with error": { + "$ref": "./examples/EnableConsoleErrorExample.json" } } } @@ -153,7 +159,7 @@ "tags": [ "DisableConsole" ], - "operationId": "Console_disableconsole", + "operationId": "Console_DisableConsole", "description": "Disables Serial Console for a VM", "parameters": [ { @@ -181,8 +187,11 @@ } }, "x-ms-examples": { - "Attempt to disable console and receive a 500 error": { - "$ref": "./examples/DisableConsoleExample.json" + "Enable console successfully": { + "$ref": "./examples/DisableConsoleSuccessExample.json" + }, + "Disable console with error": { + "$ref": "./examples/DisableConsoleErrorExample.json" } } } @@ -201,7 +210,7 @@ }, "GetDisabledResult": { "title": "Get Disabled result", - "description": "Returns whether or not Serial Console is disabled for ths given subscription", + "description": "Returns whether or not Serial Console is disabled for this given subscription", "properties": { "disabled": { "description": "Disabled result", @@ -211,7 +220,7 @@ }, "SetDisabledResult": { "title": "Set Disabled result", - "description": "Sets disable status and returns whether or not Serial Console is now disabled for ths given subscription", + "description": "Sets disable status and returns whether or not Serial Console is now disabled for this given subscription", "properties": { "disabled": { "description": "Disabled result", From abab53072ec55746d291100442222e36854d6b5c Mon Sep 17 00:00:00 2001 From: Alfred Sin Date: Mon, 6 Aug 2018 15:05:49 -0700 Subject: [PATCH 15/29] update x-ms-parameter-location --- .../preview/2018-07-01-preview/serialconsole.json | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json index 1355206859cd..d01a7db2d3b3 100644 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json @@ -274,8 +274,7 @@ "enum": [ "default" ], - "x-ms-parameter-location": "client" + "x-ms-parameter-location": "method" } - } } \ No newline at end of file From fd9b01a3f3e175c66479dbb6c29c2501526f1ed7 Mon Sep 17 00:00:00 2001 From: Alfred Sin Date: Tue, 7 Aug 2018 14:03:04 -0700 Subject: [PATCH 16/29] trivial modification to error message to kickstart a new build process --- .../examples/GetConsoleDisabledErrorExample.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetConsoleDisabledErrorExample.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetConsoleDisabledErrorExample.json index ba2a2c3630c4..d49f411c6628 100644 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetConsoleDisabledErrorExample.json +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetConsoleDisabledErrorExample.json @@ -7,7 +7,7 @@ "responses": { "500": { "body": { - "errorMessage": "This message will contain details on failure" + "errorMessage": "This message contains details on failure" } } } From 3f1e833b0e268becbee73bca163ebaf15f06b89d Mon Sep 17 00:00:00 2001 From: Alfred Sin Date: Wed, 8 Aug 2018 13:32:58 -0700 Subject: [PATCH 17/29] example updates --- .../examples/DisableConsoleErrorExample.json | 2 +- .../examples/EnableConsoleErrorExample.json | 2 +- .../examples/EnableConsoleSuccessExample.json | 2 +- .../examples/GetConsoleDisabledErrorExample.json | 2 +- .../examples/GetConsoleDisabledSuccessExample.json | 2 +- .../2018-07-01-preview/examples/GetOperationsExample.json | 4 +++- 6 files changed, 8 insertions(+), 6 deletions(-) diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/DisableConsoleErrorExample.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/DisableConsoleErrorExample.json index ba2a2c3630c4..758ee7306e8d 100644 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/DisableConsoleErrorExample.json +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/DisableConsoleErrorExample.json @@ -5,7 +5,7 @@ "default": "default" }, "responses": { - "500": { + "default": { "body": { "errorMessage": "This message will contain details on failure" } diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/EnableConsoleErrorExample.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/EnableConsoleErrorExample.json index ba2a2c3630c4..758ee7306e8d 100644 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/EnableConsoleErrorExample.json +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/EnableConsoleErrorExample.json @@ -5,7 +5,7 @@ "default": "default" }, "responses": { - "500": { + "default": { "body": { "errorMessage": "This message will contain details on failure" } diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/EnableConsoleSuccessExample.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/EnableConsoleSuccessExample.json index aa09166fcd42..741565130f66 100644 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/EnableConsoleSuccessExample.json +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/EnableConsoleSuccessExample.json @@ -7,7 +7,7 @@ "responses": { "200": { "body": { - "disabled": "false" + "disabled": false } } } diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetConsoleDisabledErrorExample.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetConsoleDisabledErrorExample.json index d49f411c6628..b40545fd5e53 100644 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetConsoleDisabledErrorExample.json +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetConsoleDisabledErrorExample.json @@ -5,7 +5,7 @@ "default": "default" }, "responses": { - "500": { + "default": { "body": { "errorMessage": "This message contains details on failure" } diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetConsoleDisabledSuccessExample.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetConsoleDisabledSuccessExample.json index 2e4976a8b812..2039ae1de8d9 100644 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetConsoleDisabledSuccessExample.json +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetConsoleDisabledSuccessExample.json @@ -7,7 +7,7 @@ "responses": { "200": { "body": { - "disabled": "true" + "disabled": true } } } diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetOperationsExample.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetOperationsExample.json index 256c72d84392..e8f6c9b69250 100644 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetOperationsExample.json +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetOperationsExample.json @@ -5,7 +5,9 @@ }, "responses": { "200": { - "value": "Get operations response" + "body": { + "value": "Get operations response" + } } } } \ No newline at end of file From 3bb04821583b8f1f6d65297f6e073f120f040104 Mon Sep 17 00:00:00 2001 From: Alfred Sin Date: Wed, 8 Aug 2018 13:33:45 -0700 Subject: [PATCH 18/29] update example again --- .../examples/DisableConsoleSuccessExample.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/DisableConsoleSuccessExample.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/DisableConsoleSuccessExample.json index 2e4976a8b812..2039ae1de8d9 100644 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/DisableConsoleSuccessExample.json +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/DisableConsoleSuccessExample.json @@ -7,7 +7,7 @@ "responses": { "200": { "body": { - "disabled": "true" + "disabled": true } } } From d5f34af083d004d0b46d3341cb169fda0f67e1f9 Mon Sep 17 00:00:00 2001 From: Alfred Sin Date: Thu, 9 Aug 2018 11:14:49 -0700 Subject: [PATCH 19/29] update api version --- .../2018-05-01}/examples/DisableConsoleErrorExample.json | 2 +- .../2018-05-01}/examples/DisableConsoleSuccessExample.json | 2 +- .../2018-05-01}/examples/EnableConsoleErrorExample.json | 2 +- .../2018-05-01}/examples/EnableConsoleSuccessExample.json | 2 +- .../2018-05-01}/examples/GetConsoleDisabledErrorExample.json | 2 +- .../2018-05-01}/examples/GetConsoleDisabledSuccessExample.json | 2 +- .../2018-05-01}/examples/GetOperationsExample.json | 2 +- .../2018-07-01-preview => stable/2018-05-01}/serialconsole.json | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) rename specification/serialconsole/resource-manager/Microsoft.SerialConsole/{preview/2018-07-01-preview => stable/2018-05-01}/examples/DisableConsoleErrorExample.json (86%) rename specification/serialconsole/resource-manager/Microsoft.SerialConsole/{preview/2018-07-01-preview => stable/2018-05-01}/examples/DisableConsoleSuccessExample.json (84%) rename specification/serialconsole/resource-manager/Microsoft.SerialConsole/{preview/2018-07-01-preview => stable/2018-05-01}/examples/EnableConsoleErrorExample.json (86%) rename specification/serialconsole/resource-manager/Microsoft.SerialConsole/{preview/2018-07-01-preview => stable/2018-05-01}/examples/EnableConsoleSuccessExample.json (84%) rename specification/serialconsole/resource-manager/Microsoft.SerialConsole/{preview/2018-07-01-preview => stable/2018-05-01}/examples/GetConsoleDisabledErrorExample.json (86%) rename specification/serialconsole/resource-manager/Microsoft.SerialConsole/{preview/2018-07-01-preview => stable/2018-05-01}/examples/GetConsoleDisabledSuccessExample.json (84%) rename specification/serialconsole/resource-manager/Microsoft.SerialConsole/{preview/2018-07-01-preview => stable/2018-05-01}/examples/GetOperationsExample.json (83%) rename specification/serialconsole/resource-manager/Microsoft.SerialConsole/{preview/2018-07-01-preview => stable/2018-05-01}/serialconsole.json (99%) diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/DisableConsoleErrorExample.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/DisableConsoleErrorExample.json similarity index 86% rename from specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/DisableConsoleErrorExample.json rename to specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/DisableConsoleErrorExample.json index 758ee7306e8d..73abe9c8da8c 100644 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/DisableConsoleErrorExample.json +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/DisableConsoleErrorExample.json @@ -1,6 +1,6 @@ { "parameters": { - "api-version": "2018-07-01-preview", + "api-version": "2018-05-01", "subscriptionId": "00000000-00000-0000-0000-000000000000", "default": "default" }, diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/DisableConsoleSuccessExample.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/DisableConsoleSuccessExample.json similarity index 84% rename from specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/DisableConsoleSuccessExample.json rename to specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/DisableConsoleSuccessExample.json index 2039ae1de8d9..eb9dfbab6282 100644 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/DisableConsoleSuccessExample.json +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/DisableConsoleSuccessExample.json @@ -1,6 +1,6 @@ { "parameters": { - "api-version": "2018-07-01-preview", + "api-version": "2018-05-01", "subscriptionId": "00000000-00000-0000-0000-000000000000", "default": "default" }, diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/EnableConsoleErrorExample.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/EnableConsoleErrorExample.json similarity index 86% rename from specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/EnableConsoleErrorExample.json rename to specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/EnableConsoleErrorExample.json index 758ee7306e8d..73abe9c8da8c 100644 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/EnableConsoleErrorExample.json +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/EnableConsoleErrorExample.json @@ -1,6 +1,6 @@ { "parameters": { - "api-version": "2018-07-01-preview", + "api-version": "2018-05-01", "subscriptionId": "00000000-00000-0000-0000-000000000000", "default": "default" }, diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/EnableConsoleSuccessExample.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/EnableConsoleSuccessExample.json similarity index 84% rename from specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/EnableConsoleSuccessExample.json rename to specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/EnableConsoleSuccessExample.json index 741565130f66..7c854e1f2215 100644 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/EnableConsoleSuccessExample.json +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/EnableConsoleSuccessExample.json @@ -1,6 +1,6 @@ { "parameters": { - "api-version": "2018-07-01-preview", + "api-version": "2018-05-01", "subscriptionId": "00000000-00000-0000-0000-000000000000", "default": "default" }, diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetConsoleDisabledErrorExample.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/GetConsoleDisabledErrorExample.json similarity index 86% rename from specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetConsoleDisabledErrorExample.json rename to specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/GetConsoleDisabledErrorExample.json index b40545fd5e53..4dff443ddf9b 100644 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetConsoleDisabledErrorExample.json +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/GetConsoleDisabledErrorExample.json @@ -1,6 +1,6 @@ { "parameters": { - "api-version": "2018-07-01-preview", + "api-version": "2018-05-01", "subscriptionId": "00000000-00000-0000-0000-000000000000", "default": "default" }, diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetConsoleDisabledSuccessExample.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/GetConsoleDisabledSuccessExample.json similarity index 84% rename from specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetConsoleDisabledSuccessExample.json rename to specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/GetConsoleDisabledSuccessExample.json index 2039ae1de8d9..eb9dfbab6282 100644 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetConsoleDisabledSuccessExample.json +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/GetConsoleDisabledSuccessExample.json @@ -1,6 +1,6 @@ { "parameters": { - "api-version": "2018-07-01-preview", + "api-version": "2018-05-01", "subscriptionId": "00000000-00000-0000-0000-000000000000", "default": "default" }, diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetOperationsExample.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/GetOperationsExample.json similarity index 83% rename from specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetOperationsExample.json rename to specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/GetOperationsExample.json index e8f6c9b69250..f36e22c435ad 100644 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/examples/GetOperationsExample.json +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/GetOperationsExample.json @@ -1,6 +1,6 @@ { "parameters": { - "api-version": "2018-07-01-preview", + "api-version": "2018-05-01", "subscriptionId": "00000000-00000-0000-0000-000000000000" }, "responses": { diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/serialconsole.json similarity index 99% rename from specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json rename to specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/serialconsole.json index d01a7db2d3b3..bd5a6df715f6 100644 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/serialconsole.json @@ -2,7 +2,7 @@ "swagger": "2.0", "info": { "title": "MicrosoftSerialConsoleClient", - "version": "2018-07-01-preview", + "version": "2018-05-01", "description": "Azure Virtual Machine Serial Console allows you to access serial console of a Virtual Machine" }, "host": "management.azure.com", From 814350e75f4abf0334619a05949b9f6f2e99b64a Mon Sep 17 00:00:00 2001 From: Alfred Sin Date: Thu, 9 Aug 2018 13:15:51 -0700 Subject: [PATCH 20/29] modify api version reference --- profiles/ResourceSchemas.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/profiles/ResourceSchemas.md b/profiles/ResourceSchemas.md index 823dad5137ce..eba0a06a8194 100644 --- a/profiles/ResourceSchemas.md +++ b/profiles/ResourceSchemas.md @@ -243,7 +243,7 @@ batch: - ../specification/scheduler/resource-manager/Microsoft.Scheduler/2016-03-01/scheduler.json - ../specification/search/resource-manager/Microsoft.Search/2015-02-28/search.json - ../specification/search/resource-manager/Microsoft.Search/2015-08-19/search.json - - ../specification/serialconsole/resource-manager/Microsoft.SerialConsole/2018-07-01-preview/serialconsole.json + - ../specification/serialconsole/resource-manager/Microsoft.SerialConsole/2018-05-01/serialconsole.json - ../specification/servermanagement/resource-manager/Microsoft.ServerManagement/2015-07-01-preview/servermanagement.json - ../specification/servermanagement/resource-manager/Microsoft.ServerManagement/2016-07-01-preview/servermanagement.json - ../specification/service-map/resource-manager/Microsoft.OperationalInsights/2015-11-01-preview/arm-service-map.json From 259ba89c6514460da981a534ace375609280fad4 Mon Sep 17 00:00:00 2001 From: Alfred Sin Date: Thu, 9 Aug 2018 13:17:22 -0700 Subject: [PATCH 21/29] one more api version reference --- specification/serialconsole/resource-manager/readme.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/serialconsole/resource-manager/readme.md b/specification/serialconsole/resource-manager/readme.md index 7cb3e2c3cde8..9d5ef1149108 100644 --- a/specification/serialconsole/resource-manager/readme.md +++ b/specification/serialconsole/resource-manager/readme.md @@ -24,7 +24,7 @@ openapi-type: arm azure-arm: true tag: package-2018-07 input-file: -- Microsoft.SerialConsole/preview/2018-07-01-preview/serialconsole.json +- Microsoft.SerialConsole/preview/2018-05-01/serialconsole.json output-folder: ./Generated ``` From 502fd9096c3813734b8dc830a11b3f8afe1494db Mon Sep 17 00:00:00 2001 From: Alfred Sin Date: Thu, 9 Aug 2018 13:17:59 -0700 Subject: [PATCH 22/29] (hopefully) final api version reference update --- specification/serialconsole/resource-manager/readme.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/serialconsole/resource-manager/readme.md b/specification/serialconsole/resource-manager/readme.md index 9d5ef1149108..8da13a898a7c 100644 --- a/specification/serialconsole/resource-manager/readme.md +++ b/specification/serialconsole/resource-manager/readme.md @@ -22,7 +22,7 @@ These are the global settings for the Serial Console API. ``` yaml openapi-type: arm azure-arm: true -tag: package-2018-07 +tag: package-2018-05 input-file: - Microsoft.SerialConsole/preview/2018-05-01/serialconsole.json output-folder: ./Generated From 7e88b0378294de4596a310226150c5fc0dd34adc Mon Sep 17 00:00:00 2001 From: Alfred Sin Date: Fri, 10 Aug 2018 10:47:06 -0700 Subject: [PATCH 23/29] update examples and codeowners --- CODEOWNERS | 5 +++-- ...rorExample.json => DisableConsoleExamples.json} | 5 +++++ .../examples/DisableConsoleSuccessExample.json | 14 -------------- ...rrorExample.json => EnableConsoleExamples.json} | 5 +++++ .../examples/EnableConsoleSuccessExample.json | 14 -------------- ...xample.json => GetConsoleDisabledExamples.json} | 5 +++++ .../examples/GetConsoleDisabledSuccessExample.json | 14 -------------- .../stable/2018-05-01/serialconsole.json | 12 ++++++------ .../serialconsole/resource-manager/readme.md | 2 +- 9 files changed, 25 insertions(+), 51 deletions(-) rename specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/{DisableConsoleErrorExample.json => DisableConsoleExamples.json} (77%) delete mode 100644 specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/DisableConsoleSuccessExample.json rename specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/{EnableConsoleErrorExample.json => EnableConsoleExamples.json} (77%) delete mode 100644 specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/EnableConsoleSuccessExample.json rename specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/{GetConsoleDisabledErrorExample.json => GetConsoleDisabledExamples.json} (77%) delete mode 100644 specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/GetConsoleDisabledSuccessExample.json diff --git a/CODEOWNERS b/CODEOWNERS index 83fb557ed364..87c1603d08a1 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -10,7 +10,7 @@ /specification/billing/ @wilcobmsft /specification/cdn/ @csmengwan @injyzarif @prakharsharma10 /specification/cognitiveservices/ @davidlicig @felixwa @yangyuan -/specification/compute/ @huangpf @hyonholee +/specification/compute/ @huangpf @hyonholee /specification/consumption/ @kjeur @panda-wang /specification/containerinstance/ @samkreter /specification/containerregistry/ @djyou @@ -43,7 +43,7 @@ /specification/mobileengagement/ @pshrosbree /specification/monitor/ @gucalder /specification/mysql/ @qingqingyuan -/specification/network/ @deepakrajendranmsft @MikhailTryakhov +/specification/network/ @deepakrajendranmsft @MikhailTryakhov /specification/notificationhubs/ @amolr @smithab /specification/operationalinsights/ @sw47 /specification/operationsmanagement/ @dashimi16 @@ -58,6 +58,7 @@ /specification/resources/ @rajshah11 @stankovski @vivsriaus /specification/scheduler/ @pinwang81 /specification/search/ @brjohnstmsft +/specification/serialconsole/ @amitchat @craigw @asinn826 /specification/service-map/ @daveirwin1 /specification/servicebus/ @sazeesha @v-ajnava /specification/servicefabric/ @juhacket @samedder diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/DisableConsoleErrorExample.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/DisableConsoleExamples.json similarity index 77% rename from specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/DisableConsoleErrorExample.json rename to specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/DisableConsoleExamples.json index 73abe9c8da8c..062479774669 100644 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/DisableConsoleErrorExample.json +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/DisableConsoleExamples.json @@ -5,6 +5,11 @@ "default": "default" }, "responses": { + "200": { + "body": { + "disabled": true + } + }, "default": { "body": { "errorMessage": "This message will contain details on failure" diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/DisableConsoleSuccessExample.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/DisableConsoleSuccessExample.json deleted file mode 100644 index eb9dfbab6282..000000000000 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/DisableConsoleSuccessExample.json +++ /dev/null @@ -1,14 +0,0 @@ -{ - "parameters": { - "api-version": "2018-05-01", - "subscriptionId": "00000000-00000-0000-0000-000000000000", - "default": "default" - }, - "responses": { - "200": { - "body": { - "disabled": true - } - } - } -} \ No newline at end of file diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/EnableConsoleErrorExample.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/EnableConsoleExamples.json similarity index 77% rename from specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/EnableConsoleErrorExample.json rename to specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/EnableConsoleExamples.json index 73abe9c8da8c..05ca5ee88f45 100644 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/EnableConsoleErrorExample.json +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/EnableConsoleExamples.json @@ -5,6 +5,11 @@ "default": "default" }, "responses": { + "200": { + "body": { + "disabled": false + } + }, "default": { "body": { "errorMessage": "This message will contain details on failure" diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/EnableConsoleSuccessExample.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/EnableConsoleSuccessExample.json deleted file mode 100644 index 7c854e1f2215..000000000000 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/EnableConsoleSuccessExample.json +++ /dev/null @@ -1,14 +0,0 @@ -{ - "parameters": { - "api-version": "2018-05-01", - "subscriptionId": "00000000-00000-0000-0000-000000000000", - "default": "default" - }, - "responses": { - "200": { - "body": { - "disabled": false - } - } - } -} \ No newline at end of file diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/GetConsoleDisabledErrorExample.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/GetConsoleDisabledExamples.json similarity index 77% rename from specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/GetConsoleDisabledErrorExample.json rename to specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/GetConsoleDisabledExamples.json index 4dff443ddf9b..970c46eeb354 100644 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/GetConsoleDisabledErrorExample.json +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/GetConsoleDisabledExamples.json @@ -5,6 +5,11 @@ "default": "default" }, "responses": { + "200": { + "body": { + "disabled": true + } + }, "default": { "body": { "errorMessage": "This message contains details on failure" diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/GetConsoleDisabledSuccessExample.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/GetConsoleDisabledSuccessExample.json deleted file mode 100644 index eb9dfbab6282..000000000000 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/GetConsoleDisabledSuccessExample.json +++ /dev/null @@ -1,14 +0,0 @@ -{ - "parameters": { - "api-version": "2018-05-01", - "subscriptionId": "00000000-00000-0000-0000-000000000000", - "default": "default" - }, - "responses": { - "200": { - "body": { - "disabled": true - } - } - } -} \ No newline at end of file diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/serialconsole.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/serialconsole.json index bd5a6df715f6..d38015475c13 100644 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/serialconsole.json +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/serialconsole.json @@ -104,10 +104,10 @@ }, "x-ms-examples": { "Successfully get whether or not Serial Console is disabled": { - "$ref": "./examples/GetConsoleDisabledSuccessExample.json" + "$ref": "./examples/GetConsoleDisabledExamples.json" }, "Get whether or not Serial Console is disabled and receive error": { - "$ref": "./examples/GetConsoleDisabledErrorExample.json" + "$ref": "./examples/GetConsoleDisabledExamples.json" } } } @@ -146,10 +146,10 @@ }, "x-ms-examples": { "Enable console successfully": { - "$ref": "./examples/EnableConsoleSuccessExample.json" + "$ref": "./examples/EnableConsoleExamples.json" }, "Enable console with error": { - "$ref": "./examples/EnableConsoleErrorExample.json" + "$ref": "./examples/EnableConsoleExamples.json" } } } @@ -188,10 +188,10 @@ }, "x-ms-examples": { "Enable console successfully": { - "$ref": "./examples/DisableConsoleSuccessExample.json" + "$ref": "./examples/DisableConsoleExamples.json" }, "Disable console with error": { - "$ref": "./examples/DisableConsoleErrorExample.json" + "$ref": "./examples/DisableConsoleExamples.json" } } } diff --git a/specification/serialconsole/resource-manager/readme.md b/specification/serialconsole/resource-manager/readme.md index 8da13a898a7c..97ba0ee214f5 100644 --- a/specification/serialconsole/resource-manager/readme.md +++ b/specification/serialconsole/resource-manager/readme.md @@ -24,7 +24,7 @@ openapi-type: arm azure-arm: true tag: package-2018-05 input-file: -- Microsoft.SerialConsole/preview/2018-05-01/serialconsole.json +- Microsoft.SerialConsole/stable/2018-05-01/serialconsole.json output-folder: ./Generated ``` From 96b2219f1bbff888ff08bacc1ba90b063360f7b0 Mon Sep 17 00:00:00 2001 From: Alfred Sin Date: Fri, 10 Aug 2018 14:00:27 -0700 Subject: [PATCH 24/29] trivial change to kickstart build again --- .../stable/2018-05-01/examples/DisableConsoleExamples.json | 2 +- .../stable/2018-05-01/examples/EnableConsoleExamples.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/DisableConsoleExamples.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/DisableConsoleExamples.json index 062479774669..970c46eeb354 100644 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/DisableConsoleExamples.json +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/DisableConsoleExamples.json @@ -12,7 +12,7 @@ }, "default": { "body": { - "errorMessage": "This message will contain details on failure" + "errorMessage": "This message contains details on failure" } } } diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/EnableConsoleExamples.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/EnableConsoleExamples.json index 05ca5ee88f45..29253e530f73 100644 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/EnableConsoleExamples.json +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/EnableConsoleExamples.json @@ -12,7 +12,7 @@ }, "default": { "body": { - "errorMessage": "This message will contain details on failure" + "errorMessage": "This message contains details on failure" } } } From 22f537f3798a7f0dfb43f589911d973a0fb8135c Mon Sep 17 00:00:00 2001 From: Alfred Sin Date: Sat, 11 Aug 2018 14:34:42 -0700 Subject: [PATCH 25/29] add python --- .../serialconsole/resource-manager/readme.md | 12 ++++++++- .../resource-manager/readme.python.md | 27 +++++++++++++++++++ 2 files changed, 38 insertions(+), 1 deletion(-) create mode 100644 specification/serialconsole/resource-manager/readme.python.md diff --git a/specification/serialconsole/resource-manager/readme.md b/specification/serialconsole/resource-manager/readme.md index 97ba0ee214f5..862338399d21 100644 --- a/specification/serialconsole/resource-manager/readme.md +++ b/specification/serialconsole/resource-manager/readme.md @@ -41,4 +41,14 @@ csharp: azure-arm: true output-folder: ./Generated clear-output-folder: true -``` \ No newline at end of file +``` + +## Swagger to SDK + +This section describes what SDK should be generated by the automatic system. +This is not used by Autorest itself. + +``` yaml $(swagger-to-sdk) +swagger-to-sdk: + - repo: azure-sdk-for-python +``` diff --git a/specification/serialconsole/resource-manager/readme.python.md b/specification/serialconsole/resource-manager/readme.python.md new file mode 100644 index 000000000000..9b944e408033 --- /dev/null +++ b/specification/serialconsole/resource-manager/readme.python.md @@ -0,0 +1,27 @@ +## Python + +These settings apply only when `--python` is specified on the command line. +Please also specify `--python-sdks-folder=`. +Use `--python-mode=update` if you already have a setup.py and just want to update the code itself. + +``` yaml $(python) +python-mode: create +python: + azure-arm: true + license-header: MICROSOFT_MIT_NO_VERSION + payload-flattening-threshold: 2 + namespace: azure.mgmt.serialconsole + package-name: azure-mgmt-serialconsole + package-version: 0.1.0 + clear-output-folder: true +``` +``` yaml $(python) && $(python-mode) == 'update' +python: + no-namespace-folders: true + output-folder: $(python-sdks-folder)/azure-mgmt-serialconsole/azure/mgmt/serialconsole +``` +``` yaml $(python) && $(python-mode) == 'create' +python: + basic-setup-py: true + output-folder: $(python-sdks-folder)/azure-mgmt-serialconsole +``` \ No newline at end of file From 50a3e140a35e4a132b651fc29c5c5552108ef169 Mon Sep 17 00:00:00 2001 From: Alfred Sin Date: Sat, 11 Aug 2018 15:02:00 -0700 Subject: [PATCH 26/29] trivial change to kickstart build again --- .../stable/2018-05-01/examples/DisableConsoleExamples.json | 2 +- .../stable/2018-05-01/examples/EnableConsoleExamples.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/DisableConsoleExamples.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/DisableConsoleExamples.json index 970c46eeb354..062479774669 100644 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/DisableConsoleExamples.json +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/DisableConsoleExamples.json @@ -12,7 +12,7 @@ }, "default": { "body": { - "errorMessage": "This message contains details on failure" + "errorMessage": "This message will contain details on failure" } } } diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/EnableConsoleExamples.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/EnableConsoleExamples.json index 29253e530f73..05ca5ee88f45 100644 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/EnableConsoleExamples.json +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/EnableConsoleExamples.json @@ -12,7 +12,7 @@ }, "default": { "body": { - "errorMessage": "This message contains details on failure" + "errorMessage": "This message will contain details on failure" } } } From 2c3686d9eb995148d3d6698595972455b509a6a6 Mon Sep 17 00:00:00 2001 From: Sergey Shandar Date: Mon, 13 Aug 2018 11:39:35 -0700 Subject: [PATCH 27/29] Update CODEOWNERS --- CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CODEOWNERS b/CODEOWNERS index 87c1603d08a1..04bcf82070f1 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -43,7 +43,7 @@ /specification/mobileengagement/ @pshrosbree /specification/monitor/ @gucalder /specification/mysql/ @qingqingyuan -/specification/network/ @deepakrajendranmsft @MikhailTryakhov +/specification/network/ @MikhailTryakhov /specification/notificationhubs/ @amolr @smithab /specification/operationalinsights/ @sw47 /specification/operationsmanagement/ @dashimi16 From 90ad5519ed203885cb03736241b5b0955a653de1 Mon Sep 17 00:00:00 2001 From: Alfred Sin Date: Wed, 12 Sep 2018 10:27:09 -0700 Subject: [PATCH 28/29] clarify the subscription-level disable --- .../stable/2018-05-01/serialconsole.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/serialconsole.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/serialconsole.json index d38015475c13..b1e7e266b3cd 100644 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/serialconsole.json +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/serialconsole.json @@ -118,7 +118,7 @@ "EnableConsole" ], "operationId": "Console_EnableConsole", - "description": "Enables Serial Console for a VM", + "description": "Enables Serial Console for a subscription", "parameters": [ { "$ref": "#/parameters/ApiVersionParameter" @@ -160,7 +160,7 @@ "DisableConsole" ], "operationId": "Console_DisableConsole", - "description": "Disables Serial Console for a VM", + "description": "Disables Serial Console for a subscription", "parameters": [ { "$ref": "#/parameters/ApiVersionParameter" From ddf58c37505bdf0964a5d9260bffbe8824dd78eb Mon Sep 17 00:00:00 2001 From: Alfred Sin Date: Wed, 12 Sep 2018 10:48:29 -0700 Subject: [PATCH 29/29] fix incorrect url --- .../stable/2018-05-01/serialconsole.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/serialconsole.json b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/serialconsole.json index b1e7e266b3cd..818186ba1c6b 100644 --- a/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/serialconsole.json +++ b/specification/serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/serialconsole.json @@ -112,7 +112,7 @@ } } }, - "/subscriptions/{subscriptionId}/providers/Microsoft.SerialConsole/providers/consoleServices/{default}/enableConsole": { + "/subscriptions/{subscriptionId}/providers/Microsoft.SerialConsole/consoleServices/{default}/enableConsole": { "post": { "tags": [ "EnableConsole" @@ -154,7 +154,7 @@ } } }, - "/subscriptions/{subscriptionId}/providers/Microsoft.SerialConsole/providers/consoleServices/{default}/disableConsole": { + "/subscriptions/{subscriptionId}/providers/Microsoft.SerialConsole/consoleServices/{default}/disableConsole": { "post": { "tags": [ "DisableConsole"