From e815231448dfd9aab741af96038603327fd7d1be Mon Sep 17 00:00:00 2001 From: Shane Baden Date: Fri, 13 Mar 2020 00:41:06 -0700 Subject: [PATCH 01/19] Adding privateEndpoint child resource privateDNSZoneGroup, as well as adding customDNSconfig JSONto privateendpoint --- .../examples/PrivateEndpointCreate.json | 32 +- ...rivateEndpointCreateForManualApproval.json | 32 +- .../PrivateEndpointDnsZoneGroupCreate.json | 90 +++++ .../PrivateEndpointDnsZoneGroupDelete.json | 14 + .../PrivateEndpointDnsZoneGroupGet.json | 69 ++++ .../examples/PrivateEndpointGet.json | 16 +- .../PrivateEndpointGetForManualApproval.json | 16 +- .../examples/PrivateEndpointList.json | 32 +- .../examples/PrivateEndpointListAll.json | 48 ++- .../stable/2020-03-01/privateEndpoint.json | 331 ++++++++++++++++++ 10 files changed, 669 insertions(+), 11 deletions(-) create mode 100644 specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointDnsZoneGroupCreate.json create mode 100644 specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointDnsZoneGroupDelete.json create mode 100644 specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointDnsZoneGroupGet.json diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointCreate.json b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointCreate.json index 9a9dc3c07535..a61989b2e628 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointCreate.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointCreate.json @@ -56,7 +56,21 @@ { "id": "/subscriptions/subId/resourceGroups/rg1/provders/Microsoft.Network/networkInterfaces/testPe.nic.abcd1234" } - ] + ], + "customDnsConfigs": [ + { + "fqdn": "abc.cosmos.com", + "ipAddresses": [ + "192.168.0.4" + ] + }, + { + "fqdn": "abc2.cosmos.com", + "ipAddresses": [ + "192.168.0.5" + ] + } + ] } } }, @@ -90,7 +104,21 @@ { "id": "/subscriptions/subId/resourceGroups/rg1/provders/Microsoft.Network/networkInterfaces/testPe.nic.abcd1234" } - ] + ], + "customDnsConfigs": [ + { + "fqdn": "abc.cosmos.com", + "ipAddresses": [ + "192.168.0.4" + ] + }, + { + "fqdn": "abc2.cosmos.com", + "ipAddresses": [ + "192.168.0.5" + ] + } + ] } } } diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointCreateForManualApproval.json b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointCreateForManualApproval.json index 657c36ad6b80..d74e7b6d08fc 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointCreateForManualApproval.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointCreateForManualApproval.json @@ -56,7 +56,21 @@ { "id": "/subscriptions/subId/resourceGroups/rg1/provders/Microsoft.Network/networkInterfaces/testPe.nic.abcd1234" } - ] + ], + "customDnsConfigs": [ + { + "fqdn": "abc.cosmos.com", + "ipAddresses": [ + "192.168.0.4" + ] + }, + { + "fqdn": "abc2.cosmos.com", + "ipAddresses": [ + "192.168.0.5" + ] + } + ] } } }, @@ -90,7 +104,21 @@ { "id": "/subscriptions/subId/resourceGroups/rg1/provders/Microsoft.Network/networkInterfaces/testPe.nic.abcd1234" } - ] + ], + "customDnsConfigs": [ + { + "fqdn": "abc.cosmos.com", + "ipAddresses": [ + "192.168.0.4" + ] + }, + { + "fqdn": "abc2.cosmos.com", + "ipAddresses": [ + "192.168.0.5" + ] + } + ] } } } diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointDnsZoneGroupCreate.json b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointDnsZoneGroupCreate.json new file mode 100644 index 000000000000..a9ce0be7a673 --- /dev/null +++ b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointDnsZoneGroupCreate.json @@ -0,0 +1,90 @@ +{ + "parameters": { + "api-version": "2020-03-01", + "subscriptionId": "subId", + "resourceGroupName": "rg1", + "privateEndpointName": "testPe", + "privateDnsZoneGroupName": "testPdns", + "parameters": { + "properties": { + "privateDnsZoneConfigs": [ + { + "properties": { + "privateDnsZoneId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/privateDnsZones/zone1.com" + } + } + ] + } + } + }, + "responses": { + "200": { + "body": { + "name": "testPdns", + "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/privateLinkServices/testPe/privateDnsZoneGroups/testPdnsgroup", + "properties": { + "provisioningState": "Succeeded", + "privateDnsZoneConfigs": [ + { + "properties": { + "privateDnsZoneId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/privateDnsZones/zone1.com", + "recordSets": [ + { + "recordType": "A", + "recordSetName": "abc", + "fqdn": "abc.zone1.com", + "ipAddresses": [ + "10.0.0.4" + ] + }, + { + "recordType": "A", + "recordSetName": "abc2", + "fqdn": "abc2.zone1.com", + "ipAddresses": [ + "10.0.0.5" + ] + } + ] + } + } + ] + } + } + }, + "201": { + "body": { + "name": "testPdns", + "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/privateLinkServices/testPe/privateDnsZoneGroups/testPdnsgroup", + "properties": { + "provisioningState": "Succeeded", + "privateDnsZoneConfigs": [ + { + "properties": { + "privateDnsZoneId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/privateDnsZones/zone1.com", + "recordSets": [ + { + "recordType": "A", + "recordSetName": "abc", + "fqdn": "abc.zone1.com", + "ipAddresses": [ + "10.0.0.4" + ] + }, + { + "recordType": "A", + "recordSetName": "abc2", + "fqdn": "abc2.zone1.com", + "ipAddresses": [ + "10.0.0.5" + ] + } + ] + } + } + ] + } + } + } + } +} diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointDnsZoneGroupDelete.json b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointDnsZoneGroupDelete.json new file mode 100644 index 000000000000..dfc949c5e2b4 --- /dev/null +++ b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointDnsZoneGroupDelete.json @@ -0,0 +1,14 @@ +{ + "parameters": { + "api-version": "2020-03-01", + "subscriptionId": "subId", + "resourceGroupName": "rg1", + "privateEndpointName": "testPe", + "privateDnsZoneGroupName": "testPdnsgroup" + }, + "responses": { + "200": {}, + "202": {}, + "204": {} + } +} diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointDnsZoneGroupGet.json b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointDnsZoneGroupGet.json new file mode 100644 index 000000000000..b535d8956fbd --- /dev/null +++ b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointDnsZoneGroupGet.json @@ -0,0 +1,69 @@ +{ + "parameters": { + "api-version": "2020-03-01", + "subscriptionId": "subId", + "resourceGroupName": "rg1", + "privateEndpointName": "testPe", + "privateDnsZoneGroupName": "testPdnsgroup" + }, + "responses": { + "200": { + "body": { + "name": "testPdnsgroup", + "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/privateLinkServices/testPe/privateDnsZoneGroups/testPdnsgroup", + "type": "Microsoft.Network/privateEndpoints/privateDnsZoneGroups", + "properties": { + "provisioningState": "Succeeded", + "privateDnsZoneConfigs": [ + { + "properties": { + "privateDnsZoneId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/privateDnsZones/zone1.com", + "recordSets": [ + { + "recordType": "A", + "recordSetName": "abc", + "fqdn": "abc.zone1.com", + "ipAddresses": [ + "10.0.0.4" + ] + }, + { + "recordType": "A", + "recordSetName": "abc2", + "fqdn": "abc2.zone1.com", + "ipAddresses": [ + "10.0.0.5" + ] + } + ] + } + }, + { + "properties": { + "privateDnsZoneId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/privateDnsZones/zone2.com", + "recordSets": [ + { + "recordType": "A", + "recordSetName": "abc", + "fqdn": "abc.zone2.com", + "ipAddresses": [ + "10.0.0.6" + ] + }, + { + "recordType": "A", + "recordSetName": "abc2", + "fqdn": "abc2.zone2.com", + "ipAddresses": [ + "10.0.0.7" + ] + } + ] + } + } + ] + } + } + } + } +} diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointGet.json b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointGet.json index 6937e65d7906..ff5b054384ce 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointGet.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointGet.json @@ -38,7 +38,21 @@ { "id": "/subscriptions/subId/resourceGroups/rg1/provders/Microsoft.Network/networkInterfaces/testPe.nic.abcd1234" } - ] + ], + "customDnsConfigs": [ + { + "fqdn": "abc.cosmos.com", + "ipAddresses": [ + "192.168.0.4" + ] + }, + { + "fqdn": "abc2.cosmos.com", + "ipAddresses": [ + "192.168.0.5" + ] + } + ] } } } diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointGetForManualApproval.json b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointGetForManualApproval.json index 299a0add7c75..d9e28992ef8d 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointGetForManualApproval.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointGetForManualApproval.json @@ -38,7 +38,21 @@ { "id": "/subscriptions/subId/resourceGroups/rg1/provders/Microsoft.Network/networkInterfaces/testPe.nic.abcd1234" } - ] + ], + "customDnsConfigs": [ + { + "fqdn": "abc.cosmos.com", + "ipAddresses": [ + "192.168.0.4" + ] + }, + { + "fqdn": "abc2.cosmos.com", + "ipAddresses": [ + "192.168.0.5" + ] + } + ] } } } diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointList.json b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointList.json index c58c63823a38..121d507acd9c 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointList.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointList.json @@ -39,7 +39,21 @@ { "id": "/subscriptions/subId/resourceGroups/rg1/provders/Microsoft.Network/networkInterfaces/pe1.nic.abcd1234" } - ] + ], + "customDnsConfigs": [ + { + "fqdn": "abc.cosmos.com", + "ipAddresses": [ + "192.168.0.4" + ] + }, + { + "fqdn": "abc2.cosmos.com", + "ipAddresses": [ + "192.168.0.5" + ] + } + ] } }, { @@ -73,7 +87,21 @@ { "id": "/subscriptions/subId/resourceGroups/rg1/provders/Microsoft.Network/networkInterfaces/pe2.nic.zyxw9876" } - ] + ], + "customDnsConfigs": [ + { + "fqdn": "abc3.cosmos1.com", + "ipAddresses": [ + "192.168.0.6" + ] + }, + { + "fqdn": "abc4.cosmos1.com", + "ipAddresses": [ + "192.168.0.7" + ] + } + ] } } ] diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointListAll.json b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointListAll.json index 787b68891e30..bbd6f30d1c28 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointListAll.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointListAll.json @@ -37,7 +37,21 @@ { "id": "/subscriptions/subId/resourceGroups/rg1/provders/Microsoft.Network/networkInterfaces/pe1.nic.abcd1234" } - ] + ], + "customDnsConfigs": [ + { + "fqdn": "abc.cosmos.com", + "ipAddresses": [ + "192.168.0.4" + ] + }, + { + "fqdn": "abc2.cosmos.com", + "ipAddresses": [ + "192.168.0.5" + ] + } + ] } }, { @@ -71,7 +85,21 @@ { "id": "/subscriptions/subId/resourceGroups/rg2/provders/Microsoft.Network/networkInterfaces/pe2.nic.zyxw9876" } - ] + ], + "customDnsConfigs": [ + { + "fqdn": "abc3.cosmos1.com", + "ipAddresses": [ + "192.168.0.5" + ] + }, + { + "fqdn": "abc4.cosmos1.com", + "ipAddresses": [ + "192.168.0.6" + ] + } + ] } }, { @@ -104,7 +132,21 @@ { "id": "/subscriptions/subId/resourceGroups/rg3/provders/Microsoft.Network/networkInterfaces/pe3.nic.efgh5463" } - ] + ], + "customDnsConfigs": [ + { + "fqdn": "abc5.cosmos2.com", + "ipAddresses": [ + "192.168.0.7" + ] + }, + { + "fqdn": "abc6.cosmos2.com", + "ipAddresses": [ + "192.168.0.8" + ] + } + ] } } ] diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json index 9ee52bb50b1b..46624a86c4f6 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json @@ -396,6 +396,206 @@ "nextLinkName": "nextLink" } } + }, + "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/privateEndpoints/{privateEndpointName}/privateDnsZoneGroups/{privateDnsZoneGroupName}": { + "delete": { + "tags": [ + "PrivateDnsZoneGroup" + ], + "operationId": "PrivateDnsZoneGroups_Delete", + "description": "Deletes the specified private dns zone group.", + "parameters": [ + { + "name": "resourceGroupName", + "in": "path", + "required": true, + "type": "string", + "description": "The name of the resource group." + }, + { + "name": "privateEndpointName", + "in": "path", + "required": true, + "type": "string", + "description": "The name of the private endpoint." + }, + { + "name": "privateDnsZoneGroupName", + "in": "path", + "required": true, + "type": "string", + "description": "The name of the private dns zone group." + }, + { + "$ref": "./network.json#/parameters/ApiVersionParameter" + }, + { + "$ref": "./network.json#/parameters/SubscriptionIdParameter" + } + ], + "responses": { + "202": { + "description": "Accepted and the operation will complete asynchronously." + }, + "204": { + "description": "Request successful. Resource does not exist." + }, + "200": { + "description": "Delete successful." + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "./network.json#/definitions/CloudError" + } + } + }, + "x-ms-long-running-operation": true, + "x-ms-long-running-operation-options": { + "final-state-via": "location" + }, + "x-ms-examples": { + "Delete private dns zone group": { + "$ref": "./examples/PrivateEndpointDnsZoneGroupDelete.json" + } + } + }, + "get": { + "tags": [ + "PrivateDnsZoneGroup" + ], + "operationId": "PrivateDnsZoneGroups_Get", + "description": "Gets the private dns zone group by specified private endzone", + "parameters": [ + { + "name": "resourceGroupName", + "in": "path", + "required": true, + "type": "string", + "description": "The name of the resource group." + }, + { + "name": "privateEndpointName", + "in": "path", + "required": true, + "type": "string", + "description": "The name of the private endpoint." + }, + { + "name": "privateDnsZoneGroupName", + "in": "path", + "required": true, + "type": "string", + "description": "The name of the private dns zone group." + }, + { + "$ref": "./network.json#/parameters/ApiVersionParameter" + }, + { + "$ref": "./network.json#/parameters/SubscriptionIdParameter" + }, + { + "name": "$expand", + "in": "query", + "required": false, + "type": "string", + "description": "Expands referenced resources." + } + ], + "responses": { + "200": { + "description": "Request successful. The operation returns the resulting privateDnsZoneGroup resource.", + "schema": { + "$ref": "#/definitions/PrivateDNSZoneGroup" + } + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "./network.json#/definitions/CloudError" + } + } + }, + "x-ms-examples": { + "Get private dns zone group": { + "$ref": "./examples/PrivateEndpointDNSZoneGroupGet.json" + } + } + }, + "put": { + "tags": [ + "PrivateDnsZoneGroup" + ], + "operationId": "PrivateDnsZoneGroups_CreateOrUpdate", + "description": "Creates or updates a private dns zone group in the specified private endpoint", + "parameters": [ + { + "name": "resourceGroupName", + "in": "path", + "required": true, + "type": "string", + "description": "The name of the resource group." + }, + { + "name": "privateEndpointName", + "in": "path", + "required": true, + "type": "string", + "description": "The name of the private endpoint." + }, + { + "name": "privateDnsZoneGroupName", + "in": "path", + "required": true, + "type": "string", + "description": "The name of the private dns zone group." + }, + { + "name": "parameters", + "in": "body", + "required": true, + "schema": { + "$ref": "#/definitions/PrivateDNSZoneGroup" + }, + "description": "Parameters supplied to the create or update private dns zone group operation." + }, + { + "$ref": "./network.json#/parameters/ApiVersionParameter" + }, + { + "$ref": "./network.json#/parameters/SubscriptionIdParameter" + } + ], + "responses": { + "200": { + "description": "Update successful. The operation returns the resulting PrivateDNSZoneGroup resource.", + "schema": { + "$ref": "#/definitions/PrivateDNSZoneGroup" + } + }, + "201": { + "description": "Create successful. The operation returns the resulting PrivateDNSZoneGroup resource.", + "schema": { + "$ref": "#/definitions/PrivateDNSZoneGroup" + } + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "./network.json#/definitions/CloudError" + } + } + }, + "x-ms-long-running-operation": true, + "x-ms-long-running-operation-options": { + "final-state-via": "azure-async-operation" + }, + "x-ms-examples": { + "Create private dns zone group": { + "$ref": "./examples/PrivateEndpointDnsZoneGroupCreate.json" + } + } + } } }, "definitions": { @@ -451,10 +651,32 @@ "$ref": "#/definitions/PrivateLinkServiceConnection" }, "description": "A grouping of information about the connection to the remote resource. Used when the network admin does not have access to approve connections to the remote resource." + }, + "customDnsConfigs": { + "type": "array", + "items": { + "$ref": "#/definitions/CustomDnsConfig" + }, + "description": "A grouping of information about dns configurations connecting to the remote resource." } }, "description": "Properties of the private endpoint." }, + "CustomDnsConfig":{ + "properties": { + "fqdn": { + "type": "string", + "description": "The fqdn for the remote resource." + }, + "ipAddresses": { + "type": "array", + "items": { + "type": "string" + }, + "description": "The ip addresses which points to the remote resources." + } + } + }, "PrivateLinkServiceConnection": { "properties": { "properties": { @@ -567,6 +789,115 @@ } }, "description": "The information of an AvailablePrivateEndpointType." + }, + "PrivateDNSZoneGroup": { + "properties": { + "name":{ + "readOnly": true, + "type": "string", + "description": "Name of the resource that is unique within a resource group. This name can be used to access the resource." + }, + "type":{ + "readOnly": true, + "type": "string", + "description": "Resource type." + }, + "properties": { + "x-ms-client-flatten": true, + "$ref": "#/definitions/PrivateDNSZoneGroupProperties", + "description": "Properties of the private dns zone group." + } + }, + "allOf": [ + { + "$ref": "./network.json#/definitions/SubResource" + } + ], + "description": "Private dns zone group resource." + }, + "PrivateDNSZoneGroupProperties": { + "properties": { + "provisioningState": { + "readOnly": true, + "$ref": "./network.json#/definitions/ProvisioningState", + "description": "The provisioning state of the private dns zone group resource." + }, + "privateDnsZoneConfigs": { + "type": "array", + "items": { + "$ref": "#/definitions/PrivateDnsZoneConfig" + }, + "description": "A collection of private dns zone configurations of the private dns zone group." + } + }, + "description": "Properties of the private dns zone group." + }, + "PrivateDnsZoneConfig": { + "properties": { + "name": { + "type": "string", + "description": "The name of the resource that is unique within a resource group. This name can be used to access the resource." + }, + "type": { + "readOnly": true, + "type": "string", + "description": "The resource type." + }, + "properties": { + "x-ms-client-flatten": true, + "$ref": "#/definitions/PrivateDnsZoneConfigProperties", + "description": "Properties of the private dns zone configuration." + } + }, + "allOf": [ + { + "$ref": "./network.json#/definitions/SubResource" + } + ], + "description": "PrivateDnsZoneConfig resource." + }, + "PrivateDnsZoneConfigProperties": { + "properties": { + "provisioningState": { + "readOnly": true, + "$ref": "./network.json#/definitions/ProvisioningState", + "description": "The provisioning state of the private dns zone group resource." + }, + "privateDnsZoneId": { + "type": "string", + "description": "The resource id of the private dns zone." + }, + "recordSets": { + "type": "array", + "items": { + "$ref": "#/definitions/recordSet" + }, + "description": "A collection of information regarding a recordSet, holding information to identify private resources" + } + } + }, + "recordSet": { + "properties": { + "recordType": { + "type": "string", + "description": "resource record type" + }, + "recordSetName": { + "type": "string", + "description": "recordset name" + }, + "fqdn": { + "type": "string", + "description": "fqdn of the recordset" + }, + "ipAddresses": { + "type": "array", + "items": { + "type": "string" + }, + "description": "The ip addresses this record set contains" + } + } } } } From 09bf614696406176e4d6c821ab8fde376e4454c4 Mon Sep 17 00:00:00 2001 From: Shane Baden Date: Fri, 13 Mar 2020 11:18:47 -0700 Subject: [PATCH 02/19] Adding endzone keyword for build --- custom-words.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/custom-words.txt b/custom-words.txt index 57ed9ab4a9bf..d0f3dae51941 100644 --- a/custom-words.txt +++ b/custom-words.txt @@ -480,6 +480,7 @@ endswith endtime Enein engagementfabric +endzone enquoted entitydocument entitysearch From 60db2f2c31e5ab5fec0e07dc6dd96aa6e5d77c05 Mon Sep 17 00:00:00 2001 From: Shane Baden Date: Sun, 15 Mar 2020 00:13:40 -0700 Subject: [PATCH 03/19] Adding reference to 2020 private endpoint in readme for validation purposes --- specification/network/resource-manager/readme.md | 1 + 1 file changed, 1 insertion(+) diff --git a/specification/network/resource-manager/readme.md b/specification/network/resource-manager/readme.md index 740e0ff12c15..2d468036b3a8 100644 --- a/specification/network/resource-manager/readme.md +++ b/specification/network/resource-manager/readme.md @@ -1509,6 +1509,7 @@ require: $(this-folder)/../../../profiles/readme.md # all the input files across all versions input-file: + - $(this-folder)/Microsoft.Network/stable/2020-03-01/privateEndpoint.json - $(this-folder)/Microsoft.Network/stable/2019-12-01/applicationGateway.json - $(this-folder)/Microsoft.Network/stable/2019-12-01/applicationSecurityGroup.json - $(this-folder)/Microsoft.Network/stable/2019-12-01/availableDelegations.json From 4abe83bc0fbe03431c20e9dfe44ae994e86597ab Mon Sep 17 00:00:00 2001 From: Shane Baden Date: Sun, 15 Mar 2020 00:44:24 -0700 Subject: [PATCH 04/19] Misspelled reference to Get file fixed --- .../Microsoft.Network/stable/2020-03-01/privateEndpoint.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json index 46624a86c4f6..661204506b03 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json @@ -518,7 +518,7 @@ }, "x-ms-examples": { "Get private dns zone group": { - "$ref": "./examples/PrivateEndpointDNSZoneGroupGet.json" + "$ref": "./examples/PrivateEndpointDnsZoneGroupGet.json" } } }, From fb44b13b62b20e5a9d379db98f9764ae02a3ce15 Mon Sep 17 00:00:00 2001 From: Shane Baden Date: Sun, 15 Mar 2020 01:08:53 -0700 Subject: [PATCH 05/19] Ran prettier fix on files --- .../examples/PrivateEndpointCreate.json | 4 +- ...rivateEndpointCreateForManualApproval.json | 4 +- .../examples/PrivateEndpointGet.json | 2 +- .../PrivateEndpointGetForManualApproval.json | 2 +- .../examples/PrivateEndpointList.json | 4 +- .../examples/PrivateEndpointListAll.json | 6 +- .../stable/2020-03-01/privateEndpoint.json | 400 +++++++++--------- 7 files changed, 211 insertions(+), 211 deletions(-) diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointCreate.json b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointCreate.json index a61989b2e628..67f60c5df8b3 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointCreate.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointCreate.json @@ -70,7 +70,7 @@ "192.168.0.5" ] } - ] + ] } } }, @@ -118,7 +118,7 @@ "192.168.0.5" ] } - ] + ] } } } diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointCreateForManualApproval.json b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointCreateForManualApproval.json index d74e7b6d08fc..d2b96f87ef25 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointCreateForManualApproval.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointCreateForManualApproval.json @@ -70,7 +70,7 @@ "192.168.0.5" ] } - ] + ] } } }, @@ -118,7 +118,7 @@ "192.168.0.5" ] } - ] + ] } } } diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointGet.json b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointGet.json index ff5b054384ce..dcef18314bff 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointGet.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointGet.json @@ -52,7 +52,7 @@ "192.168.0.5" ] } - ] + ] } } } diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointGetForManualApproval.json b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointGetForManualApproval.json index d9e28992ef8d..0a7a2a20740a 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointGetForManualApproval.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointGetForManualApproval.json @@ -52,7 +52,7 @@ "192.168.0.5" ] } - ] + ] } } } diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointList.json b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointList.json index 121d507acd9c..5b962c6b3802 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointList.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointList.json @@ -53,7 +53,7 @@ "192.168.0.5" ] } - ] + ] } }, { @@ -101,7 +101,7 @@ "192.168.0.7" ] } - ] + ] } } ] diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointListAll.json b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointListAll.json index bbd6f30d1c28..d9cd39fa2658 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointListAll.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointListAll.json @@ -51,7 +51,7 @@ "192.168.0.5" ] } - ] + ] } }, { @@ -99,7 +99,7 @@ "192.168.0.6" ] } - ] + ] } }, { @@ -146,7 +146,7 @@ "192.168.0.8" ] } - ] + ] } } ] diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json index 661204506b03..92d872555410 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json @@ -399,200 +399,200 @@ }, "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/privateEndpoints/{privateEndpointName}/privateDnsZoneGroups/{privateDnsZoneGroupName}": { "delete": { - "tags": [ - "PrivateDnsZoneGroup" - ], - "operationId": "PrivateDnsZoneGroups_Delete", - "description": "Deletes the specified private dns zone group.", - "parameters": [ - { - "name": "resourceGroupName", - "in": "path", - "required": true, - "type": "string", - "description": "The name of the resource group." - }, - { - "name": "privateEndpointName", - "in": "path", - "required": true, - "type": "string", - "description": "The name of the private endpoint." - }, - { - "name": "privateDnsZoneGroupName", - "in": "path", - "required": true, - "type": "string", - "description": "The name of the private dns zone group." - }, - { - "$ref": "./network.json#/parameters/ApiVersionParameter" - }, - { - "$ref": "./network.json#/parameters/SubscriptionIdParameter" - } - ], - "responses": { - "202": { - "description": "Accepted and the operation will complete asynchronously." - }, - "204": { - "description": "Request successful. Resource does not exist." - }, - "200": { - "description": "Delete successful." - }, - "default": { - "description": "Error response describing why the operation failed.", - "schema": { - "$ref": "./network.json#/definitions/CloudError" - } - } - }, - "x-ms-long-running-operation": true, - "x-ms-long-running-operation-options": { - "final-state-via": "location" - }, - "x-ms-examples": { - "Delete private dns zone group": { - "$ref": "./examples/PrivateEndpointDnsZoneGroupDelete.json" - } - } - }, - "get": { - "tags": [ - "PrivateDnsZoneGroup" - ], - "operationId": "PrivateDnsZoneGroups_Get", - "description": "Gets the private dns zone group by specified private endzone", - "parameters": [ - { - "name": "resourceGroupName", - "in": "path", - "required": true, - "type": "string", - "description": "The name of the resource group." - }, - { - "name": "privateEndpointName", - "in": "path", - "required": true, - "type": "string", - "description": "The name of the private endpoint." - }, - { - "name": "privateDnsZoneGroupName", - "in": "path", - "required": true, - "type": "string", - "description": "The name of the private dns zone group." - }, - { - "$ref": "./network.json#/parameters/ApiVersionParameter" - }, - { - "$ref": "./network.json#/parameters/SubscriptionIdParameter" - }, - { - "name": "$expand", - "in": "query", - "required": false, - "type": "string", - "description": "Expands referenced resources." - } - ], - "responses": { - "200": { - "description": "Request successful. The operation returns the resulting privateDnsZoneGroup resource.", - "schema": { - "$ref": "#/definitions/PrivateDNSZoneGroup" - } - }, - "default": { - "description": "Error response describing why the operation failed.", - "schema": { - "$ref": "./network.json#/definitions/CloudError" - } - } - }, - "x-ms-examples": { - "Get private dns zone group": { - "$ref": "./examples/PrivateEndpointDnsZoneGroupGet.json" - } - } - }, - "put": { - "tags": [ - "PrivateDnsZoneGroup" - ], - "operationId": "PrivateDnsZoneGroups_CreateOrUpdate", - "description": "Creates or updates a private dns zone group in the specified private endpoint", - "parameters": [ - { - "name": "resourceGroupName", - "in": "path", - "required": true, - "type": "string", - "description": "The name of the resource group." - }, - { - "name": "privateEndpointName", - "in": "path", - "required": true, - "type": "string", - "description": "The name of the private endpoint." - }, - { - "name": "privateDnsZoneGroupName", - "in": "path", - "required": true, - "type": "string", - "description": "The name of the private dns zone group." - }, - { - "name": "parameters", - "in": "body", - "required": true, - "schema": { - "$ref": "#/definitions/PrivateDNSZoneGroup" - }, - "description": "Parameters supplied to the create or update private dns zone group operation." - }, - { - "$ref": "./network.json#/parameters/ApiVersionParameter" - }, - { - "$ref": "./network.json#/parameters/SubscriptionIdParameter" - } - ], - "responses": { - "200": { - "description": "Update successful. The operation returns the resulting PrivateDNSZoneGroup resource.", - "schema": { - "$ref": "#/definitions/PrivateDNSZoneGroup" - } - }, - "201": { - "description": "Create successful. The operation returns the resulting PrivateDNSZoneGroup resource.", - "schema": { - "$ref": "#/definitions/PrivateDNSZoneGroup" - } - }, - "default": { - "description": "Error response describing why the operation failed.", - "schema": { - "$ref": "./network.json#/definitions/CloudError" - } - } - }, - "x-ms-long-running-operation": true, - "x-ms-long-running-operation-options": { - "final-state-via": "azure-async-operation" - }, - "x-ms-examples": { - "Create private dns zone group": { - "$ref": "./examples/PrivateEndpointDnsZoneGroupCreate.json" + "tags": [ + "PrivateDnsZoneGroup" + ], + "operationId": "PrivateDnsZoneGroups_Delete", + "description": "Deletes the specified private dns zone group.", + "parameters": [ + { + "name": "resourceGroupName", + "in": "path", + "required": true, + "type": "string", + "description": "The name of the resource group." + }, + { + "name": "privateEndpointName", + "in": "path", + "required": true, + "type": "string", + "description": "The name of the private endpoint." + }, + { + "name": "privateDnsZoneGroupName", + "in": "path", + "required": true, + "type": "string", + "description": "The name of the private dns zone group." + }, + { + "$ref": "./network.json#/parameters/ApiVersionParameter" + }, + { + "$ref": "./network.json#/parameters/SubscriptionIdParameter" + } + ], + "responses": { + "202": { + "description": "Accepted and the operation will complete asynchronously." + }, + "204": { + "description": "Request successful. Resource does not exist." + }, + "200": { + "description": "Delete successful." + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "./network.json#/definitions/CloudError" + } + } + }, + "x-ms-long-running-operation": true, + "x-ms-long-running-operation-options": { + "final-state-via": "location" + }, + "x-ms-examples": { + "Delete private dns zone group": { + "$ref": "./examples/PrivateEndpointDnsZoneGroupDelete.json" + } + } + }, + "get": { + "tags": [ + "PrivateDnsZoneGroup" + ], + "operationId": "PrivateDnsZoneGroups_Get", + "description": "Gets the private dns zone group by specified private endzone", + "parameters": [ + { + "name": "resourceGroupName", + "in": "path", + "required": true, + "type": "string", + "description": "The name of the resource group." + }, + { + "name": "privateEndpointName", + "in": "path", + "required": true, + "type": "string", + "description": "The name of the private endpoint." + }, + { + "name": "privateDnsZoneGroupName", + "in": "path", + "required": true, + "type": "string", + "description": "The name of the private dns zone group." + }, + { + "$ref": "./network.json#/parameters/ApiVersionParameter" + }, + { + "$ref": "./network.json#/parameters/SubscriptionIdParameter" + }, + { + "name": "$expand", + "in": "query", + "required": false, + "type": "string", + "description": "Expands referenced resources." + } + ], + "responses": { + "200": { + "description": "Request successful. The operation returns the resulting privateDnsZoneGroup resource.", + "schema": { + "$ref": "#/definitions/PrivateDNSZoneGroup" + } + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "./network.json#/definitions/CloudError" + } + } + }, + "x-ms-examples": { + "Get private dns zone group": { + "$ref": "./examples/PrivateEndpointDnsZoneGroupGet.json" + } + } + }, + "put": { + "tags": [ + "PrivateDnsZoneGroup" + ], + "operationId": "PrivateDnsZoneGroups_CreateOrUpdate", + "description": "Creates or updates a private dns zone group in the specified private endpoint", + "parameters": [ + { + "name": "resourceGroupName", + "in": "path", + "required": true, + "type": "string", + "description": "The name of the resource group." + }, + { + "name": "privateEndpointName", + "in": "path", + "required": true, + "type": "string", + "description": "The name of the private endpoint." + }, + { + "name": "privateDnsZoneGroupName", + "in": "path", + "required": true, + "type": "string", + "description": "The name of the private dns zone group." + }, + { + "name": "parameters", + "in": "body", + "required": true, + "schema": { + "$ref": "#/definitions/PrivateDNSZoneGroup" + }, + "description": "Parameters supplied to the create or update private dns zone group operation." + }, + { + "$ref": "./network.json#/parameters/ApiVersionParameter" + }, + { + "$ref": "./network.json#/parameters/SubscriptionIdParameter" + } + ], + "responses": { + "200": { + "description": "Update successful. The operation returns the resulting PrivateDNSZoneGroup resource.", + "schema": { + "$ref": "#/definitions/PrivateDNSZoneGroup" + } + }, + "201": { + "description": "Create successful. The operation returns the resulting PrivateDNSZoneGroup resource.", + "schema": { + "$ref": "#/definitions/PrivateDNSZoneGroup" + } + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "./network.json#/definitions/CloudError" + } + } + }, + "x-ms-long-running-operation": true, + "x-ms-long-running-operation-options": { + "final-state-via": "azure-async-operation" + }, + "x-ms-examples": { + "Create private dns zone group": { + "$ref": "./examples/PrivateEndpointDnsZoneGroupCreate.json" } } } @@ -662,7 +662,7 @@ }, "description": "Properties of the private endpoint." }, - "CustomDnsConfig":{ + "CustomDnsConfig": { "properties": { "fqdn": { "type": "string", @@ -792,12 +792,12 @@ }, "PrivateDNSZoneGroup": { "properties": { - "name":{ + "name": { "readOnly": true, "type": "string", "description": "Name of the resource that is unique within a resource group. This name can be used to access the resource." }, - "type":{ + "type": { "readOnly": true, "type": "string", "description": "Resource type." @@ -866,7 +866,7 @@ "privateDnsZoneId": { "type": "string", "description": "The resource id of the private dns zone." - }, + }, "recordSets": { "type": "array", "items": { @@ -882,11 +882,11 @@ "type": "string", "description": "resource record type" }, - "recordSetName": { + "recordSetName": { "type": "string", "description": "recordset name" }, - "fqdn": { + "fqdn": { "type": "string", "description": "fqdn of the recordset" }, From 176991cce97a3ecd0b11cae6c413370da59aa87e Mon Sep 17 00:00:00 2001 From: Shane Baden Date: Sun, 15 Mar 2020 01:18:42 -0700 Subject: [PATCH 06/19] Removing reference in readme --- specification/network/resource-manager/readme.md | 1 - 1 file changed, 1 deletion(-) diff --git a/specification/network/resource-manager/readme.md b/specification/network/resource-manager/readme.md index 2d468036b3a8..740e0ff12c15 100644 --- a/specification/network/resource-manager/readme.md +++ b/specification/network/resource-manager/readme.md @@ -1509,7 +1509,6 @@ require: $(this-folder)/../../../profiles/readme.md # all the input files across all versions input-file: - - $(this-folder)/Microsoft.Network/stable/2020-03-01/privateEndpoint.json - $(this-folder)/Microsoft.Network/stable/2019-12-01/applicationGateway.json - $(this-folder)/Microsoft.Network/stable/2019-12-01/applicationSecurityGroup.json - $(this-folder)/Microsoft.Network/stable/2019-12-01/availableDelegations.json From b0eb57f8bd46e7c83268fa64f271b1319445cd0a Mon Sep 17 00:00:00 2001 From: Shane Baden Date: Sun, 15 Mar 2020 11:38:00 -0700 Subject: [PATCH 07/19] Added some needed capitilization and punctuation, will be a pt2 to this commit --- .../stable/2020-03-01/privateEndpoint.json | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json index 92d872555410..478c88098d54 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json @@ -465,7 +465,7 @@ "PrivateDnsZoneGroup" ], "operationId": "PrivateDnsZoneGroups_Get", - "description": "Gets the private dns zone group by specified private endzone", + "description": "Gets the private dns zone group by specified private endzone.", "parameters": [ { "name": "resourceGroupName", @@ -527,7 +527,7 @@ "PrivateDnsZoneGroup" ], "operationId": "PrivateDnsZoneGroups_CreateOrUpdate", - "description": "Creates or updates a private dns zone group in the specified private endpoint", + "description": "Creates or updates a private dns zone group in the specified private endpoint.", "parameters": [ { "name": "resourceGroupName", @@ -872,7 +872,7 @@ "items": { "$ref": "#/definitions/recordSet" }, - "description": "A collection of information regarding a recordSet, holding information to identify private resources" + "description": "A collection of information regarding a recordSet, holding information to identify private resources." } } }, @@ -880,22 +880,22 @@ "properties": { "recordType": { "type": "string", - "description": "resource record type" + "description": "Resource record type." }, "recordSetName": { "type": "string", - "description": "recordset name" + "description": "Recordset name." }, "fqdn": { "type": "string", - "description": "fqdn of the recordset" + "description": "FQDN of the recordset." }, "ipAddresses": { "type": "array", "items": { "type": "string" }, - "description": "The ip addresses this record set contains" + "description": "The ip addresses this record set contains." } } } From 7de4bfc836d34dfa0e33bffc2564bc54cd791d13 Mon Sep 17 00:00:00 2001 From: Shane Baden Date: Sun, 15 Mar 2020 13:44:02 -0700 Subject: [PATCH 08/19] Added descriptions --- .../stable/2020-03-01/privateEndpoint.json | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json index 478c88098d54..33c0284148fd 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json @@ -675,7 +675,8 @@ }, "description": "The ip addresses which points to the remote resources." } - } + }, + "description": "Contains custom DNS resolution configuration from customer." }, "PrivateLinkServiceConnection": { "properties": { @@ -836,7 +837,7 @@ "properties": { "name": { "type": "string", - "description": "The name of the resource that is unique within a resource group. This name can be used to access the resource." + "description": "The resource name." }, "type": { "readOnly": true, @@ -870,13 +871,14 @@ "recordSets": { "type": "array", "items": { - "$ref": "#/definitions/recordSet" + "$ref": "#/definitions/RecordSet" }, "description": "A collection of information regarding a recordSet, holding information to identify private resources." } - } + }, + "description": "Properties of the private dns zone configuration resource." }, - "recordSet": { + "RecordSet": { "properties": { "recordType": { "type": "string", @@ -897,7 +899,8 @@ }, "description": "The ip addresses this record set contains." } - } + }, + "description": "A collective group of information concerning the record set connectivity information." } } } From cdfd5757deab91c8714c2a34170c9dc37e5f5c59 Mon Sep 17 00:00:00 2001 From: Shane Baden Date: Sun, 15 Mar 2020 13:54:54 -0700 Subject: [PATCH 09/19] Rerunning tests. --- .../Microsoft.Network/stable/2020-03-01/privateEndpoint.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json index 33c0284148fd..42cb2bf0f448 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json @@ -900,7 +900,7 @@ "description": "The ip addresses this record set contains." } }, - "description": "A collective group of information concerning the record set connectivity information." + "description": "A collective group of information about the record set connectivity information." } } } From 9040db565154d6c4e1bfd4792807560c27ff7c5c Mon Sep 17 00:00:00 2001 From: Shane Baden Date: Mon, 16 Mar 2020 01:33:53 -0700 Subject: [PATCH 10/19] Updated definitions for customdnsconfig and record set --- .../stable/2020-03-01/privateEndpoint.json | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json index 42cb2bf0f448..91f567af7c81 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json @@ -657,7 +657,7 @@ "items": { "$ref": "#/definitions/CustomDnsConfig" }, - "description": "A grouping of information about dns configurations connecting to the remote resource." + "description": "A grouping of information about dns configurations connecting to the private endpoint." } }, "description": "Properties of the private endpoint." @@ -666,14 +666,14 @@ "properties": { "fqdn": { "type": "string", - "description": "The fqdn for the remote resource." + "description": "Fqdn that resolves for private endpoint ip address." }, "ipAddresses": { "type": "array", "items": { "type": "string" }, - "description": "The ip addresses which points to the remote resources." + "description": "The private ip address of the private endpoint." } }, "description": "Contains custom DNS resolution configuration from customer." @@ -890,14 +890,14 @@ }, "fqdn": { "type": "string", - "description": "FQDN of the recordset." + "description": "Fqdn that resolves for private endpoint ip address." }, "ipAddresses": { "type": "array", "items": { "type": "string" }, - "description": "The ip addresses this record set contains." + "description": "The private ip address of the private endpoint." } }, "description": "A collective group of information about the record set connectivity information." From 30a5f340a115b94ac9c5986c872d201d319aec12 Mon Sep 17 00:00:00 2001 From: Shane Baden Date: Mon, 16 Mar 2020 18:06:21 -0700 Subject: [PATCH 11/19] Rebuilding for pr --- .../Microsoft.Network/stable/2020-03-01/privateEndpoint.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json index 91f567af7c81..9f392e3b64d9 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json @@ -882,7 +882,7 @@ "properties": { "recordType": { "type": "string", - "description": "Resource record type." + "description": "Resource recordtype." }, "recordSetName": { "type": "string", From 0629578cc522af9776c69522d5c6902769892741 Mon Sep 17 00:00:00 2001 From: Shane Baden Date: Mon, 16 Mar 2020 18:17:00 -0700 Subject: [PATCH 12/19] Changing word back to original sentence for PR. --- .../Microsoft.Network/stable/2020-03-01/privateEndpoint.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json index 9f392e3b64d9..91f567af7c81 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json @@ -882,7 +882,7 @@ "properties": { "recordType": { "type": "string", - "description": "Resource recordtype." + "description": "Resource record type." }, "recordSetName": { "type": "string", From 60fd6be225e797c6fb9c95ddc97ad2620e97b5b8 Mon Sep 17 00:00:00 2001 From: Shane Baden Date: Thu, 26 Mar 2020 17:23:26 -0700 Subject: [PATCH 13/19] Changed name in example file for create, as well as added List operation and fixed pr comments --- .../PrivateEndpointDnsZoneGroupCreate.json | 6 +- .../PrivateEndpointDnsZoneGroupList.json | 80 +++++++++++++ .../stable/2020-03-01/privateEndpoint.json | 111 +++++++++++++----- 3 files changed, 164 insertions(+), 33 deletions(-) create mode 100644 specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointDnsZoneGroupList.json diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointDnsZoneGroupCreate.json b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointDnsZoneGroupCreate.json index a9ce0be7a673..6284ccb749ee 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointDnsZoneGroupCreate.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointDnsZoneGroupCreate.json @@ -4,7 +4,7 @@ "subscriptionId": "subId", "resourceGroupName": "rg1", "privateEndpointName": "testPe", - "privateDnsZoneGroupName": "testPdns", + "privateDnsZoneGroupName": "testPdnsgroup", "parameters": { "properties": { "privateDnsZoneConfigs": [ @@ -20,7 +20,7 @@ "responses": { "200": { "body": { - "name": "testPdns", + "name": "testPdnsgroup", "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/privateLinkServices/testPe/privateDnsZoneGroups/testPdnsgroup", "properties": { "provisioningState": "Succeeded", @@ -54,7 +54,7 @@ }, "201": { "body": { - "name": "testPdns", + "name": "testPdnsgroup", "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/privateLinkServices/testPe/privateDnsZoneGroups/testPdnsgroup", "properties": { "provisioningState": "Succeeded", diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointDnsZoneGroupList.json b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointDnsZoneGroupList.json new file mode 100644 index 000000000000..0a2508bc9b87 --- /dev/null +++ b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointDnsZoneGroupList.json @@ -0,0 +1,80 @@ +{ + "parameters": { + "api-version": "2020-03-01", + "subscriptionId": "subId", + "resourceGroupName": "rg1", + "privateEndpointName": "testPe" + }, + "responses": { + "200": { + "body": { + "value": [ + { + "name": "testPdnsgroup1", + "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/privateLinkServices/testPe/privateDnsZoneGroups/testPdnsgroup1", + "properties": { + "provisioningState": "Succeeded", + "privateDnsZoneConfigs": [ + { + "properties": { + "privateDnsZoneId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/privateDnsZones/zone1.com", + "recordSets": [ + { + "recordType": "A", + "recordSetName": "abc", + "fqdn": "abc.zone1.com", + "ipAddresses": [ + "10.0.0.4" + ] + }, + { + "recordType": "A", + "recordSetName": "abc2", + "fqdn": "abc2.zone1.com", + "ipAddresses": [ + "10.0.0.5" + ] + } + ] + } + } + ] + } + }, + { + "name": "testPdnsgroup2", + "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/privateLinkServices/testPe/privateDnsZoneGroups/testPdnsgroup2", + "properties": { + "provisioningState": "Succeeded", + "privateDnsZoneConfigs": [ + { + "properties": { + "privateDnsZoneId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/privateDnsZones/zone2.com", + "recordSets": [ + { + "recordType": "A", + "recordSetName": "abc3", + "fqdn": "abc3.zone2.com", + "ipAddresses": [ + "10.0.0.6" + ] + }, + { + "recordType": "A", + "recordSetName": "abc4", + "fqdn": "abc4.zone2.com", + "ipAddresses": [ + "10.0.0.7" + ] + } + ] + } + } + ] + } + } + ] + } + } + } +} diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json index 91f567af7c81..036b867f4116 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json @@ -465,7 +465,7 @@ "PrivateDnsZoneGroup" ], "operationId": "PrivateDnsZoneGroups_Get", - "description": "Gets the private dns zone group by specified private endzone.", + "description": "Gets the private dns zone group resource by specified private dns zone group name.", "parameters": [ { "name": "resourceGroupName", @@ -506,7 +506,7 @@ "200": { "description": "Request successful. The operation returns the resulting privateDnsZoneGroup resource.", "schema": { - "$ref": "#/definitions/PrivateDNSZoneGroup" + "$ref": "#/definitions/PrivateDnsZoneGroup" } }, "default": { @@ -555,7 +555,7 @@ "in": "body", "required": true, "schema": { - "$ref": "#/definitions/PrivateDNSZoneGroup" + "$ref": "#/definitions/PrivateDnsZoneGroup" }, "description": "Parameters supplied to the create or update private dns zone group operation." }, @@ -568,15 +568,15 @@ ], "responses": { "200": { - "description": "Update successful. The operation returns the resulting PrivateDNSZoneGroup resource.", + "description": "Update successful. The operation returns the resulting PrivateDnsZoneGroup resource.", "schema": { - "$ref": "#/definitions/PrivateDNSZoneGroup" + "$ref": "#/definitions/PrivateDnsZoneGroup" } }, "201": { - "description": "Create successful. The operation returns the resulting PrivateDNSZoneGroup resource.", + "description": "Create successful. The operation returns the resulting PrivateDnsZoneGroup resource.", "schema": { - "$ref": "#/definitions/PrivateDNSZoneGroup" + "$ref": "#/definitions/PrivateDnsZoneGroup" } }, "default": { @@ -596,6 +596,59 @@ } } } + }, + "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/privateEndpoints/{privateEndpointName}/privateDnsZoneGroups": { + "get": { + "tags": [ + "PrivateDnsZoneGroup" + ], + "operationId": "PrivateDnsZoneGroups_List", + "description": "Gets all private dns zone groups in a private endpoint.", + "parameters": [ + { + "name": "privateEndpointName", + "in": "path", + "required": true, + "type": "string", + "description": "The name of the private endpoint." + }, + { + "name": "resourceGroupName", + "in": "path", + "required": true, + "type": "string", + "description": "The name of the resource group." + }, + { + "$ref": "./network.json#/parameters/ApiVersionParameter" + }, + { + "$ref": "./network.json#/parameters/SubscriptionIdParameter" + } + ], + "responses": { + "200": { + "description": "Request successful. The operation returns a list of private dns zone group resources.", + "schema": { + "$ref": "#/definitions/PrivateDnsZoneGroupListResult" + } + }, + "default": { + "description": "Error.", + "schema": { + "$ref": "./network.json#/definitions/Error" + } + } + }, + "x-ms-examples": { + "List private endpoints in resource group": { + "$ref": "./examples/PrivateEndpointDnsZoneGroupList.json" + } + }, + "x-ms-pageable": { + "nextLinkName": "nextLink" + } + } } }, "definitions": { @@ -676,7 +729,7 @@ "description": "The private ip address of the private endpoint." } }, - "description": "Contains custom DNS resolution configuration from customer." + "description": "Contains custom Dns resolution configuration from customer." }, "PrivateLinkServiceConnection": { "properties": { @@ -753,6 +806,23 @@ }, "description": "Response for the ListPrivateEndpoints API service call." }, + "PrivateDnsZoneGroupListResult": { + "properties": { + "value": { + "type": "array", + "items": { + "$ref": "#/definitions/PrivateDnsZoneGroup" + }, + "description": "A list of private dns zone group resources in a private endpoint." + }, + "nextLink": { + "type": "string", + "description": "The URL to get the next set of results.", + "readOnly": true + } + }, + "description": "Response for the ListPrivateDnsZoneGroups API service call." + }, "AvailablePrivateEndpointTypesResult": { "properties": { "value": { @@ -791,7 +861,7 @@ }, "description": "The information of an AvailablePrivateEndpointType." }, - "PrivateDNSZoneGroup": { + "PrivateDnsZoneGroup": { "properties": { "name": { "readOnly": true, @@ -805,7 +875,7 @@ }, "properties": { "x-ms-client-flatten": true, - "$ref": "#/definitions/PrivateDNSZoneGroupProperties", + "$ref": "#/definitions/PrivateDnsZoneGroupPropertiesFormat", "description": "Properties of the private dns zone group." } }, @@ -816,7 +886,7 @@ ], "description": "Private dns zone group resource." }, - "PrivateDNSZoneGroupProperties": { + "PrivateDnsZoneGroupPropertiesFormat": { "properties": { "provisioningState": { "readOnly": true, @@ -835,35 +905,16 @@ }, "PrivateDnsZoneConfig": { "properties": { - "name": { - "type": "string", - "description": "The resource name." - }, - "type": { - "readOnly": true, - "type": "string", - "description": "The resource type." - }, "properties": { "x-ms-client-flatten": true, "$ref": "#/definitions/PrivateDnsZoneConfigProperties", "description": "Properties of the private dns zone configuration." } }, - "allOf": [ - { - "$ref": "./network.json#/definitions/SubResource" - } - ], "description": "PrivateDnsZoneConfig resource." }, "PrivateDnsZoneConfigProperties": { "properties": { - "provisioningState": { - "readOnly": true, - "$ref": "./network.json#/definitions/ProvisioningState", - "description": "The provisioning state of the private dns zone group resource." - }, "privateDnsZoneId": { "type": "string", "description": "The resource id of the private dns zone." From d951084d5b34a0e5a1c7a6ce9fdb8536cc337f74 Mon Sep 17 00:00:00 2001 From: Shane Baden Date: Sat, 28 Mar 2020 18:52:33 -0700 Subject: [PATCH 14/19] resolved comments based on pr --- .../stable/2020-03-01/privateEndpoint.json | 34 +++++++------------ 1 file changed, 13 insertions(+), 21 deletions(-) diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json index 036b867f4116..4e16cfe00cb2 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json @@ -400,7 +400,7 @@ "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/privateEndpoints/{privateEndpointName}/privateDnsZoneGroups/{privateDnsZoneGroupName}": { "delete": { "tags": [ - "PrivateDnsZoneGroup" + "PrivateDnsZoneGroups" ], "operationId": "PrivateDnsZoneGroups_Delete", "description": "Deletes the specified private dns zone group.", @@ -462,7 +462,7 @@ }, "get": { "tags": [ - "PrivateDnsZoneGroup" + "PrivateDnsZoneGroups" ], "operationId": "PrivateDnsZoneGroups_Get", "description": "Gets the private dns zone group resource by specified private dns zone group name.", @@ -493,13 +493,6 @@ }, { "$ref": "./network.json#/parameters/SubscriptionIdParameter" - }, - { - "name": "$expand", - "in": "query", - "required": false, - "type": "string", - "description": "Expands referenced resources." } ], "responses": { @@ -524,7 +517,7 @@ }, "put": { "tags": [ - "PrivateDnsZoneGroup" + "PrivateDnsZoneGroups" ], "operationId": "PrivateDnsZoneGroups_CreateOrUpdate", "description": "Creates or updates a private dns zone group in the specified private endpoint.", @@ -600,7 +593,7 @@ "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/privateEndpoints/{privateEndpointName}/privateDnsZoneGroups": { "get": { "tags": [ - "PrivateDnsZoneGroup" + "PrivateDnsZoneGroups" ], "operationId": "PrivateDnsZoneGroups_List", "description": "Gets all private dns zone groups in a private endpoint.", @@ -708,25 +701,25 @@ "customDnsConfigs": { "type": "array", "items": { - "$ref": "#/definitions/CustomDnsConfig" + "$ref": "#/definitions/CustomDnsConfigPropertiesFormat" }, - "description": "A grouping of information about dns configurations connecting to the private endpoint." + "description": "An array of custom dns configurations." } }, "description": "Properties of the private endpoint." }, - "CustomDnsConfig": { + "CustomDnsConfigPropertiesFormat": { "properties": { "fqdn": { "type": "string", - "description": "Fqdn that resolves for private endpoint ip address." + "description": "Fqdn that resolves to private endpoint ip address." }, "ipAddresses": { "type": "array", "items": { "type": "string" }, - "description": "The private ip address of the private endpoint." + "description": "A list of private ip addresses of the private endpoint." } }, "description": "Contains custom Dns resolution configuration from customer." @@ -864,7 +857,6 @@ "PrivateDnsZoneGroup": { "properties": { "name": { - "readOnly": true, "type": "string", "description": "Name of the resource that is unique within a resource group. This name can be used to access the resource." }, @@ -907,13 +899,13 @@ "properties": { "properties": { "x-ms-client-flatten": true, - "$ref": "#/definitions/PrivateDnsZoneConfigProperties", + "$ref": "#/definitions/PrivateDnsZonePropertiesFormat", "description": "Properties of the private dns zone configuration." } }, "description": "PrivateDnsZoneConfig resource." }, - "PrivateDnsZoneConfigProperties": { + "PrivateDnsZonePropertiesFormat": { "properties": { "privateDnsZoneId": { "type": "string", @@ -941,7 +933,7 @@ }, "fqdn": { "type": "string", - "description": "Fqdn that resolves for private endpoint ip address." + "description": "Fqdn that resolves to private endpoint ip address." }, "ipAddresses": { "type": "array", @@ -951,7 +943,7 @@ "description": "The private ip address of the private endpoint." } }, - "description": "A collective group of information about the record set connectivity information." + "description": "A collective group of information about the record set information." } } } From 7103bc28633faab5b5bdd3c722ffe2f572b03157 Mon Sep 17 00:00:00 2001 From: Shane Baden Date: Mon, 30 Mar 2020 15:15:42 -0700 Subject: [PATCH 15/19] Added changes based on PRcomments --- .../stable/2020-03-01/privateEndpoint.json | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json index 4e16cfe00cb2..d1240b7ff2b9 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json @@ -860,6 +860,11 @@ "type": "string", "description": "Name of the resource that is unique within a resource group. This name can be used to access the resource." }, + "etag": { + "readOnly": true, + "type": "string", + "description": "A unique read-only string that changes whenever the resource is updated." + }, "type": { "readOnly": true, "type": "string", @@ -897,6 +902,10 @@ }, "PrivateDnsZoneConfig": { "properties": { + "name": { + "type": "string", + "description": "Name of the resource that is unique within a resource group. This name can be used to access the resource." + }, "properties": { "x-ms-client-flatten": true, "$ref": "#/definitions/PrivateDnsZonePropertiesFormat", @@ -935,6 +944,15 @@ "type": "string", "description": "Fqdn that resolves to private endpoint ip address." }, + "provisioningState": { + "readOnly": true, + "$ref": "./network.json#/definitions/ProvisioningState", + "description": "The provisioning state of the recordset." + }, + "ttl": { + "type": "int", + "description": "Recordset time to live." + }, "ipAddresses": { "type": "array", "items": { From 401c7806d7e5395d4292c49cd071324d35527e72 Mon Sep 17 00:00:00 2001 From: Shane Baden Date: Mon, 30 Mar 2020 15:23:13 -0700 Subject: [PATCH 16/19] Added integer tag to ttl --- .../Microsoft.Network/stable/2020-03-01/privateEndpoint.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json index d1240b7ff2b9..e5aa01dee62d 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json @@ -950,7 +950,7 @@ "description": "The provisioning state of the recordset." }, "ttl": { - "type": "int", + "type": "integer", "description": "Recordset time to live." }, "ipAddresses": { From 5c0da334687c5128ad7e44472ebcc776f7ff76b2 Mon Sep 17 00:00:00 2001 From: Shane Baden Date: Mon, 30 Mar 2020 18:19:12 -0700 Subject: [PATCH 17/19] getting rid of type in private endpoint json --- .../Microsoft.Network/stable/2020-03-01/privateEndpoint.json | 5 ----- 1 file changed, 5 deletions(-) diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json index e5aa01dee62d..55c0d68b7c04 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json @@ -865,11 +865,6 @@ "type": "string", "description": "A unique read-only string that changes whenever the resource is updated." }, - "type": { - "readOnly": true, - "type": "string", - "description": "Resource type." - }, "properties": { "x-ms-client-flatten": true, "$ref": "#/definitions/PrivateDnsZoneGroupPropertiesFormat", From b626822e3f829f3a680113038ff0b8568ddf6eb8 Mon Sep 17 00:00:00 2001 From: Shane Baden Date: Mon, 30 Mar 2020 19:22:02 -0700 Subject: [PATCH 18/19] Changed type attribute in privateendpointdnszonegroupget --- .../2020-03-01/examples/PrivateEndpointDnsZoneGroupGet.json | 1 - 1 file changed, 1 deletion(-) diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointDnsZoneGroupGet.json b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointDnsZoneGroupGet.json index b535d8956fbd..316ad45471c0 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointDnsZoneGroupGet.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointDnsZoneGroupGet.json @@ -11,7 +11,6 @@ "body": { "name": "testPdnsgroup", "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/privateLinkServices/testPe/privateDnsZoneGroups/testPdnsgroup", - "type": "Microsoft.Network/privateEndpoints/privateDnsZoneGroups", "properties": { "provisioningState": "Succeeded", "privateDnsZoneConfigs": [ From 746014c57340a11ad0aa6ca220d83eba08181223 Mon Sep 17 00:00:00 2001 From: Shane Baden Date: Mon, 30 Mar 2020 23:44:37 -0700 Subject: [PATCH 19/19] Added read only attribute to record set array --- .../Microsoft.Network/stable/2020-03-01/privateEndpoint.json | 1 + 1 file changed, 1 insertion(+) diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json index 55c0d68b7c04..4a14e3c84031 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/privateEndpoint.json @@ -917,6 +917,7 @@ }, "recordSets": { "type": "array", + "readOnly": true, "items": { "$ref": "#/definitions/RecordSet" },