Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMQP Support #14907

Closed
AlexGhiondea opened this issue Jun 24, 2021 · 5 comments
Closed

AMQP Support #14907

AlexGhiondea opened this issue Jun 24, 2021 · 5 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved. Service Bus
Milestone

Comments

@AlexGhiondea
Copy link

No description provided.

@AlexGhiondea AlexGhiondea added Client This issue points to a problem in the data-plane of the library. Service Bus labels Jun 24, 2021
@AlexGhiondea AlexGhiondea added this to the [2022] January milestone Jun 24, 2021
@RickWinter RickWinter changed the title [Go]AMQP for Go SDK AMQP for Go SDK Jun 30, 2021
@RickWinter RickWinter changed the title AMQP for Go SDK AMQP Support Jun 30, 2021
@richardpark-msft
Copy link
Member

richardpark-msft commented Jul 22, 2021

Note, want to discuss adding in a 'add a fixed number of credits' to a link. It appears that go-amqp today only allows you to set a rolling window of credits, which makes some track 2 scenarios (like receiveMessages(5)) difficult to do properly.

Created two issues to track parts of this:

@richardpark-msft
Copy link
Member

Note, want to discuss adding in a 'add a fixed number of credits' to a link. It appears that go-amqp today only allows you to set a rolling window of credits, which makes some track 2 scenarios (like receiveMessages(5)) difficult to do properly.

Created two issues to track parts of this:

The 'manual credits' portion has been implemented now.

@richardpark-msft
Copy link
Member

Drain also implemented.

@RickWinter RickWinter added feature-request This issue requires a new behavior in the product in order be resolved. and removed Epic labels Oct 6, 2022
@RickWinter
Copy link
Member

@richardpark-msft @jhendrixMSFT Should this bug remain open? I'd prefer to track the issues in the go-amqp repo and track schedule with those issues in the project.

@richardpark-msft
Copy link
Member

We can close this, I think we've got our process down at this point, which is:

  • If issues are go-amqp specific, file there (which @jhendrixMSFT has been doing)
  • If issues cross repos file one in go-amqp for the feature, and one in azure-sdk-for-go for the actual implementation into azeventhubs or azservicebus.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved. Service Bus
Projects
None yet
Development

No branches or pull requests

4 participants