Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UUID is pseudo random #15180

Closed
pascaldekloe opened this issue Jul 28, 2021 · 3 comments
Closed

UUID is pseudo random #15180

pascaldekloe opened this issue Jul 28, 2021 · 3 comments
Assignees
@RickWinter
Labels
Azure.Core bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization.
Milestone
[2021] September

Comments

@pascaldekloe
Copy link

The UUIDs don't use a cryptographically randomised source. Not doing so breaks the specification.
@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Jul 28, 2021
@RickWinter RickWinter added Azure.Core bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. labels Jul 28, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jul 28, 2021
@RickWinter RickWinter removed the question The issue doesn't require a change to the product in order to be resolved. Most issues start as that label Jul 28, 2021
@RickWinter
Copy link
Member

Thank you for reporting this issue. We will make a fix available soon.

@RickWinter RickWinter self-assigned this Jul 28, 2021
@pascaldekloe
Copy link
Author

The cryptographic random source can encounter errors, so you'd need to either change the name or use another UUID version.

@jhendrixMSFT jhendrixMSFT mentioned this issue Aug 2, 2021
Merged
@RickWinter RickWinter added the blocking-release Blocks release label Aug 9, 2021
@ghost ghost added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Aug 9, 2021
@RickWinter RickWinter added this to the [2021] September milestone Aug 9, 2021
@RickWinter RickWinter removed needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team blocking-release Blocks release labels Aug 19, 2021
@pascaldekloe
Copy link
Author

Thank you @RickWinter. The changes look good.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@RickWinter RickWinter

Labels
Azure.Core bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Milestone
[2021] September
Development

No branches or pull requests
2 participants
@RickWinter @pascaldekloe