Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry policy should support retry-after-ms #22120

Closed
jhendrixMSFT opened this issue Dec 8, 2023 · 2 comments · Fixed by #22121
Closed

Retry policy should support retry-after-ms #22120

jhendrixMSFT opened this issue Dec 8, 2023 · 2 comments · Fixed by #22121
Assignees

Comments

@jhendrixMSFT
Copy link
Member

Provides sub-second retry granularity.

@jhendrixMSFT jhendrixMSFT self-assigned this Dec 8, 2023
@trrwilson
Copy link
Member

Thanks, @jhendrixMSFT ! Parity link dump for easy reference:

Each of those, in the language-specific implementations, handles the three retry headers in precedence order, most succinctly in JS:

const AllRetryAfterHeaders: string[] = ["retry-after-ms", "x-ms-retry-after-ms", RetryAfterHeader];

So our "spec" is effectively "if retry-after-ms is present, use that as units of milliseconds; otherwise, if x-ms-retry-after-ms is present, use that as units of milliseconds; otherwise, if retry-after is present, use that in units of whole seconds; otherwise, use standard backoff heuristics."

@jhendrixMSFT
Copy link
Member Author

Fix will be included in azcore@v1.9.1 which should go out week of 12/11.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants