Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AzCopy] Datalake SDK does not path escape path names when passed to NewDirectoryClient and NewFileClient methods. #22281

Closed
gapra-msft opened this issue Jan 22, 2024 · 1 comment · Fixed by #22308
Closed

[AzCopy] Datalake SDK does not path escape path names when passed to NewDirectoryClient and NewFileClient methods. #22281

gapra-msft opened this issue Jan 22, 2024 · 1 comment · Fixed by #22308
Assignees
@vibhansa-msft @tanyasethi-msft
Labels
AzDatalake bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. Data Lake Storage Gen2 Storage Storage Service (Queues, Blobs, Files)
Milestone
Storage-Feb-24

Comments

@gapra-msft
Copy link
Member

gapra-msft commented Jan 22, 2024 •
edited
Loading

Bug Report

  • import path of package in question .../storage/azdatalake
  • SDK version latest,
  • What happened?
    Create a directory called #,%,? in a HNS enabled account.
    Create a directory client from a filesystem client and perform operations that hit the blob endpoint and dfs endpoint on it.
    fsClient.NewDirectoryClient("#,%,?")

Any operations hitting blob endpoint will succeed.
Any operations hitting dfs endpoint will fail with invalid URL escape "%,?"

For the fix, please ensure the same is tested for methods like NewFileClient too.

  • What did you expect or want to happen?
    Hitting either the blob endpoint or the dfs endpoint should succeed.

  • How can we reproduce it?
    Instructions given above

  • Anything we should know about your environment.
    N/A

Related issue Azure/azure-storage-azcopy#2549
@github-actions github-actions bot added Client This issue points to a problem in the data-plane of the library. Data Lake Storage Gen2 needs-team-triage Workflow: This issue needs the team to triage. labels Jan 22, 2024
@jhendrixMSFT jhendrixMSFT removed the needs-team-triage Workflow: This issue needs the team to triage. label Jan 22, 2024
@vibhansa-msft vibhansa-msft added bug This issue requires a change to an existing behavior in the product in order to be resolved. AzDatalake labels Jan 23, 2024
@vibhansa-msft vibhansa-msft added this to the Storage-Jan-24 milestone Jan 23, 2024
@vibhansa-msft vibhansa-msft added the Storage Storage Service (Queues, Blobs, Files) label Jan 23, 2024
@gapra-msft
Copy link
Member Author

@tanyasethi-msft We had another report of the issue, using the # symbol, so I want to make sure it is covered in the test scenarios. Linking the issue below.

Azure/azure-storage-azcopy#2559

@vibhansa-msft vibhansa-msft linked a pull request Feb 1, 2024 that will close this issue
[AzDatalake] Path escape names to file and directory client #22308
Merged
5 tasks
@vibhansa-msft vibhansa-msft mentioned this issue Feb 1, 2024
Merged
5 tasks
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vibhansa-msft vibhansa-msft

@tanyasethi-msft tanyasethi-msft

Labels
AzDatalake bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. Data Lake Storage Gen2 Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
Storage-Feb-24
Development

Successfully merging a pull request may close this issue.

[AzDatalake] Path escape names to file and directory client Azure/azure-sdk-for-go
4 participants
@jhendrixMSFT @gapra-msft @vibhansa-msft @tanyasethi-msft