Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Go API Version Configuration in Swagger Spec Repository #3036

Closed
marstr opened this issue Oct 16, 2018 · 4 comments
Closed

Missing Go API Version Configuration in Swagger Spec Repository #3036

marstr opened this issue Oct 16, 2018 · 4 comments
Assignees
Labels
CodeGen Issues that relate to code generation feature-request This issue requires a new behavior in the product in order be resolved.

Comments

@marstr
Copy link
Member

marstr commented Oct 16, 2018

Swagger to SDK for Go relies on AutoRest batch mode to generate all of the Go bits. However, when new API Versions are added the Go configuration often goes stale. In order to provide a more consistent experience between Go and other languages, we should either:

  • Abandon the current approach of relying on batch
  • Build tooling to detect when Go config has gone stale so that we can update it.
@marstr
Copy link
Member Author

marstr commented Oct 19, 2018

@bsiegel, we're talking about this at Go triage, and are sorta wanting to sit on it until we understand if there are big changes coming to the way that Swagger-To-SDK works. Think this work makes sense to start on now, or should we wait?

@bsiegel
Copy link
Member

bsiegel commented Oct 19, 2018

@marstr I think the approach I'm going to take is to have a configuration file or script file in each language repo which codifies:

  • The version of autorest to use
  • The correct flags and all other needed parameters to run autorest for the language
  • The set of actions to take after running autorest

As the language SDK maintainers, please feel free to construct the process you want/need, including the mode used for autorest and any post-autorest actions (which I gather is what the "tooling" above is meant to be). We can work later to make sure the SDK build service follows that process.

@ArcturusZhang ArcturusZhang added CodeGen Issues that relate to code generation feature-request This issue requires a new behavior in the product in order be resolved. labels Apr 27, 2020
@RickWinter RickWinter added this to the Backlog milestone Jul 12, 2021
@chamons
Copy link
Contributor

chamons commented Jul 22, 2021

I believe this (or at least part of this) will be solved by moving to autorest.md files and supporting the existing _meta.json files with #15111.

We are latest and latest -1 (16 & 15 right now).

@RickWinter
Copy link
Member

This is part of the Swagger->SDK work which is not being done

@RickWinter RickWinter modified the milestones: Backlog, [2021] September Dec 29, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CodeGen Issues that relate to code generation feature-request This issue requires a new behavior in the product in order be resolved.
Projects
None yet
Development

No branches or pull requests

5 participants