Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQ] Add support for AZURE_CLIENT_ID environment variable to ManagedIdentityCredential #10372

Closed
jongio opened this issue Apr 20, 2020 · 8 comments
Assignees
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.

Comments

@jongio
Copy link
Member

jongio commented Apr 20, 2020

Library or service name.
Azure Identity

Is your feature request related to a problem? Please describe.
Developers need to be able to specify which AZURE_CLIENT_ID Managed Identity Credential with an environment variable.

#5967
#7117

@joshfree joshfree added Azure.Identity Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved. labels Apr 20, 2020
@joshfree joshfree added this to the [2020] June milestone Apr 20, 2020
@jongio
Copy link
Member Author

jongio commented May 2, 2020

Please follow up with @schaabs before implementing.

@joshfree joshfree modified the milestones: [2020] June, [2020] August Jul 16, 2020
@joshfree joshfree added the blocking-release Blocks release label Jul 16, 2020
@joshfree
Copy link
Member

@jianghaolu @g2vinay please take a look this week and follow up.

@jongio
Copy link
Member Author

jongio commented Jul 16, 2020

@schaabs - Had a comment about potentially not supporting this as an ENV, so please do sync with him. Thanks a lot, Jon

@g2vinay
Copy link
Member

g2vinay commented Jul 16, 2020

yeah, from the discussion which happened last.
The stance was to limit the use of environment variables outside Environment credential as much as possible.

@jongio
Copy link
Member Author

jongio commented Jul 16, 2020

I personally think we should support AZURE_CLIENT_ID env var for Managed Identity as I have 2 customer cases where they could have used it, but had to manually set it. They thought the env var would work because they used it in other Credentials, but it didn't. They wasted time researching and then more time coding a solution around it.

The customer benefit is worth the effort IMO.

@jianghaolu
Copy link
Contributor

I agree. Also we already rely on environment variables elsewhere like SharedTokenCacheCredential. Supporting this environment variable allows many users to use DefaultAzureCredential with managed identities, instead of calling different credentials explicitly. This will make their code more maintainable, with better logging we are adding, and more secure.

@joshfree
Copy link
Member

We discussed this offline today and will be moving this to next semester.

@joshfree joshfree removed the blocking-release Blocks release label Jul 22, 2020
@g2vinay
Copy link
Member

g2vinay commented Sep 21, 2020

Closing this issue,
as we had discussed to MI client id setter on DAC and not add this env var across all languages.

@g2vinay g2vinay closed this as completed Sep 21, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
None yet
Development

No branches or pull requests

4 participants