Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate aad.group.enable-full-list, use aad.group.allowed-group-ids=* instead #21983

Closed
backwind1233 opened this issue Jun 1, 2021 · 0 comments · Fixed by #21427, #22141 or #22199
Closed

Deprecate aad.group.enable-full-list, use aad.group.allowed-group-ids=* instead #21983

backwind1233 opened this issue Jun 1, 2021 · 0 comments · Fixed by #21427, #22141 or #22199
Assignees
@backwind1233 @chenrujun
Labels
azure-spring All azure-spring related issues
Milestone
[2021] July

Comments

@backwind1233
Copy link
Contributor

backwind1233 commented Jun 1, 2021 •
edited by chenrujun
Loading

the aad group configuration

aad:
   group:
     allowed-group-names: group-name-1, group-name-2
     allowed-group-ids: id1
     enable-full-list: false

the name of enable-full-list may be confused for users, since if the value is true, it will ingnore allowed-group-names.

Here is new design:

  1. Deprecate enable-full-list.
  2. Use allowed-group-ids = all to implement function of enable-full-list.
  3. Let allowed-group-ids = all can work together with allowed-group-names.

#20218 (comment)
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 1, 2021
@backwind1233 backwind1233 self-assigned this Jun 1, 2021
@backwind1233 backwind1233 added the azure-spring All azure-spring related issues label Jun 1, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 1, 2021
@backwind1233 backwind1233 added this to the [2021] July milestone Jun 1, 2021
@backwind1233 backwind1233 mentioned this issue Jun 1, 2021
Merged
@backwind1233 backwind1233 linked a pull request Jun 1, 2021 that will close this issue
update changelog #21427
Merged
@chenrujun chenrujun changed the title change parameter name in AAD group configuration Deprecate aad.group.enable-full-list Jun 1, 2021
@chenrujun chenrujun changed the title Deprecate aad.group.enable-full-list Deprecate aad.group.enable-full-list, use aad.group.allowed-group-ids=* instead Jun 1, 2021
@chenrujun chenrujun self-assigned this Jun 1, 2021
@chenrujun chenrujun reopened this Jun 1, 2021
@ZhuXiaoBing-cn ZhuXiaoBing-cn mentioned this issue Jun 8, 2021
Merged
This was linked to pull requests Jun 10, 2021
Deprecate aad.group.enable-full-list. #22141
Merged
Modify the aad user group related readme. #22199
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@backwind1233 backwind1233

@chenrujun chenrujun

Labels
azure-spring All azure-spring related issues
Projects
None yet
Milestone
[2021] July
2 participants
@backwind1233 @chenrujun