Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages should only be released if they will install successfully #23158

Closed
danieljurek opened this issue Jul 23, 2021 · 1 comment · Fixed by #23726
Closed

Packages should only be released if they will install successfully #23158

danieljurek opened this issue Jul 23, 2021 · 1 comment · Fixed by #23726
Assignees
Labels
Central-EngSys This issue is owned by the Engineering System team.

Comments

@danieljurek
Copy link
Member

This may already be satisfied by: https://github.com/Azure/azure-sdk-for-java/blob/main/eng/versioning/scan_for_unreleased_dependencies.ps1

We could perhaps do other sanity checking as well, for example installing the package in isolation where Maven must resolve dependencies from external sources instead of using the source repo. However the delays present in publishing to Maven Central may make this less likely.

Alternatively we could sanity test by publishing a package that is about to be released to a private feed and then attempting to install the package from that private feed with Maven as a backup. In that case an unreleased dependency in the same service should cause a dependency resolution error. Private feeds would need to be cleaned up.

@danieljurek danieljurek added the Central-EngSys This issue is owned by the Engineering System team. label Jul 23, 2021
@alzimmermsft
Copy link
Member

Related to #15894

@ckairen ckairen linked a pull request Aug 23, 2021 that will close this issue
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants