Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix integration test error in AADWebApiOboIT. #23170

Closed
chenrujun opened this issue Jul 26, 2021 · 2 comments
Closed

[BUG] Fix integration test error in AADWebApiOboIT. #23170

chenrujun opened this issue Jul 26, 2021 · 2 comments
Assignees
Labels
azure-spring All azure-spring related issues azure-spring-aad Spring active directory related issues.

Comments

@chenrujun
Copy link

For Azure China, the scope of graph should be https://microsoftgraph.chinacloudapi.cn/User.Read.
But in current integration test, it's https://graph.microsoft.com/User.Read.

An email MSAL is not supported in National Clouds today, so AADWebApiOboIT should failed after updated to https://microsoftgraph.chinacloudapi.cn/User.Read.

Refs:

  1. Azure China:
    image
  2. https://github.com/Azure/azure-sdk-for-java/blob/azure-spring-boot_3.7.0/sdk/spring/azure-spring-boot-test-aad-webapp-and-resource-server-with-obo/src/test/java/com/azure/test/aad/webapi/obo/AADWebApiOboIT.java#L51
  3. Email ADAL to MSAL not supported in National Clouds.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jul 26, 2021
@chenrujun chenrujun self-assigned this Jul 26, 2021
@chenrujun chenrujun added azure-spring All azure-spring related issues azure-spring-aad Spring active directory related issues. labels Jul 26, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jul 26, 2021
@chenrujun chenrujun added this to the Backlog milestone Jul 26, 2021
@stliu stliu modified the milestones: Backlog, [2021] September Aug 6, 2021
@chenrujun
Copy link
Author

Putting off this task because @zhichengliu12581 is busy with other tasks, and this task does not have high priority.

@chenrujun
Copy link
Author

Closing this issue, because AAD related integration tests have already been deleted in version 4.0.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
azure-spring All azure-spring related issues azure-spring-aad Spring active directory related issues.
Projects
None yet
Development

No branches or pull requests

3 participants