Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQ] Redesign azure-spring-boot-starter-keyvault-certificates #23483

Closed
chenrujun opened this issue Aug 11, 2021 · 2 comments
Closed

[FEATURE REQ] Redesign azure-spring-boot-starter-keyvault-certificates #23483

chenrujun opened this issue Aug 11, 2021 · 2 comments
Assignees
@chenrujun
Labels
azure-spring All azure-spring related issues azure-spring-jca azure-spring-keyvault Spring keyvault related issues. Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Milestone
Backlog

Comments

@chenrujun
Copy link

chenrujun commented Aug 11, 2021 •
edited
Loading

Context

  • azure-spring-boot-starter-keyvault-certificates should depends on azure-security-keyvault-certificates instead of azure-security-keyvault-jca.

    1. azure-security-keyvault-certificates belongs to sdk.
    2. azure-security-keyvault-jca belongs to jca, it's not a part of sdk.
    3. azure-spring-boot-starter-keyvault-certificates should autoconfigure certificate client.
    4. There are some common logics in azure-security-keyvault-certificates, such as setting http head, retry policy. We should use this logic instead of adding this kind of logic in azure-security-keyvault-jca.

Problem

azure-spring-boot-starter-keyvault-certificates is not well-designed

Goal

Re-design azure-spring-boot-starter-keyvault-certificates, Make it support these features:

  • Support HTTPS connection by certificate without jca.
  • Support jetty
  • Support webflux https
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 11, 2021
@chenrujun chenrujun self-assigned this Aug 11, 2021
@chenrujun chenrujun added azure-spring All azure-spring related issues azure-spring-jca azure-spring-keyvault Spring keyvault related issues. labels Aug 11, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 11, 2021
@chenrujun chenrujun added Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved. labels Aug 11, 2021
@chenrujun
Copy link
Author

Hi, @mnriem , @stliu ,
FYI. Tell me if you have any concerns about this issue.

@saragluna saragluna added this to the Backlog milestone Sep 17, 2021
@chenrujun chenrujun changed the title [FEATURE REQ] azure-spring-boot-starter-keyvault-certificates should depends on azure-security-keyvault-certificates [FEATURE REQ] Redesign azure-spring-boot-starter-keyvault-certificates Oct 12, 2021
@chenrujun chenrujun modified the milestones: Backlog, [2021] December Nov 23, 2021
@chenrujun chenrujun mentioned this issue Feb 7, 2022
Closed
@chenrujun
Copy link
Author

Closing in favor of #28243

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chenrujun chenrujun

Labels
azure-spring All azure-spring related issues azure-spring-jca azure-spring-keyvault Spring keyvault related issues. Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
Spring Cloud Azure
Archived in project
Milestone
Backlog
Development

No branches or pull requests
2 participants
@chenrujun @saragluna