Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the cosmos proxy configuration properties more clear #25690

Closed
moarychan opened this issue Nov 25, 2021 · 2 comments
Closed

Make the cosmos proxy configuration properties more clear #25690

moarychan opened this issue Nov 25, 2021 · 2 comments
Assignees
@moarychan
Labels
azure-spring All azure-spring related issues azure-spring-cosmos Spring cosmos related issues.
Milestone
Spring Cloud Azur...

Comments

@moarychan
Copy link
Member

Currently, the spring.cloud.azure.cosmos.proxy properties is not used for cosmos builder factory.

Should both GatewayConnection and ProxyProperties be used or a unified one, need further confirmation.

Expected behavior
Supported proxy configurations are available and clear.
@moarychan moarychan added azure-spring All azure-spring related issues azure-spring-cosmos Spring cosmos related issues. labels Nov 25, 2021
@moarychan moarychan added this to the Spring Cloud Azure 4.0 GA milestone Nov 25, 2021
@moarychan moarychan self-assigned this Nov 25, 2021
@saragluna
Copy link
Member

we should also try to make sure retry is picked up.

@saragluna saragluna mentioned this issue Nov 25, 2021
Closed
@moarychan moarychan mentioned this issue Dec 1, 2021
Merged
@saragluna
Copy link
Member

Closing in #25766.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@moarychan moarychan

Labels
azure-spring All azure-spring related issues azure-spring-cosmos Spring cosmos related issues.
Projects
Spring Cloud Azure
Archived in project
Milestone
Spring Cloud Azure 4.0 Beta3
Development

No branches or pull requests
2 participants
@moarychan @saragluna