From 5f6fa1e7cbd61bb7ed8b59b5bcb2aa3ae76ffcd2 Mon Sep 17 00:00:00 2001 From: Praveen Kuttappan Date: Tue, 29 Jun 2021 21:38:45 -0400 Subject: [PATCH 1/2] Disable release date check --- eng/common/scripts/Create-APIReview.ps1 | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/eng/common/scripts/Create-APIReview.ps1 b/eng/common/scripts/Create-APIReview.ps1 index 456d249c9c186..ce7ba9fd8fe51 100644 --- a/eng/common/scripts/Create-APIReview.ps1 +++ b/eng/common/scripts/Create-APIReview.ps1 @@ -121,10 +121,10 @@ if ($packages) # Ignore API review status for prerelease version Write-Host "Package version is not GA. Ignoring API view approval status" } - elseif (!$pkgInfo.ReleaseStatus -or $pkgInfo.ReleaseStatus -eq "Unreleased") - { - Write-Host "Release date is not set for current version in change log file for package. Ignoring API review approval status since package is not yet ready for release." - } + #elseif (!$pkgInfo.ReleaseStatus -or $pkgInfo.ReleaseStatus -eq "Unreleased") + #{ + # Write-Host "Release date is not set for current version in change log file for package. Ignoring API review approval status since package is not yet ready for release." + #} else { # Return error code if status code is 201 for new data plane package From ddf8f27b9ccf513f5cd664836c2a97912728be00 Mon Sep 17 00:00:00 2001 From: Praveen Kuttappan Date: Tue, 29 Jun 2021 22:53:31 -0400 Subject: [PATCH 2/2] Release check is not finding release date --- eng/common/scripts/Create-APIReview.ps1 | 8 ++++---- eng/common/scripts/Package-Properties.ps1 | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/eng/common/scripts/Create-APIReview.ps1 b/eng/common/scripts/Create-APIReview.ps1 index ce7ba9fd8fe51..456d249c9c186 100644 --- a/eng/common/scripts/Create-APIReview.ps1 +++ b/eng/common/scripts/Create-APIReview.ps1 @@ -121,10 +121,10 @@ if ($packages) # Ignore API review status for prerelease version Write-Host "Package version is not GA. Ignoring API view approval status" } - #elseif (!$pkgInfo.ReleaseStatus -or $pkgInfo.ReleaseStatus -eq "Unreleased") - #{ - # Write-Host "Release date is not set for current version in change log file for package. Ignoring API review approval status since package is not yet ready for release." - #} + elseif (!$pkgInfo.ReleaseStatus -or $pkgInfo.ReleaseStatus -eq "Unreleased") + { + Write-Host "Release date is not set for current version in change log file for package. Ignoring API review approval status since package is not yet ready for release." + } else { # Return error code if status code is 201 for new data plane package diff --git a/eng/common/scripts/Package-Properties.ps1 b/eng/common/scripts/Package-Properties.ps1 index e00ea7bb9eaf6..3bb1d6271b23a 100644 --- a/eng/common/scripts/Package-Properties.ps1 +++ b/eng/common/scripts/Package-Properties.ps1 @@ -51,7 +51,7 @@ class PackageProps $this.ChangeLogPath = Join-Path $directoryPath "CHANGELOG.md" # Get release date for current version and set in package property $changeLogEntry = Get-ChangeLogEntry -ChangeLogLocation $this.ChangeLogPath -VersionString $this.Version - if ($changeLogEntry -and !$changeLogEntry.ReleaseStatus) + if ($changeLogEntry -and $changeLogEntry.ReleaseStatus) { $this.ReleaseStatus = $changeLogEntry.ReleaseStatus.Trim().Trim("()") }