Add an azure-spring-cloud-core module #23787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saragluna
requested review from
alzimmermsft,
anuchandy,
backwind1233,
benbp,
chenrujun,
conniey,
danieljurek,
g2vinay,
jianghaolu,
JonathanGiles,
joshfree,
lmolkova,
michaelqi793,
moarychan,
pallavit,
samvaity,
srnagar,
stliu,
yiliuTo,
zhichengliu12581 and
ZhuXiaoBing-cn
as code owners
ghost
added
the
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
saragluna
force-pushed
the
xiada/common-framework
branch
from
22462dd to
834cf1d
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
saragluna
force-pushed
the
xiada/common-framework
branch
from
834cf1d to
de221bd
Compare
saragluna
force-pushed
the
xiada/common-framework
branch
from
de221bd to
ab25349
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
.../main/java/com/azure/spring/core/credential/descriptor/NamedKeyAuthenticationDescriptor.java
Outdated
Show resolved
Hide resolved
...ing/azure-spring-cloud-core/src/main/java/com/azure/spring/core/credential/package-info.java
Outdated
Show resolved
Hide resolved
...d-core/src/main/java/com/azure/spring/core/credential/resolver/AzureCredentialResolvers.java
Show resolved
Hide resolved
backwind1233
requested changes
Aug 30, 2021
...src/main/java/com/azure/spring/core/credential/resolver/AzureNamedKeyCredentialResolver.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/com/azure/spring/core/credential/resolver/AzureTokenCredentialResolver.java
Show resolved
Hide resolved
stliu
reviewed
Aug 31, 2021
| */ | ||
| public class BackoffProperties { | ||
|
|
||
| private long delay; |
There was a problem hiding this comment.
we should use wrapper class instead of primitive type, as a best practice, to avoid unexpected default value
There was a problem hiding this comment.
Got it, will modify in following PR.
stliu
approved these changes
Aug 31, 2021
10 tasks
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-java
that referenced
this pull request
May 4, 2023
Update Monitors_CreateOrUpdate_MaximumSet_Gen.json (Azure#23787) Remove managed identity from the example payload as those will be created by system automatically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/Azure/azure-sdk-for-java/wiki/Spring-Cloud-for-Azure-Core-design
To add a core module for all Spring artifacts.