Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add algorithms to EncryptionAlgorithm for Key Vault #11028

Closed
heaths opened this issue Sep 4, 2020 · 2 comments
Closed

Add algorithms to EncryptionAlgorithm for Key Vault #11028

heaths opened this issue Sep 4, 2020 · 2 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault

Comments

@heaths
Copy link
Member

heaths commented Sep 4, 2020

For Key Vault 7.2-preview, to EncryptionAlgorithm (in swagger, the KeyOperationsParameters model), add the following algorithms:

  • A128GCM
  • A192GCM
  • A256GCM
  • A128KW
  • A192KW
  • A256KW
  • A128CBC
  • A192CBC
  • A256CBC
  • A128CBCPAD
  • A192CBCPAD
  • A256CBCPAD

As many of these as possible should be supported locally without writing our own cryptography.

Also add the following properties:

  • Iv (model property: iv)
  • AdditionalAuthenticatedData (model property: aad)
  • Tag (model property: tag)

These will likely need to be in a new options type/parameter passed to Encrypt and Decrypt.

See the service version 7.1 -> 7.2-preview diff 🔒 for details.

@heaths heaths added Client This issue points to a problem in the data-plane of the library. KeyVault labels Sep 4, 2020
@heaths heaths added this to the [2020] October milestone Sep 4, 2020
@ramya-rao-a
Copy link
Contributor

@sadasant Can we split the above list to algorithms supported by the service vs the ones that need local implementation?
We can then log a separate issue for the former, target it sooner and keep this issue to do further investigation on the latter.

@sadasant
Copy link
Contributor

To avoid editing the description of this issue (it seemed rude to me), I made a new issue for the remote only changes: #11260, it's a copy of this one, without As many of these as possible should be supported locally without writing our own cryptography. in the description.

Since the goal is to have as many algorithms working locally as possible, I made another issue to investigate what algorithms, from all the algorithms that Key Vault Keys offer, can be implemented locally in Node 8: #11261 , and I gave it an estimate of 5.

I made another issue to implement the local algorithms in Key Vault Keys: #11262 , and I gave it an estimate of 3.

I'll close this issue and we can follow up in those three others.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Development

No branches or pull requests

3 participants