Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Service Bus][Event Hubs] Refactoring among event-hubs and service-bus, cleanup related to "Tracing for Send" #11687

Closed
HarshaNalluru opened this issue Oct 7, 2020 · 1 comment

Comments

@HarshaNalluru
Copy link
Member

HarshaNalluru commented Oct 7, 2020

Followup for #11651
Note for both Event Hubs & Service Bus for improvements and to make changes for both packages at once:

  • The name createMessageSpan() is slightly misleading as it may indicate that I can use it at any time when a message is involved. In reality, this method is tied to the "producer" kind, so is usable only when sending message.
  • Also, jsdoc for this method would be helpful
  • Why is config optional here? I would imagine that we would always have a ConnectionConfig
    • parentSpan is not a required parameter but feels primary, I believe that was the reason Chris made the config optional in event-hubs. We can make it the first param in both service-bus and event-hubs and make it required.
  • For EventHubs, allow "null" value in the parentSpan in TryAddOptions
  • ServiceBus cleanup
    • Now that we dont use the single send method from the MessageSender class anymore, it can be deleted. Same for sendMessages() method in the MessageSender class

Originally posted by @ramya-rao-a in #11651 (comment)

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 7, 2020
@HarshaNalluru HarshaNalluru changed the title [Service Bus] Refactoring among event-hubs and service-bus, cleanup related to "Tracing for Send" [Service Bus][Event Hubs] Refactoring among event-hubs and service-bus, cleanup related to "Tracing for Send" Oct 7, 2020
@YalinLi0312 YalinLi0312 added enhancement Event Hubs Service Bus and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Oct 7, 2020
@ramya-rao-a ramya-rao-a modified the milestones: [2020] November, Backlog Oct 7, 2020
Copy link

Hi @HarshaNalluru, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 20, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2024
@xirzec xirzec removed this from the Backlog milestone May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done
Status: Done
Development

No branches or pull requests

4 participants