Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node LTS support and testing #12588

Closed
xirzec opened this issue Nov 18, 2020 · 4 comments
Closed

Node LTS support and testing #12588

xirzec opened this issue Nov 18, 2020 · 4 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.

Comments

@xirzec
Copy link
Member

xirzec commented Nov 18, 2020

Today we have a guideline stating we must support all LTS versions of node.
(It's a little out of date, so I have a PR to fix that. )

We currently run most CI against a wide matrix from 8 to 14:

https://github.com/Azure/azure-sdk-for-js/blob/master/eng/pipelines/templates/jobs/archetype-sdk-client.yml

There are some irregularities we should think about:

  1. Node8 has been End of Life since the beginning of 2020, but we still test on it and code against it.
  2. cosmos only runs integration tests on Node8: https://github.com/Azure/azure-sdk-for-js/blob/master/eng/pipelines/templates/stages/cosmos-sdk-client.yml

It's unclear at this time when we should drop support for a particular Node version. It's also unclear what our guidance should be for running against smaller matrices. Cosmos' current configuration, for example, won't catch breaking changes in the latest Node version.

/cc @ramya-rao-a @bterlson @southpolesteve for thoughts.

@xirzec xirzec added the Client This issue points to a problem in the data-plane of the library. label Nov 18, 2020
@ghost
Copy link

ghost commented Nov 18, 2020

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @southpolesteve, @zfoster

@southpolesteve
Copy link
Contributor

I'm not sure why Cosmos only runs against Node 8. No issue from our side running the full matrix.

As much as I would like to drop Node 8 support in v4, our telemetry suggests that may not be wise. Talked with @bterlson this last week. Happy to share more over teams.

@ramya-rao-a ramya-rao-a added this to the Backlog milestone Nov 18, 2020
@ramya-rao-a ramya-rao-a added the EngSys This issue is impacting the engineering system. label Nov 18, 2020
@xirzec
Copy link
Member Author

xirzec commented Jun 16, 2021

@ramya-rao-a is this issue irrelevant now?

@ramya-rao-a
Copy link
Contributor

Yes, thanks @xirzec

The latest support policy clarifies our support for the different Node.js versions

#15647 removes Node.js 8 from our test matrix
#15787 updates the cosmos test runs to run on Node.js 10 instead of 8

For more on dropping Node.js 8, please see #7022

@xirzec xirzec removed this from the Backlog milestone May 17, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.
Projects
None yet
Development

No branches or pull requests

4 participants