Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Identity] Write mocked browser tests #14368

Closed
sadasant opened this issue Mar 18, 2021 · 2 comments
Closed

[Identity] Write mocked browser tests #14368

sadasant opened this issue Mar 18, 2021 · 2 comments
Assignees
@KarishmaGhiya
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.

Comments

@sadasant
Copy link
Contributor

While we have manual browser tests, we should be able to write mocked tests for the browser credentials. This will help us a lot to catch unintended bugs.
@sadasant sadasant added Client This issue points to a problem in the data-plane of the library. Azure.Identity labels Mar 18, 2021
@sadasant sadasant added this to the [2021] May milestone Mar 18, 2021
@sadasant sadasant self-assigned this Mar 18, 2021
@sadasant sadasant mentioned this issue Mar 22, 2021
Merged
@sadasant sadasant modified the milestones: [2021] May, [2021] June Apr 2, 2021
@sadasant sadasant modified the milestones: [2021] June, [2021] July May 12, 2021
@sadasant sadasant modified the milestones: [2021] August, Backlog Jul 6, 2021
@ramya-rao-a ramya-rao-a modified the milestones: Backlog, [2021] December Jul 27, 2021
@sadasant
Copy link
Contributor Author

sadasant commented Nov 9, 2021

I will be approaching this issue as part of my Browser improvements next year. Moving to the backlog.

@sadasant sadasant modified the milestones: [2021] December, Backlog Nov 9, 2021
@sadasant sadasant mentioned this issue Apr 2, 2022
Closed
@sadasant sadasant removed their assignment May 9, 2022
@github-actions GitHub Actions
Copy link

Hi @sadasant, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 18, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2024
@xirzec xirzec removed this from the Backlog milestone May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@KarishmaGhiya KarishmaGhiya

Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Identity] Two Playwright tests for the InteractiveBrowserCredential sadasant/azure-sdk-for-js
4 participants
@sadasant @xirzec @KarishmaGhiya @ramya-rao-a