-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Identity] [External] Availability of MSAL cache plugins #14381
Comments
External issue: AzureAD/microsoft-authentication-library-for-js#3335 |
Moved to July Milestone, since MSAL hasn’t released these changes. |
I tried using MSAL’s solution, but I’m finding one issue. I’ve reported it to the MSAL team: Regarding the verify persistence feature: AzureAD/microsoft-authentication-library-for-js@b6c2f67#diff-60b5051ec55723d810adab4252c24ed915131c5988e041932b038fa2a366fb2b More specifically, I’m using @azure/msal-node-extensions@1.0.0-alpha.7 When using this code from a Linux machine without UX nor X11, after the cache is verified as available, saving into the cache causes the error. I am not sure why, but it is not catching the following error: The code I’m using:
Meaning that the persistence appears to be available even though saving triggers the GnomeKeyringError. |
I’ve made a PR showcasing a change that does the fix for me: AzureAD/microsoft-authentication-library-for-js#3787 In the mean time, I’ll push this to the next milestone. |
Moving this to the backlog since it doesn’t add any functional benefit to our users and we won’t have time to get to it. |
Hi @sadasant, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support. |
As part of #14064, I'm determining whether a MSAL cache plugin is available by attempting a read. If the read throws, I fall back to storing the cache in a plain file, if the user has allowed this to be a possibility.
In .Net however, their cache plugins provide a specific method to confirm whether the persistence plugin is available. They call it
VerifyPersistence
and can be seen here: https://github.com/AzureAD/microsoft-authentication-extensions-for-dotnet/blob/master/docs/keyring_fallback_proposal.mdThe MSAL team is aware of this suggestion. This issue is to track whether the MSAL team decides to implement this, and if so, to clean up our code.
External issue: AzureAD/microsoft-authentication-library-for-js#3335
The text was updated successfully, but these errors were encountered: