Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Cosmos Samples Issue #15473

Closed
v-jiaodi opened this issue May 31, 2021 · 15 comments
Closed

Azure Cosmos Samples Issue #15473

v-jiaodi opened this issue May 31, 2021 · 15 comments
Assignees
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. Cosmos test-manual-pass

Comments

@v-jiaodi
Copy link
Member

v-jiaodi commented May 31, 2021

Section link

image

Reason:
The query result still includes the given item which the indexingDirective is exclude. Some details are as follows:

image

Section link

image

Reason:
Expecting an exception on this query due to the fact that it includes paths /metaData/* that have been excluded. But there is no problem with the query results. Some details are as follows:

image

@lilyjma , @ramya-rao-a , @meeraharidasa , @mayurid @southpolesteve and @jongio for notification.

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 31, 2021
@v-jiaodi v-jiaodi changed the title Azure Cosmos Samples issue Azure Cosmos Samples Issue May 31, 2021
@v-xuto v-xuto reopened this Jun 2, 2021
@v-xuto v-xuto added Client This issue points to a problem in the data-plane of the library. Cosmos needs-team-triage Workflow: This issue needs the team to triage. test-manual-pass and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Jun 2, 2021
@v-xuto
Copy link
Member

v-xuto commented Jul 6, 2021

@ramya-rao-a - Please help assign this issue to the corresponding member?

@ramya-rao-a
Copy link
Contributor

Thanks @v-xuto

@zfoster, Can you please review the recommended fixes above? If you agree, then @v-xuto can send a PR to fix them

@zfoster
Copy link
Contributor

zfoster commented Jul 8, 2021

I'll happily take a PR to fix them, I'm unsure on the issue in the first one but the latter 2 look pretty straightforward. I don't see the recommended fixes though, maybe it was edited?

@v-jiaodi
Copy link
Member Author

v-jiaodi commented Jul 9, 2021

@zfoster The first issue is similar to the second one. Create an item and set indexingDirective : "exclude", we can query the items. But We don't expect to find any item. Is there anything else I need to offer on the first issue?

Besides, we don't have the recommended fixes, just describing this issue.

@ramya-rao-a
Copy link
Contributor

Ah! sorry about the comment on recommended fixes in that case.

@zfoster What would your recommendation be?

@zfoster
Copy link
Contributor

zfoster commented Jul 9, 2021

I think we need to investigate why the first and second directives aren't behaving as expected, for the last issue I think we can fix whatever ts-node doesn't like

@ramya-rao-a ramya-rao-a added bug This issue requires a change to an existing behavior in the product in order to be resolved. and removed needs-team-triage Workflow: This issue needs the team to triage. labels Aug 18, 2021
@v-xuto
Copy link
Member

v-xuto commented Aug 26, 2021

@zfoster Do you have any progress on this issue?

@zfoster
Copy link
Contributor

zfoster commented Aug 26, 2021

Not yet, I don't have an ETA on this work at this time

@binarybamboo
Copy link

@zfoster
Hello, I want to deep dive into this issues to fix - will share my pull request later but any sharing on recommendations would be appreciated!

@binarybamboo
Copy link

Sharing my test result for 1 - from my investigation, #1 is not an SDK issue - @zfoster: would you confirm whether it is a really SDK bug or not?

  • detail results:
    Data from link

    SELECT COUNT(c.foodGroup) FROM c ORDER BY c.foodGroup ASC, c.manufactureName ASC

    The investigation was conducted with the query statement above, and the result values are as follows.

    1. Original OUTPUT)
      count:8620, time:518.41 RUs

    2. After adding 8 values with option 'Include' OUTPUT)
      count:8628, time:516.05 RUs

    3. After adding 10 values with option 'Exclude' OUTPUT)
      count:8638, time:516.810 RUs

According to the above results, indexing seems to continue even if the 'Exclusive' option is given.

@v-xuto
Copy link
Member

v-xuto commented Mar 15, 2022

@sajeetharan , @kushagraThapar , @simorenoh Is there any progress on this issue so far?

@sajeetharan
Copy link
Member

@v-xuto Not yet, Thanks for notifying again, We will investigate and update the progress here

@v-xuto
Copy link
Member

v-xuto commented Oct 14, 2022

@sajeetharan Is there any progress on this issue?

@v-xuto
Copy link
Member

v-xuto commented Mar 10, 2023

@sajeetharan , @v1k1 Is there any progress on this issue?

Copy link

Hi @v-jiaodi, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 15, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. Cosmos test-manual-pass
Projects
None yet
Development

No branches or pull requests

9 participants