Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some more unit tests for monitor query #17502

Closed
3 tasks done
KarishmaGhiya opened this issue Sep 7, 2021 · 0 comments · Fixed by #19490
Closed
3 tasks done

Add some more unit tests for monitor query #17502

KarishmaGhiya opened this issue Sep 7, 2021 · 0 comments · Fixed by #19490
Assignees
@KarishmaGhiya
Labels
Monitor Monitor, Monitor Ingestion, Monitor Query
Milestone
[2022] January

Comments

@KarishmaGhiya
Copy link
Member

KarishmaGhiya commented Sep 7, 2021 •
edited
Loading

  • Unit test or live test (whatever applicable) - For covering tests for the logic that compute status for failed or succeed or partial results for "LogQueryResultStatus"
    Notes: This is not applicable anymore since we return separate objects for each of these cases. See PR -
    update the error handling for Logs Query and Logs Query Batch #17965
  • Verify - Check if the empty duration string in timeInterval will return all results
    Notes: This is verified with one of the samples. Changed the duration to empty string and it returned all the
    results for that query.
  • Unit test - For logic conversion of timespan string to TimeInterval object
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 7, 2021
@KarishmaGhiya KarishmaGhiya self-assigned this Sep 7, 2021
@KarishmaGhiya KarishmaGhiya added this to the [2021] October milestone Sep 7, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 7, 2021
@KarishmaGhiya KarishmaGhiya mentioned this issue Sep 7, 2021
Merged
@KarishmaGhiya KarishmaGhiya changed the title Add some more tests for monitor query Add some more unit tests for monitor query Sep 30, 2021
@KarishmaGhiya KarishmaGhiya mentioned this issue Dec 21, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
@scottaddie scottaddie added Monitor Monitor, Monitor Ingestion, Monitor Query and removed Monitor - Query labels Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@KarishmaGhiya KarishmaGhiya

Labels
Monitor Monitor, Monitor Ingestion, Monitor Query
Projects
None yet
Milestone
[2022] January
Development

Successfully merging a pull request may close this issue.

update the unit-tests for TimeIntervalObject KarishmaGhiya/azure-sdk-for-js
3 participants
@KarishmaGhiya @scottaddie @ramya-rao-a