-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename KeyType and JsonWebKey to avoid conflicts with predefined types #17710
Comments
I feel like this is, similar to a new lint check, finding a problem that we have today. I would prefer to never shadow a global type in the runtime environments we support if we can avoid it. That said, it's not hard for consumers to alias our poor names to something unambiguous. |
Before taking this up, I would be curious to do a sweep across all our packages and collect other such references to get an idea of the extent of this problem |
Just a note that this and #17721 are very closely related - in JS's case there's no serialization really and the only difference between our |
Hi @maorleger, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support. |
When upgrading API Extractor we noticed that KeyType and JsonWebKey defined in KV Keys conflict with the same names in dom.lib.ts which causes them to be renamed as
KeyType_2
andJsonWebKey_2
in the API view.To avoid this conflict, we can rename them locally but still export the conflicted name as deprecated alias.
Open questions:
KnownKeyTypes
? Rename them as well?Created as a result of https://github.com/Azure/azure-sdk-for-js/pull/17702/files#r709589284
The text was updated successfully, but these errors were encountered: