Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for using AAD with search-documents #18576

Closed
ramya-rao-a opened this issue Nov 8, 2021 · 1 comment
Closed

Tests for using AAD with search-documents #18576

ramya-rao-a opened this issue Nov 8, 2021 · 1 comment
Assignees
@dgetu
Labels
Client This issue points to a problem in the data-plane of the library. Search

Comments

@ramya-rao-a
Copy link
Contributor

The support for auth via AAD was added to @azure/search-documents was added in version 11.3.0-beta.1 in July this year, but there are no tests for this. This issue is to track the work to add some test coverage to this feature
@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. Search labels Nov 8, 2021
@ramya-rao-a ramya-rao-a added this to the [2022] January milestone Nov 8, 2021
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this issue Apr 20, 2022
@JackTn @gk-ms
@Khushboo-Baheti @Nilambari @nimaller @pr-work @matyang22 @utbarn-ms @thebenwaters @Satya-anshu @bewaterspassover @bewatersmsft
CodeGen from PR 18440 in Azure/azure-rest-api-specs
68bc986 
Azure Networking 2021-08-01 release of monthly branch (Azure#18440)

* Adds base for updating Microsoft.Network from version stable/2021-05-01 to version 2021-08-01

* Updates readme

* Updates API version in new specs and examples

* Add AppGw swagger changes for L4 proxy (Azure#17561)

* Add AppGw swagger changes for L4 proxy

* Fix Lint Errors

* fix prettier checks

* HubRoutingPreference in VirtualHub (Azure#17609)

* commit1

* commit2

Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>

* MultipleApipa feature VpnSiteLinkConnection and  VirtualNetworkGatewayConnection (Azure#17672)

* VngConnection

* VpnSiteLinkConnection

* fixes

* fixes

* fix2

* fixes

Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>

* Virtual Wan P2S MultiPool feature swagger changes (Azure#17620)

* Virtual Wan P2S MultiPool feature swagger changes

* Fix Swagger LintDiff errors

* Fix LintDiff errors

* Fix errors

* Fix spec

* Fix spec

* Fix spec

* Fix LintDiff errors

* Fix LintDiff errors

* Fix SDK azure-sdk-for-net generation error

* Remove suppression

* Fix errors

* Fix Lintdiff error

* Fix PrettierCheck

* changes (Azure#18002)

* Revert "changes (Azure#18002)" (Azure#18014)

This reverts commit 320ed6a6fc5a68e8af43da303f8e1caaacf24708.

* Add nic auxiliary mode (Azure#17577)

* Add nic auxiliary mode

* fix spacing

* Fixing prettier check

* Restoring package-lock file

* Restoring package json

Co-authored-by: Prachi Bhavsar <prbhavsar@microsoft.com>

* Connection Draining add new properties (Azure#18052)

* merge

* fix

* fix

* Adding express route port authorization apis (Azure#17582)

* adding apis and updating resource to support ports auth

* moving change to 2021-08-01

* minor: removing change from 2020-07-01

* lintdiff : adding type object

* minor: fixing prettier

* adding authorizations to ports property

* fixing circuitResourceUri property name

* fixing model validation

* changing circuit resource uri type to string

* removing authorizations child reosurce from parent property

* Fix Azure Firewall Policy regressions. Back fix validation issues (Azure#18233)

* Fix regressions in Firewall Policy Swagger / give firewallPolicy.json some love

* Additional lint violations

* remove breaking changes for next time. TO DO

* Revert "remove breaking changes for next time. TO DO"

This reverts commit 8f44a174c73c02d18d829f6dfb1d990488770b23.

* Reintroduce api-version for idps signature based routes. Create better names for enums to be generated in SDKs

* standardize enum names with FirewallPolicy prefix

* Azure Firewall Support of Private IP Ranges in IDPS (Azure#18320)

* Azure Firewall Support of Private IP Ranges in IDPS

* make sure all arrays have x-ms-identifiers

* FirewallPolicy not Firewall policy

fix spellcheck validation

* Ability to update tags on firewall policies (Azure#18322)

* Support updating of Azure Firewall Policy Tags. Includes HTTP Patch example

* Use common-types ErrorDetail

* Ability to update tags for Firewall Policies

* spell check fix for firewallpolicy

* Use future release api-version for example

* Added flush conn to nsg (Azure#18393)

* Added flush conn to nsg

* Updated flushConn to correct location

* Updated description

* Modified T/F to Enabled/Disabled

* Refactoring so that null value appears first

* Reverted FlushConnection to boolean value instead of string

* Revert "Added flush conn to nsg (Azure#18393)" (Azure#18576)

This reverts commit 6541d305880d1cf580496adc01f55197a01e992c.

* Fixing typo in response of idps private ip range feature (Azure#18574)

* Use common-type api version (Azure#18729)

Co-authored-by: Ben Eshed <bewaters@microsoft.com>

* fix (Azure#18417)

Co-authored-by: Tianen <347142915@qq.com>
Co-authored-by: gk-ms <97893166+gk-ms@users.noreply.github.com>
Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com>
Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>
Co-authored-by: Nilambari <nilamd@microsoft.com>
Co-authored-by: nimaller <71352534+nimaller@users.noreply.github.com>
Co-authored-by: pracsb <78512712+pr-work@users.noreply.github.com>
Co-authored-by: Prachi Bhavsar <prbhavsar@microsoft.com>
Co-authored-by: Matthew Yang <79727592+matyang22@users.noreply.github.com>
Co-authored-by: utbarn-ms <66377251+utbarn-ms@users.noreply.github.com>
Co-authored-by: Ben Eshed <thebenwaters@users.noreply.github.com>
Co-authored-by: Satya-anshu <70507845+Satya-anshu@users.noreply.github.com>
Co-authored-by: bewaterspassover <103988461+bewaterspassover@users.noreply.github.com>
Co-authored-by: Ben Eshed <bewaters@microsoft.com>
@xirzec xirzec modified the milestones: [2022] February, [2022] June May 17, 2022
@xirzec xirzec modified the milestones: [2022] June, [2022] July Jun 13, 2022
@xirzec xirzec modified the milestones: 2022-07, 2022-08 Jul 8, 2022
@xirzec xirzec modified the milestones: 2022-08, 2022-09 Aug 9, 2022
@sarangan12 sarangan12 assigned dgetu and unassigned sarangan12 Oct 12, 2022
@xirzec xirzec modified the milestones: 2022-09, 2022-12 Nov 1, 2022
@xirzec xirzec modified the milestones: 2022-12, 2023-02 Jan 11, 2023
@xirzec xirzec removed this from the 2023-02 milestone Mar 31, 2023
@github-actions GitHub Actions
Copy link

Hi @ramya-rao-a, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 13, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dgetu dgetu

Labels
Client This issue points to a problem in the data-plane of the library. Search
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sarangan12 @xirzec @dgetu @ramya-rao-a