Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Event Hubs] Update tsconfig to comply with guidelines #2655

Closed
ramya-rao-a opened this issue May 2, 2019 · 4 comments
Closed

[Event Hubs] Update tsconfig to comply with guidelines #2655

ramya-rao-a opened this issue May 2, 2019 · 4 comments
Assignees
@ShivangiReja
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Milestone
Sprint 152

Comments

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented May 2, 2019 •
edited
Loading

As per the Typescript guidelines, we are missing the below in tsconfig.json files of all our messaging libraries (Service Bus, Event Hubs, EPH)

  • "forceConsistentCasingInFileNames": true
  • "isolatedModules": true

Make the change, ensure build runs without issues before submitting the PR
@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. Event Hubs labels May 2, 2019
@AlexGhiondea AlexGhiondea mentioned this issue May 6, 2019
Closed
16 tasks
@ramya-rao-a ramya-rao-a added this to the Sprint 152 milestone May 7, 2019
@ShivangiReja
Copy link
Member

ShivangiReja commented May 7, 2019 •
edited
Loading

  • "forceConsistentCasingInFileNames": true is already present in all our messaging libraries (Service Bus, Event Hubs, EPH)
  • when we include "isolatedModules": true, I see this error:

image

Related issue: microsoft/TypeScript#29490

@ramya-rao-a
Copy link
Contributor Author

@bterlson We clearly cannot remove the declaration: true as we want to generate d.ts files
If isolatedModules cannot be enabled along with declaration, can we remove the need for the former from the guidelines?

@ramya-rao-a ramya-rao-a assigned bterlson and ShivangiReja and unassigned bterlson May 7, 2019
@bterlson
Copy link
Member

bterlson commented May 9, 2019

Yep, will remove. Feel free to file a bug.

(I swear it didn't work this way months ago when I tried it)

@ramya-rao-a ramya-rao-a mentioned this issue May 9, 2019
Closed
@ramya-rao-a
Copy link
Contributor Author

Logged bug Azure/azure-sdk#360

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ShivangiReja ShivangiReja

Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Projects
None yet
Milestone
Sprint 152
Development

No branches or pull requests
3 participants
@bterlson @ramya-rao-a @ShivangiReja