Improve performance of uploading file to block blob: use fs.stat() instead of fs.statSync()

[rabinovichor]

• Package Name:
  @azure/storage-blob
• Package Version:
  10.4.1
• Operating system:
  macOs
• nodejs
  • version:
    v12.5.0
• browser
  • name/version:
    Chrome 76 on macOS (Mojave)
• typescript
  • version:
    3.2.2
• Is the bug related to documentation in
  • README.md
  • source code documentation
  • [yes] SDK API docs on https://docs.microsoft.com

Describe the bug
File Name: highlevel.node.ts
** Function :** uploadFileToBlockBlob : 39

Before uploading the file, you are using 'fs.statSync' in order to get the size of the file, probably to use it has Content-Length.
The use of a synchronous function is severe, certainly with the use of Promises.

Once you adopt Promises pattern for writing asynchronous code but still using dependency with synchronous functions, you can cause the main thread to be block. (for example using Promises.all).

To Reproduce
Steps to reproduce the behavior:
1.

Expected behavior
Use 'fs.stat' instead of 'fs.statSync' and use await within the function.
When you await a promise, the function is paused in a non-blocking way until the promise settles.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

[bterlson]

Thanks for the report @orrabinovich88 (and welcome to GitHub!! 😄). Preferring async over sync for these built-ins makes sense.

Curious, did you notice some slowness or blocking of main thread in your application? If so can you quantify how much/how bad it was?

[rabinovichor]

Hi @bterlson, and thanks for the quick reply!

Yes, once you work with a huge amount of files that are processed together, you will feel the difference with no doubt, and that's exactly what i'm doing at my job :).

Moreover Node actually do not recommend using this function anymore.
Thanks.

[XiaoningLiu]

Definitly we should use async operations, thanks for heading up!
At the same time, welcome contribution!

[ghost]

Thanks for working with Microsoft on GitHub! Tell us how you feel about your experience using the reactions on this comment.