Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Cannot run "npm install" in samples as instructed in README #5080

Closed
mikeharder opened this issue Sep 10, 2019 · 4 comments
Closed
Assignees
Labels
Storage Storage Service (Queues, Blobs, Files)

Comments

@mikeharder
Copy link
Member

The Storage samples README instructs users to run the following command:

npm install @azure/storage-blob@12.0.0-preview.3

However, this command fails when run in a clone of the full repo (using preview.2 since preview.3 was not published at the time of issue creation):

$ npm install @azure/storage-blob@12.0.0-preview.2
npm ERR! code ENOSELF
npm ERR! Refusing to install package with name "@azure/storage-blob" under a package
npm ERR! also called "@azure/storage-blob". Did you name your project the same
npm ERR! as the dependency you're installing?
@mikeharder mikeharder added the Storage Storage Service (Queues, Blobs, Files) label Sep 10, 2019
@HarshaNalluru
Copy link
Member

We will be releasing the preview 3 storage SDKs tomorrow.

@mikeharder
Copy link
Member Author

@HarshaNalluru: I don't think the issue is related to preview.2 vs preview.3. I think the root cause is npm will not allow the install of @azure/storage-blob under the sdk/storage/storage-blob/samples folder. It would work in a different folder not under sdk/storage/storage-blob.

@HarshaNalluru
Copy link
Member

HarshaNalluru commented Sep 10, 2019

Thanks, Mike. I guess I didn't read the whole message.

This can be avoided by having a dummy package.json in the samples folder or by adding "npm init -y" step in the samples/readme before npm install @azure/storage-blob@12.0.0-preview.2 step.

I'll create a PR for this.

@HarshaNalluru
Copy link
Member

#5134

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

No branches or pull requests

2 participants