Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage][Queue] rename MessagesClient dequeue() to receiveMessages() #5102

Closed
jeremymeng opened this issue Sep 11, 2019 · 5 comments
Closed
Assignees
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)

Comments

@jeremymeng
Copy link
Member

jeremymeng commented Sep 11, 2019

Since the current function doesn't remove the messages. See discussion at Azure/azure-sdk-for-java#4457

There's a field from the response named dequeueCount. If we rename the method, we'd also need a better name for that field and use autorest trasnformation to rename it.

We should go with

  • sendMessage()
  • receiveMessages()

result types for the four operations: Item

.NET has

Response SendMessage(…)
Response<QueueMessageItem[]> ReceiveMessages(…)
Response<PeekedMessageItem[]> PeekMessages(…)
Response UpdateMessage(…)
Response DeleteMessage(…)

we should go with these

edited: fix issue link

Edited: add review feedback

edited: consistency decision: use -Item suffix

@jeremymeng jeremymeng added Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files) labels Sep 11, 2019
@HarshaNalluru HarshaNalluru added the blocking-release Blocks release label Oct 10, 2019
@HarshaNalluru
Copy link
Member

sendMessage() and receiveMessages() is done as part of #5579

@HarshaNalluru
Copy link
Member

No autorest is involved. Easy to fix.

@HarshaNalluru
Copy link
Member

Doing it as part of #5590

@jeremymeng jeremymeng reopened this Oct 18, 2019
@jeremymeng jeremymeng self-assigned this Oct 18, 2019
@jeremymeng
Copy link
Member Author

Looks like we only need to rename result type of receiveMessages(). Other methods already have the good name on returned types/response and not returning/including Models types.

@ramya-rao-a
Copy link
Contributor

Completed with #5661 by @jeremymeng

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

No branches or pull requests

3 participants