Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KeyVault-Keys] The CryptographyClient should allow to be created with a KeyVaultKey #7140

Closed
1 task
sadasant opened this issue Jan 28, 2020 · 0 comments · Fixed by #9647
Closed
1 task

[KeyVault-Keys] The CryptographyClient should allow to be created with a KeyVaultKey #7140

sadasant opened this issue Jan 28, 2020 · 0 comments · Fixed by #9647
Assignees
@sadasant
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Milestone
[2020] July

Comments

@sadasant
Copy link
Contributor

sadasant commented Jan 28, 2020 •
edited
Loading

To facilitate local cryptography on other clients, the CryptographyClient should allow being created by a KeyVault-Key.

This is currently a supported feature, see the following code:

https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/keyvault/keyvault-keys/src/cryptographyClient.ts#L676-L680

However, we should write at least a test and a sample making sure that this fulfills the expected behavior.

Tasks:

  • Write a test and a sample.
@sadasant sadasant added Client This issue points to a problem in the data-plane of the library. KeyVault labels Jan 28, 2020
@sadasant sadasant self-assigned this Jan 28, 2020
@sadasant sadasant changed the title [KeyVault-Key] The CryptographyClient should allow to be created with a KeyVault-Key key [KeyVault-Key] The CryptographyClient should allow to be created with a KeyVaultKey Jan 28, 2020
@sadasant sadasant added this to the Sprint 165 milestone Jan 28, 2020
@sadasant sadasant mentioned this issue Jan 28, 2020
Closed
@sadasant sadasant modified the milestones: Sprint 165, [2020] March Jan 28, 2020
@sadasant sadasant changed the title [KeyVault-Key] The CryptographyClient should allow to be created with a KeyVaultKey [KeyVault-Keys] The CryptographyClient should allow to be created with a KeyVaultKey Feb 4, 2020
@sadasant sadasant mentioned this issue Feb 4, 2020
Closed
@heaths heaths mentioned this issue Feb 19, 2020
Closed
3 tasks
@sadasant sadasant modified the milestones: [2020] March, [2020] April Feb 19, 2020
@sadasant sadasant modified the milestones: [2020] April, [2020] June Apr 2, 2020
@AlexGhiondea AlexGhiondea modified the milestones: [2020] June, [2020] July Apr 29, 2020
@sadasant sadasant mentioned this issue Jun 22, 2020
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sadasant sadasant

Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Milestone
[2020] July
Development

Successfully merging a pull request may close this issue.

[KeyVault-Keys] The CryptographyClient indeed works with a KeyVaultKey sadasant/azure-sdk-for-js
2 participants
@sadasant @AlexGhiondea