Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[formrecognizer] Handle "failed" status consistently across LROs #8927

Closed
jeremymeng opened this issue May 14, 2020 · 1 comment
Closed

[formrecognizer] Handle "failed" status consistently across LROs #8927

jeremymeng opened this issue May 14, 2020 · 1 comment
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer
Milestone

Comments

@jeremymeng
Copy link
Member

See: Azure/azure-sdk-for-net#11473 and Azure/azure-sdk-for-python#11323

We should consider having consistent behavior across all endpoints (always raise on a "failed" status) or decide if it makes sense to not throw exceptions specifically for training operations.

We don't raise on a "failed" status for training and instead return the model with errors. There are two errors lists on a model: top-level model errors and per-training document errors. If we do throw an exception here we need to figure out what should be raised.

Architect guidance

Throw exception if training method returns model with "invalid" status
Exception message should include model_id, along with message from service that explains why it failed
Include in documentation that a model is still created even if the training operation fails

@jeremymeng jeremymeng added Client This issue points to a problem in the data-plane of the library. FormRecognizer labels May 14, 2020
@jeremymeng jeremymeng added this to the [2020] June milestone May 14, 2020
@jeremymeng
Copy link
Member Author

This is done. Training now throw an error on invalid status, with error messages including information about the details of what documents have errors.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer
Projects
None yet
Development

No branches or pull requests

1 participant