Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[service-bus] Review dependency on "stream-browserify" #9283

Closed
mikeharder opened this issue Jun 4, 2020 · 0 comments · Fixed by #11221
Closed

[service-bus] Review dependency on "stream-browserify" #9283

mikeharder opened this issue Jun 4, 2020 · 0 comments · Fixed by #11221
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus

Comments

@mikeharder
Copy link
Member

mikeharder commented Jun 4, 2020

The package.json for @azure/service-bus contains this reference to stream-browserify, but does not have a runtime or dev dependency on the package:

"browser": {
"./dist-esm/src/util/crypto.js": "./dist-esm/src/util/crypto.browser.js",
"./dist-esm/src/util/parseUrl.js": "./dist-esm/src/util/parseUrl.browser.js",
"buffer": "buffer",
"stream": "stream-browserify"

I think either this reference should be removed or a dependency should be added.

Related: #9281, #9282

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants