Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Identity] Azure SDK credential built on msal-node #9778

Closed
2 tasks done
sophiajt opened this issue Jun 29, 2020 · 0 comments
Closed
2 tasks done

[Identity] Azure SDK credential built on msal-node #9778

sophiajt opened this issue Jun 29, 2020 · 0 comments
Assignees
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.

Comments

@sophiajt
Copy link
Contributor

sophiajt commented Jun 29, 2020

Current Status (2020/09/10)

We are now moved onto msal-node for the InteractiveBrowserCredential for Node and for DeviceCodeCredential.

Next steps:

Is your feature request related to a problem? Please describe.
When msal-node becomes available, we can leverage their new capabilities by moving Identity to use msal-node directly rather than using the hand-made credentials of the same type.

Describe the solution you'd like
The first credential we could use, once available, is the auth-code credential. Following the design of the Python Identity library, we could call into the user's browser, allowing them to login and request an auth code. Once the auth code is made available, it can be passed to msal-node for processing and caching.

As this matures, we can move to other capabilities, like durable caches, device-code, and more.

Note: we'll need to coordinate with MSAL on ensuring that the HTTP transport layer is pluggable, so that we can use the standard Azure SDK layer, which will allow uniformly-configured proxy, retry, logging, distributed tracing, and possibly more in the future.

Merging with a duplicate issue:

Currently Azure.Identity for JS does not have feature parity with Azure.Identity for .NET/Java/Python due to the unavailability of a supported version of MSAL for NodeJS.

This work item tracks catching JS up to feature parity using the beta MSAL for NodeJS

shipping a public preview of Azure.Identity for JS using the first public beta MSAL for NodeJS
Reviewing and unifying the usage of MSAL / MSAL Cache, per the work done last semester in the other 3 primary languages
Adding Azure Identity Support for MSAL Configurable Token Refresh
Adding UserAuthentication API
This work will be kept in a separate feature branch until MSAL for NodeJS reaches a supportable / go-live level of quality, at which point this work can merge back to master and ship GA.

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 29, 2020
@sophiajt sophiajt added the Client This issue points to a problem in the data-plane of the library. label Jun 29, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 29, 2020
@ramya-rao-a ramya-rao-a added this to the [2020] August milestone Jun 29, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

No branches or pull requests

2 participants