servicebus project changes for #11701 #11782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohsin-mehmood
requested review from
bterlson,
chradek,
HarshaNalluru,
ramya-rao-a,
richardpark-msft and
xirzec
as code owners
ghost
added
Service Bus
customer-reported
|
Thank you for your contribution mohsin-mehmood! We will review the pull request and get back to you soon. |
ramya-rao-a
reviewed
Oct 12, 2020
There was a problem hiding this comment.
Thanks for the PR @mohsin-mehmood!
I have left a few comments to get some thoughts from @HarshaNalluru and @richardpark-msft after which we can continue reviewing the PR
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
added 2 commits
October 15, 2020 22:35
ramya-rao-a
reviewed
Oct 15, 2020
sdk/servicebus/service-bus/src/serializers/ruleResourceSerializer.ts
Outdated
Show resolved
Hide resolved
ramya-rao-a
reviewed
Oct 15, 2020
Co-authored-by: Harsha Nalluru <sanallur@microsoft.com>
|
This looks amazing!
|
added 2 commits
October 16, 2020 02:42
ramya-rao-a
reviewed
Oct 15, 2020
Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com>
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ramya-rao-a
reviewed
Oct 16, 2020
sdk/servicebus/service-bus/src/serializers/ruleResourceSerializer.ts
Outdated
Show resolved
Hide resolved
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ramya-rao-a
approved these changes
Oct 16, 2020
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #11701