Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm-batch-release #16569

Merged
merged 3 commits into from
Aug 4, 2021
Merged

arm-batch-release #16569

merged 3 commits into from
Aug 4, 2021

Conversation

colawwj
Copy link
Contributor

@colawwj colawwj commented Jul 27, 2021

No description provided.

@ghost ghost added the Batch label Jul 27, 2021
@gingi
Copy link
Member

gingi commented Jul 29, 2021

Can we have BatchManagement renamed to BatchManagementService to ensure consistency across the SDKs? We have filed a PR in the specs repo to make this automatic during auto rest code generation.

@dpwatrous dpwatrous self-requested a review July 30, 2021 13:14
@qiaozha
Copy link
Member

qiaozha commented Jul 31, 2021

@gingi @dpwatrous there's previously manual added test being override in arm-batch package. https://github.com/Azure/azure-sdk-for-js/pull/16569/files#diff-bb4e4e90b1f429e5fd0ba4e07c146326309d9a7fe492eb56c05c38f12fa77eea Are you sure you want to remove it?

@gingi
Copy link
Member

gingi commented Aug 2, 2021

@gingi @dpwatrous there's previously manual added test being override in arm-batch package. https://github.com/Azure/azure-sdk-for-js/pull/16569/files#diff-bb4e4e90b1f429e5fd0ba4e07c146326309d9a7fe492eb56c05c38f12fa77eea Are you sure you want to remove it?

@qiaozha Good catch. Let's revert this deletion. The tests are presently defunct since they have been migrated from the old Node repo, but I'm in the process of updating the tests for the data plane off-band, and will work on these management tests as well. But in the meantime, the PR looks good and should be released.

@qiaozha
Copy link
Member

qiaozha commented Aug 4, 2021

merge and release this PR first. @gingi feel free to file another PR to add the test back

@qiaozha qiaozha merged commit 55e66cb into Azure:feature/v4 Aug 4, 2021
@gingi
Copy link
Member

gingi commented Aug 4, 2021

Thank you @qiaozha. I will.

@colawwj colawwj deleted the arm-batch-release branch October 11, 2021 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants