Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure.Search: Verify switching from "NaN" to NaN in dynamic scenarios #10601

Closed
tg-msft opened this issue Mar 13, 2020 · 2 comments · Fixed by #12610
Closed

Azure.Search: Verify switching from "NaN" to NaN in dynamic scenarios #10601

tg-msft opened this issue Mar 13, 2020 · 2 comments · Fixed by #12610
Assignees
@tg-msft
Labels
Client This issue points to a problem in the data-plane of the library. Search
Milestone
[2020] June

Comments

@tg-msft
Copy link
Member

tg-msft commented Mar 13, 2020

It looks like we're more aggressive than Track 1 here and we should double check that won't cause problems.
@tg-msft tg-msft added Client This issue points to a problem in the data-plane of the library. Search labels Mar 13, 2020
@tg-msft tg-msft self-assigned this Mar 13, 2020
@tg-msft tg-msft added this to the [2020] April milestone Mar 19, 2020
@tg-msft
Copy link
Member Author

tg-msft commented Mar 19, 2020

https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/search/Microsoft.Azure.Search/tests/Tests/LookupTests.cs#L321

vs

https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/search/Azure.Search.Documents/tests/DocumentOperations/GetDocumentTests.cs#L325

@tg-msft
Copy link
Member Author

tg-msft commented Mar 19, 2020

Keep as strings, use helpers to do parsing.

@tg-msft tg-msft modified the milestones: [2020] April, [2020] May Apr 6, 2020
@AlexGhiondea AlexGhiondea mentioned this issue Apr 8, 2020
Closed
26 tasks
@tg-msft tg-msft modified the milestones: [2020] May, [2020] June May 8, 2020
@AlexGhiondea AlexGhiondea mentioned this issue May 8, 2020
Closed
17 tasks
@tg-msft tg-msft mentioned this issue Jun 8, 2020
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tg-msft tg-msft

Labels
Client This issue points to a problem in the data-plane of the library. Search
Projects
None yet
Milestone
[2020] June
Development

Successfully merging a pull request may close this issue.

Fix SearchDocument tg-msft/azure-sdk-for-net
1 participant
@tg-msft