Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeGen] Move to .NET Code Gen LROs #11417

Closed
annelo-msft opened this issue Apr 17, 2020 · 2 comments
Closed

[CodeGen] Move to .NET Code Gen LROs #11417

annelo-msft opened this issue Apr 17, 2020 · 2 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer Cognitive Services
Milestone

Comments

@annelo-msft
Copy link
Member

annelo-msft commented Apr 17, 2020

Summary

Per @pakrym, the C# code generator creates Operation<T> subclasses automatically from swagger files. We'll want to understand the output and whether it can be used for the LROs in the FormRecognizer library.

Goals

  • Understand the LRO output from code generator
  • Determine whether existing FR LRO functionality can be implemented with only small changes to this output
  • If code gen LRO code can be used for FR, implement this
  • If code gen LRO code differs too much from the FR functionality, we should keep the hand-written Operation classes and close this issue.
@annelo-msft annelo-msft added Client This issue points to a problem in the data-plane of the library. Cognitive Services FormRecognizer labels Apr 17, 2020
@annelo-msft annelo-msft added this to the [2020] May milestone Apr 17, 2020
@kinelski kinelski modified the milestones: [2020] May, [2020] June May 6, 2020
@annelo-msft annelo-msft changed the title Move to .NET Code Gen LROs [CodeGen] Move to .NET Code Gen LROs May 7, 2020
@annelo-msft
Copy link
Member Author

Do these together: #11484

@pakrym
Copy link
Contributor

pakrym commented Jun 2, 2020

I think this is not valid anymore, when we moved to only generate rest clients for data-plane we stopped generating operations as well.

@AlexGhiondea AlexGhiondea modified the milestones: [2020] June, [2020] July Jun 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer Cognitive Services
Projects
None yet
Development

No branches or pull requests

4 participants