Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQ][Azure.Identity] AuthenticationRecord should expose its constructor as public #13828

Closed
erich-wang opened this issue Jul 30, 2020 · 2 comments · Fixed by #14769
Closed
Assignees
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. needs-team-triage Workflow: This issue needs the team to triage.

Comments

@erich-wang
Copy link
Member

Library or service name.
Azure.Identity

Is your feature request related to a problem? Please describe.
AuthenticationRecord should expose its constructor below as public:

        internal AuthenticationRecord(string username, string authority, string homeAccountId, string tenantId, string clientId)

In current Azure PowerShell, some properties in AuthenticationRecord is already persisted in context file with its own structure, so Azure.Identity should allow partners to chose their own way import/export AuthenticationRecord.

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jul 30, 2020
@jsquire jsquire added Azure.Identity Client This issue points to a problem in the data-plane of the library. needs-team-triage Workflow: This issue needs the team to triage. labels Jul 30, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jul 30, 2020
@AlexanderSher AlexanderSher removed their assignment Aug 25, 2020
@AlexanderSher AlexanderSher added this to the [2020] September milestone Aug 25, 2020
@schaabs
Copy link
Member

schaabs commented Sep 1, 2020

As we discussed offline we won't be adding a public constructor on AuthenticationRecord to avoid obscuring the intended usage. As a workaround you can use the IdentityModelFactory if you need to construct this type. We are adding IdentityModelFactory for mocking purposes in #14769.

@pakrym
Copy link
Contributor

pakrym commented Sep 1, 2020

This doesn't seem to be a mocking purpose though. Not sure if we should advertise model factories for non-test usages.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. needs-team-triage Workflow: This issue needs the team to triage.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants