Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing EntityNameFormatter #14008

Closed
JoshLove-msft opened this issue Aug 6, 2020 · 5 comments
Closed

Consider removing EntityNameFormatter #14008

JoshLove-msft opened this issue Aug 6, 2020 · 5 comments
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus

Comments

@JoshLove-msft
Copy link
Member

FormatTransferDeadletterQueue can be built into the CreateDeadLetterReceiver method by adding an optional param.

@JoshLove-msft JoshLove-msft added Service Bus Client This issue points to a problem in the data-plane of the library. labels Aug 6, 2020
@JoshLove-msft JoshLove-msft added this to the [2020] September milestone Aug 6, 2020
@SeanFeldman
Copy link
Contributor

Transactional dead-letter queue name should be considered as well.

@JoshLove-msft
Copy link
Member Author

Transactional dead-letter queue name should be considered as well.

Do you mean the transfer dead letter queue? That's what I was referring to when mentioning the FormatTransferDeadletterQueue method in the issue description.

@SeanFeldman
Copy link
Contributor

Yes, indeed.

@JoshLove-msft
Copy link
Member Author

Fixed in #14692

@quentinb-spindance
Copy link

Of note, this helper function (in its deprecated form inside the Microsoft.Azure.ServiceBus) lib is still referred to in DLQ examples1. This is a bit frustrating to track down, as now the official example of registering a ServiceBusTrigger on a DLQ is not possible.

Footnotes

  1. (See line 162) https://github.com/Azure/azure-sdk-for-net/blob/Azure.Messaging.ServiceBus_7.8.1/sdk/servicebus/Azure.Messaging.ServiceBus/samples/DeadLetterQueue/Program.cs

@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
None yet
Development

No branches or pull requests

3 participants