Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ChallengeBasedAuthenticationPolicy to Azure.Core #14389

Closed
heaths opened this issue Aug 19, 2020 · 3 comments
Closed

Move ChallengeBasedAuthenticationPolicy to Azure.Core #14389

heaths opened this issue Aug 19, 2020 · 3 comments
Assignees
@christothes
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. KeyVault
Milestone
Backlog

Comments

@heaths
Copy link
Member

heaths commented Aug 19, 2020

Copying much of the existing BearerTokenAuthenticationPolicy but instead parsing out the WWW-Authentication response header to issue a challenge, move the ChallengeBasedAuthenticationPolicy from Key Vault shared source to Azure.Core and make it public.

Relates to #12938, though I was unable to repro that with the change I already made in PR #10673.
@heaths heaths added KeyVault Client This issue points to a problem in the data-plane of the library. Azure.Core labels Aug 19, 2020
@heaths heaths added this to the [2020] September milestone Aug 19, 2020
@heaths
Copy link
Member Author

heaths commented Sep 14, 2020

@schaabs do you already have another bug tracking this?

@pakrym pakrym modified the milestones: [2020] October, [2020] November Oct 2, 2020
@jsquire jsquire modified the milestones: [2021] January, Backlog Dec 7, 2020
@christothes
Copy link
Member

After #18368 merges, I have a branch that refactors ChallengeBasedAuthenticationPolicy with the new BearerTokenChallengeAuthenticationPolicy as its base. Key Vault's requirements for handling the challenge is still specific enough that I think it should remain there.

@christothes christothes self-assigned this Feb 5, 2021
@heaths
Copy link
Member Author

heaths commented Jun 9, 2021

Already done.

@heaths heaths closed this as completed Jun 9, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@christothes christothes

Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@jsquire @christothes @heaths @pakrym