Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] BlobSignedIdentifier.AccessPolicy should have a way to make the permission string in correct order #14456

Closed
blueww opened this issue Aug 21, 2020 · 2 comments · Fixed by #15727
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team. Storage Storage Service (Queues, Blobs, Files)

Comments

@blueww
Copy link
Member

blueww commented Aug 21, 2020

Describe the bug
Please provide the description of issue you're seeing.
create BlobSignedIdentifier object, and input permission as "wrld", then set the BlobSignedIdentifier to server, server report error

'XML specified is not syntactically valid.
RequestId:00938a0e-401e-0047-74b4-77b199000000
Time:2020-08-21T12:17:08.9855909Z
Status: 400 (XML specified is not syntactically valid.)
ErrorCode: InvalidXmlDocument

Expected behavior
What is the expected behavior?
XSCL should can help to make the permission string in correct order

Actual behavior (include Exception or Stack Trace)
What is the actual behavior?
XSCL can't make the permission string in correct order

To Reproduce
Steps to reproduce the behavior (include a code snippet, screenshot, or any additional information that might help us reproduce the issue)
Following code can repro it:

           BlobContainerClient container = new BlobContainerClient(connectionString, "test");
            container.CreateIfNotExists();
            List<BlobSignedIdentifier> policyList = new List<BlobSignedIdentifier>();

            BlobSignedIdentifier policyWithoutStartExpire = new BlobSignedIdentifier()
            {
                Id = "test",
                AccessPolicy = new BlobAccessPolicy()
                {
                    Permissions = "wrld"
                },
            };

            policyList.Add(policyWithoutStartExpire);
            container.SetAccessPolicy(permissions: policyList);

Environment:

  • Name and version of the Library package used: [e.g. Azure.Storage.Blobs 12.5.1]
  • Hosting platform or OS and .NET runtime version (dotnet --info output for .NET Core projects): [e.g. Azure AppService or Windows 10 .NET Framework 4.8]
.NET Core SDK (reflecting any global.json):
 Version:   2.2.108
 Commit:    33ed5b90ce

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.18363
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Program Files\dotnet\sdk\2.2.108\

Host (useful for support):
  Version: 2.2.6
  Commit:  7dac9b1b51

.NET Core SDKs installed:
  2.2.108 [C:\Program Files\dotnet\sdk]

.NET Core runtimes installed:
  Microsoft.AspNetCore.All 2.2.6 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.App 2.2.6 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 2.2.6 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]

To install additional .NET Core runtimes or SDKs:
  https://aka.ms/dotnet-download
  • IDE and version : [e.g. Visual Studio 16.3]
    VS 15.7.4
@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Aug 21, 2020
@blueww blueww changed the title [BUG] Set BlobSignedIdentifier.AccessPolicy should have a way to order the permission in correct order [BUG] Set BlobSignedIdentifier.AccessPolicy should have a way to make the permission string in correct order Aug 21, 2020
@blueww blueww changed the title [BUG] Set BlobSignedIdentifier.AccessPolicy should have a way to make the permission string in correct order [BUG] BlobSignedIdentifier.AccessPolicy should have a way to make the permission string in correct order Aug 21, 2020
@jsquire jsquire added Client This issue points to a problem in the data-plane of the library. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team Service Attention Workflow: This issue is responsible by Azure service team. Storage Storage Service (Queues, Blobs, Files) labels Aug 21, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 21, 2020
@ghost
Copy link

ghost commented Aug 21, 2020

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @xgithubtriage.

@jsquire
Copy link
Member

jsquire commented Aug 21, 2020

Thank you for your feedback. Tagging and routing to the team best able to assist.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
3 participants