Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove public ctors for QueueProperties/RuleProperties and add model factories instead #14501

Closed
JoshLove-msft opened this issue Aug 24, 2020 · 3 comments · Fixed by #14690
Closed
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus

Comments

@JoshLove-msft
Copy link
Member

Also add model factories for SubscriptionProperties/TopicProperties and all of the runtime property models.

@JoshLove-msft JoshLove-msft added Service Bus Client This issue points to a problem in the data-plane of the library. labels Aug 24, 2020
@JoshLove-msft JoshLove-msft added this to the [2020] September milestone Aug 24, 2020
@SeanFeldman
Copy link
Contributor

What would be the obvious benefit of a factory over constructors?

@JoshLove-msft
Copy link
Member Author

JoshLove-msft commented Aug 25, 2020

These types are not meant to be created by users in production scenarios. They are the return types when creating an entity, and also the input/output types when updating entities. The factories would be provided to support mocking.

@akScript
Copy link

akScript commented Oct 6, 2022

does this mean in order to do a UpdateRuleAsync you have to call GetRuleAsync first to get the RuleProperties object?

@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants