Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors from ApiCompat do not fail the build #15246

Closed
heaths opened this issue Sep 17, 2020 · 0 comments · Fixed by #15250
Closed

Errors from ApiCompat do not fail the build #15246

heaths opened this issue Sep 17, 2020 · 0 comments · Fixed by #15250
Labels
EngSys This issue is impacting the engineering system.

Comments

@heaths
Copy link
Member

heaths commented Sep 17, 2020

I was running into ApiCompat issues (dealing with resolution - a different error we're discussing offline right now) but, despite seeing red errors during build, the exit code was still 0

dotnet build sdk/search/Azure.Search.Documents.sln
$LASTEXITCODE
0

This should fail the build so that, at least, pipelines fail as a result.
@heaths heaths added the EngSys This issue is impacting the engineering system. label Sep 17, 2020
@heaths heaths mentioned this issue Sep 17, 2020
Closed
@weshaggard weshaggard mentioned this issue Sep 18, 2020
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch ApiCompat to use PackageDownload weshaggard/azure-sdk-for-net
1 participant
@heaths