Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] [Azure.Identity] The value of DefaultMsaltokenCacheKeyringAttribute1/2 must not be empty #15675

Closed
erich-wang opened this issue Oct 5, 2020 · 0 comments · Fixed by #15944
Closed

[BUG] [Azure.Identity] The value of DefaultMsaltokenCacheKeyringAttribute1/2 must not be empty #15675

erich-wang opened this issue Oct 5, 2020 · 0 comments · Fixed by #15944
Assignees
@schaabs
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. needs-team-triage Workflow: This issue needs the team to triage.

Comments

@erich-wang
Copy link
Member

erich-wang commented Oct 5, 2020 •
edited
Loading

Describe the bug
The value of DefaultMsaltokenCacheKeyringAttribute1/2 key vault pair must not be null, otherwise MSAL library will throw exception on Linux platform.

Proposed change:

        public static readonly KeyValuePair<string, string> DefaultMsaltokenCacheKeyringAttribute1 = new KeyValuePair<string, string>("MsalClientID", "Microsoft.Developer.IdentityService");


       public static readonly KeyValuePair<string, string> DefaultMsaltokenCacheKeyringAttribute2 = new KeyValuePair<string, string>("Microsoft.Developer.IdentityService", "1.0.0.0");

Please refer to change in https://github.com/Azure/azure-sdk-for-net/pull/15552/files/0e6904a88b0faf570a53c0d1b148e15bab5536b1..78c85396fa545dfc0bdc783f0cc3aab638f720ae#diff-3c93f67bd1b38d29f9181ebeedd18e45

Environment:

  • Name and version of the Library package used: [e.g. Azure.Identity]
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 5, 2020
@jsquire jsquire added Azure.Identity Client This issue points to a problem in the data-plane of the library. needs-team-triage Workflow: This issue needs the team to triage. labels Oct 5, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 5, 2020
@schaabs schaabs mentioned this issue Oct 13, 2020
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@schaabs schaabs

Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. needs-team-triage Workflow: This issue needs the team to triage.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Identity] Fix attribute values for MSAL extension config of gnome keyring schaabs/azure-sdk-for-net
3 participants
@jsquire @schaabs @erich-wang