Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestPipeline parameter should be removed from the template ci.yml #17569

Closed
pakrym opened this issue Dec 16, 2020 · 4 comments · Fixed by #17911, Azure/azure-sdk-for-js#13175, Azure/azure-sdk-for-python#16115 or Azure/azure-sdk-for-java#18573
Closed

TestPipeline parameter should be removed from the template ci.yml #17569

pakrym opened this issue Dec 16, 2020 · 4 comments · Fixed by #17911, Azure/azure-sdk-for-js#13175, Azure/azure-sdk-for-python#16115 or Azure/azure-sdk-for-java#18573
Assignees
@chidozieononiwu
Labels
Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Comments

@pakrym
Copy link
Contributor

pakrym commented Dec 16, 2020 •
edited
Loading

We already have a few instances of partners copying the template without realizing the parameter should be removed: https://github.com/Azure/azure-sdk-for-net/search?l=YAML&q=TestPipeline

I think it can be auto-calculated based on the template service name.

cc @chidozieononiwu @weshaggard @benbp
@pakrym pakrym added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Dec 16, 2020
@benbp benbp self-assigned this Dec 17, 2020
@kurtzeborn kurtzeborn assigned chidozieononiwu and unassigned benbp Jan 11, 2021
@chidozieononiwu chidozieononiwu mentioned this issue Jan 12, 2021
Merged
@chidozieononiwu
Copy link
Member

auto-calculating parameter values does not work for yaml. Perhaps we could use add a comment indicating that it should be removed when used in a not template pipeline.

@pakrym
Copy link
Contributor Author

pakrym commented Jan 12, 2021 •
edited
Loading

Can we base this condition on the artifact name? Or ServiceDirectory?

@chidozieononiwu
Copy link
Member

Can we base this condition on the artifact name? Or ServiceDirectory?

Yes we can. But we also need it for here

This was referenced Jan 12, 2021
Merged
Merged
Merged
@pakrym pakrym reopened this Jan 14, 2021
@pakrym
Copy link
Contributor Author

pakrym commented Jan 14, 2021

Let's keep it open until we fix occurrences in the C# repo

@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chidozieononiwu chidozieononiwu

Labels
Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
No milestone
3 participants
@benbp @pakrym @chidozieononiwu