Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MetricsAdvisor] DataSources properties should have setters #18317

Closed
kinelski opened this issue Feb 1, 2021 · 1 comment · Fixed by #21611
Closed

[MetricsAdvisor] DataSources properties should have setters #18317

kinelski opened this issue Feb 1, 2021 · 1 comment · Fixed by #21611
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor
Milestone
[2021] June

Comments

@kinelski
Copy link
Member

kinelski commented Feb 1, 2021

Their properties can be updated, but they can be set only once.

Goals:

  • Make properties settable (include null/empty validation in setters).
  • Add validation for them in the UpdateDataFeed tests.
@kinelski kinelski added Test Debt Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor labels Feb 1, 2021
@kinelski kinelski added this to the Backlog milestone Feb 1, 2021
@kinelski kinelski changed the title [MetricsAdvisor] DataSources properties should have getters [MetricsAdvisor] DataSources properties should have setters Feb 1, 2021
@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label Mar 12, 2021
@ghost
Copy link

ghost commented Mar 12, 2021

Hi @kinelski. There hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by removing the no-recent-activity label. Otherwise, we'll close this out in 7 days.

@kinelski kinelski removed the no-recent-activity There has been no recent activity on this issue. label Mar 12, 2021
@kinelski kinelski modified the milestones: Backlog, [2021] May Apr 19, 2021
@kinelski kinelski added the blocking-release Blocks release label Apr 19, 2021
@kinelski kinelski modified the milestones: [2021] May, [2021] June May 7, 2021
@kinelski kinelski mentioned this issue Jun 4, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor
Projects
None yet
Milestone
[2021] June
Development

Successfully merging a pull request may close this issue.

[MetricsAdvisor] Added setters to data feed sources kinelski/azure-sdk-for-net
1 participant
@kinelski